From patchwork Tue Aug 27 10:51:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 19544 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f199.google.com (mail-qc0-f199.google.com [209.85.216.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5035E2469A for ; Tue, 27 Aug 2013 10:51:45 +0000 (UTC) Received: by mail-qc0-f199.google.com with SMTP id n7sf5131905qcx.2 for ; Tue, 27 Aug 2013 03:51:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=HpK4O0BY3z/TISWmRL7Ror71HP0aVI4oHdNrCQKtZLU=; b=VFrHF+H+YKRqACckD7N2v9DgXuOO0BOHCvF26z/tSYlAMHcIQVIn0UlUGQKG91/hcE 8J9Ho07OXszTRbte0ReDpJdrS1S13VM7tyfyZ+J8p7/3JoY6pUyVw3H16Zpw7qXSaU/T uT+uWITIdWYJuqzK5qcLxryIxtWwMAXb1Cw67k8YFPgf+v6gRdNIJdlNjV9XbgclmBYQ oLSshpG6PGu5tkBh9UBkN8KIhyTru2+Xb9pLnMq3evrgwkWsZ6brZusWozFM/15R/a3I hLgHd2Pag32k2egISTlz7mR6dIAeJtTuRJ7JT1dSrWkJbbwOEkE9X1soMTCYzN2JGCzw wpjA== X-Received: by 10.236.17.161 with SMTP id j21mr299811yhj.55.1377600704761; Tue, 27 Aug 2013 03:51:44 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.70.228 with SMTP id p4ls2756649qeu.43.gmail; Tue, 27 Aug 2013 03:51:44 -0700 (PDT) X-Received: by 10.58.100.234 with SMTP id fb10mr19759845veb.5.1377600704684; Tue, 27 Aug 2013 03:51:44 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id jf10si4701233vdb.154.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 Aug 2013 03:51:44 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id hf12so2821284vcb.41 for ; Tue, 27 Aug 2013 03:51:44 -0700 (PDT) X-Gm-Message-State: ALoCoQm+y7KI0IeVD+iwUV2DsrG8zj510uzjJ+vh6mcHj1x++udqHHyhLmYU/L2zxVliAExRekne X-Received: by 10.221.56.194 with SMTP id wd2mr20083776vcb.7.1377600704605; Tue, 27 Aug 2013 03:51:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp287326vcz; Tue, 27 Aug 2013 03:51:44 -0700 (PDT) X-Received: by 10.60.35.40 with SMTP id e8mr18228617oej.34.1377600703773; Tue, 27 Aug 2013 03:51:43 -0700 (PDT) Received: from mail-ob0-f175.google.com (mail-ob0-f175.google.com [209.85.214.175]) by mx.google.com with ESMTPS id tk5si6076109oeb.80.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 Aug 2013 03:51:43 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.214.175 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.214.175; Received: by mail-ob0-f175.google.com with SMTP id xn12so4454093obc.6 for ; Tue, 27 Aug 2013 03:51:43 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.142.106 with SMTP id rv10mr1310997obb.51.1377600703459; Tue, 27 Aug 2013 03:51:43 -0700 (PDT) Received: by 10.182.28.168 with HTTP; Tue, 27 Aug 2013 03:51:43 -0700 (PDT) In-Reply-To: References: Date: Tue, 27 Aug 2013 16:21:43 +0530 Message-ID: Subject: Re: [ovs-dev] datapath: remove HAVE_MAC_RAW From: Viresh Kumar To: Jesse Gross Cc: "dev@openvswitch.org" , Linaro Networking , Patch Tracking X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 26 August 2013 21:59, Jesse Gross wrote: > This is compatibility code for older kernels so by definition it > doesn't exist in current kernels. You can't just remove it. My mistake :( Will something like this makes sense? This was changed in 2.6.22 by following patch: b0e380b [SK_BUFF]: unions of just one member don't get anything done, kill them -------x----------------x------------ diff --git a/acinclude.m4 b/acinclude.m4 index 73ee5ce..d6ac6af 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -238,8 +238,13 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ # quoting rules. OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [[[^@]]proto_data_valid], [OVS_DEFINE([HAVE_PROTO_DATA_VALID])]) - OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [raw], - [OVS_DEFINE([HAVE_MAC_RAW])]) + # Applicable only for kernels <= 2.6.21 + if test "$version" -le 2 && test "$patchlevel" -le 6; then + if test "$version.$patchlevel" != 2.6 || test "$sublevel" -le 21; then + OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [raw], + [OVS_DEFINE([HAVE_MAC_RAW])]) + fi + fi OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_dst(], [OVS_DEFINE([HAVE_SKB_DST_ACCESSOR_FUNCS])]) OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h],