From patchwork Fri May 17 08:47:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Gaignard X-Patchwork-Id: 17012 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ye0-f198.google.com (mail-ye0-f198.google.com [209.85.213.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E7A72238F0 for ; Fri, 17 May 2013 08:48:27 +0000 (UTC) Received: by mail-ye0-f198.google.com with SMTP id m14sf11641yen.9 for ; Fri, 17 May 2013 01:47:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :mime-version:x-received:date:message-id:subject:from:to:cc :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type; bh=EZvAuDc0DyJidCxfjEVji8k4dSLVHhvUI1som8fCpkM=; b=SxCi0n6ruwwVA1iec3Q3z6m6tpJqnP6BUFtcO7xDJ6NRDW9j5lhH0C8iRD5pyRMOAK nO76BbKZiv2w+njcH37yhifJ0Rivv6neWSxQg4uBu/MzJZMEOXY+Bl1cQ92Mxe59SSuW Viw6yzkWyR6qzCyCNyzvlecG6RRt6e2hqF13fsRug4Udugv1g+s4Vmb2H+odpnpxUnka da39re5DwYiZoEFyTesdle0oOUsMQJ7/Ye07n53xTX/t7lHatDzCSc+dtbceRj9LVF2P WaZWQWNEGwWsnp0Z0J9R12et49K39yLt8CCDKqBof+Ue0FgI5jf+AL/L+2JCrgnx4Qyc co8Q== X-Received: by 10.236.46.50 with SMTP id q38mr23175271yhb.44.1368780466896; Fri, 17 May 2013 01:47:46 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.13.199 with SMTP id j7ls1642887qec.61.gmail; Fri, 17 May 2013 01:47:46 -0700 (PDT) X-Received: by 10.220.238.4 with SMTP id kq4mr5288367vcb.73.1368780466754; Fri, 17 May 2013 01:47:46 -0700 (PDT) Received: from mail-vb0-x22c.google.com (mail-vb0-x22c.google.com [2607:f8b0:400c:c02::22c]) by mx.google.com with ESMTPS id ry9si3103044vdc.69.2013.05.17.01.47.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 May 2013 01:47:46 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c02::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c02::22c; Received: by mail-vb0-f44.google.com with SMTP id e13so2116932vbg.3 for ; Fri, 17 May 2013 01:47:46 -0700 (PDT) X-Received: by 10.52.233.34 with SMTP id tt2mr24727692vdc.70.1368780466564; Fri, 17 May 2013 01:47:46 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.126.138 with SMTP id c10csp99193vcs; Fri, 17 May 2013 01:47:45 -0700 (PDT) X-Received: by 10.112.14.36 with SMTP id m4mr11855551lbc.81.1368780465130; Fri, 17 May 2013 01:47:45 -0700 (PDT) Received: from mail-la0-x22c.google.com (mail-la0-x22c.google.com [2a00:1450:4010:c03::22c]) by mx.google.com with ESMTPS id mv5si3232122lbb.127.2013.05.17.01.47.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 May 2013 01:47:45 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:4010:c03::22c is neither permitted nor denied by best guess record for domain of benjamin.gaignard@linaro.org) client-ip=2a00:1450:4010:c03::22c; Received: by mail-la0-f44.google.com with SMTP id fr10so3995131lab.31 for ; Fri, 17 May 2013 01:47:44 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.139.4 with SMTP id qu4mr21246492lbb.37.1368780464393; Fri, 17 May 2013 01:47:44 -0700 (PDT) Received: by 10.114.77.74 with HTTP; Fri, 17 May 2013 01:47:44 -0700 (PDT) Date: Fri, 17 May 2013 10:47:44 +0200 Message-ID: Subject: video: fix gst_video_format_from_masks() for little endian masks with alpha From: Benjamin Gaignard To: Benjamin Gaignard Cc: Patch Tracking X-Gm-Message-State: ALoCoQkHP4GOIZahwiDvDccLCl70Z+scz6ZpZJ41lxdwNIpzxSbug881j2umhg7/vRKhdra/M99I X-Original-Sender: benjamin.gaignard@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c02::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , commit 5da2bd3216cd067e720386b791509bf2f5222a1a Author: Benjamin Gaignard Date: Thu May 16 10:52:29 2013 +0200 video: fix gst_video_format_from_masks() for little endian masks with alpha Need to byte-order swap the alpha mask as well in this case. https://bugzilla.gnome.org/show_bug.cgi?id=700413 red_mask >>= 8; diff --git a/gst-libs/gst/video/video-format.c b/gst-libs/gst/video/video-format.c index 592aa38..7fd60cf 100644 --- a/gst-libs/gst/video/video-format.c +++ b/gst-libs/gst/video/video-format.c @@ -2165,6 +2165,7 @@ gst_video_format_from_masks (gint depth, gint bpp, gint endianness, red_mask = GUINT32_TO_BE (red_mask); green_mask = GUINT32_TO_BE (green_mask); blue_mask = GUINT32_TO_BE (blue_mask); + alpha_mask = GUINT32_TO_BE (alpha_mask); endianness = G_BIG_ENDIAN; if (bpp == 24) {