From patchwork Tue Apr 19 21:15:35 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Huang X-Patchwork-Id: 1109 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:49:13 -0000 Delivered-To: patches@linaro.org Received: by 10.224.67.148 with SMTP id r20cs88022qai; Tue, 19 Apr 2011 14:15:36 -0700 (PDT) Received: by 10.227.110.37 with SMTP id l37mr435005wbp.114.1303247736289; Tue, 19 Apr 2011 14:15:36 -0700 (PDT) Received: from mail-wy0-f178.google.com (mail-wy0-f178.google.com [74.125.82.178]) by mx.google.com with ESMTPS id j14si576276wbj.75.2011.04.19.14.15.35 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2011 14:15:36 -0700 (PDT) Received-SPF: neutral (google.com: 74.125.82.178 is neither permitted nor denied by best guess record for domain of jim.huang@linaro.org) client-ip=74.125.82.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 74.125.82.178 is neither permitted nor denied by best guess record for domain of jim.huang@linaro.org) smtp.mail=jim.huang@linaro.org Received: by wyb33 with SMTP id 33so127141wyb.37 for ; Tue, 19 Apr 2011 14:15:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.67.135 with SMTP id j7mr186010wed.54.1303247735371; Tue, 19 Apr 2011 14:15:35 -0700 (PDT) Received: by 10.216.8.193 with HTTP; Tue, 19 Apr 2011 14:15:35 -0700 (PDT) Date: Wed, 20 Apr 2011 05:15:35 +0800 Message-ID: Subject: [PATCH android/bionic 2/3] Hide internal symbol __bionic_brk used by brk() and sbrk() From: Jim Huang To: linaro-dev Cc: patches __bionic_brk was shared by brk() and sbrk(), which should be implementor specific and hidden to application developers. Code Review: https://review.source.android.com/#change,17364 >From 7452bce8defc06a34612b25ace2ef802c0579a83 Mon Sep 17 00:00:00 2001 From: Jim Huang Date: Wed, 20 Apr 2011 04:53:30 +0800 Subject: [PATCH] Hide internal symbol __bionic_brk used by brk() and sbrk() __bionic_brk was shared by brk() and sbrk(), which should be implementor specific and hidden to application developers. Change-Id: Iffe6ab3783e297d919a15812ac4910141a3ff066 --- libc/unistd/brk.c | 1 + libc/unistd/sbrk.c | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libc/unistd/brk.c b/libc/unistd/brk.c index bf2f108..5cc28d3 100644 --- a/libc/unistd/brk.c +++ b/libc/unistd/brk.c @@ -30,6 +30,7 @@ #include /* shared with sbrk.c */ +__LIBC_HIDDEN__ char *__bionic_brk; int brk(void* end_data) diff --git a/libc/unistd/sbrk.c b/libc/unistd/sbrk.c index a112b6c..7fc21b9 100644 --- a/libc/unistd/sbrk.c +++ b/libc/unistd/sbrk.c @@ -32,7 +32,7 @@ #define SBRK_ALIGN 32 /* shared with brk() implementation */ -char* __bionic_brk; +extern char* __bionic_brk; void *sbrk(ptrdiff_t increment) { -- 1.7.4.1