From patchwork Tue Apr 19 21:16:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Huang X-Patchwork-Id: 1108 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:49:13 -0000 Delivered-To: patches@linaro.org Received: by 10.224.67.148 with SMTP id r20cs88069qai; Tue, 19 Apr 2011 14:16:41 -0700 (PDT) Received: by 10.216.67.136 with SMTP id j8mr523912wed.102.1303247800452; Tue, 19 Apr 2011 14:16:40 -0700 (PDT) Received: from mail-wy0-f178.google.com (mail-wy0-f178.google.com [74.125.82.178]) by mx.google.com with ESMTPS id l13si596400wer.32.2011.04.19.14.16.40 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2011 14:16:40 -0700 (PDT) Received-SPF: neutral (google.com: 74.125.82.178 is neither permitted nor denied by best guess record for domain of jim.huang@linaro.org) client-ip=74.125.82.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 74.125.82.178 is neither permitted nor denied by best guess record for domain of jim.huang@linaro.org) smtp.mail=jim.huang@linaro.org Received: by wyb33 with SMTP id 33so127945wyb.37 for ; Tue, 19 Apr 2011 14:16:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.152.170 with SMTP id d42mr1956366wek.39.1303247799871; Tue, 19 Apr 2011 14:16:39 -0700 (PDT) Received: by 10.216.8.193 with HTTP; Tue, 19 Apr 2011 14:16:39 -0700 (PDT) Date: Wed, 20 Apr 2011 05:16:39 +0800 Message-ID: Subject: [PATCH android/bionic 3/3] Hide libm private symbols using GCC visibility pragma From: Jim Huang To: linaro-dev Cc: patches Following the visibility changes in libc.so, this patch attempts to hide private symbols in libm.so. Reference code size measurements for HTC Passion: $ arm-eabi-size out/target/product/passion/system/lib/libm.so [before] text data bss dec hex filename 88423 256 32 88711 15a87 out/target/product/passion/system/lib/libm.so [after] text data bss dec hex filename 87950 256 32 88238 158ae out/target/product/passion/system/lib/libm.so Code Review: https://review.source.android.com/#change,17358 >From 331af85e9694c4c9247e39716f97ede1a62ee9ce Mon Sep 17 00:00:00 2001 From: Jim Huang Date: Wed, 20 Apr 2011 05:02:10 +0800 Subject: [PATCH] Hide libm private symbols using GCC visibility pragma Following the visibility changes in libc.so, this patch attempts to hide private symbols in libm.so. Reference code size measurements for HTC Passion: $ arm-eabi-size out/target/product/passion/system/lib/libm.so [before] text data bss dec hex filename 88423 256 32 88711 15a87 out/target/product/passion/system/lib/libm.so [after] text data bss dec hex filename 87950 256 32 88238 158ae out/target/product/passion/system/lib/libm.so Change-Id: I51841a9f5d7b7663b95ebf5c1bd17d1ec9a6c1b6 --- libm/src/math_private.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libm/src/math_private.h b/libm/src/math_private.h index 5f6e088..8c9f04f 100644 --- a/libm/src/math_private.h +++ b/libm/src/math_private.h @@ -20,6 +20,8 @@ #include #include +#include + /* * The original fdlibm code used statements like: * n0 = ((*(int*)&one)>>29)^1; * index of high word * @@ -270,4 +272,6 @@ float __kernel_cosdf(double); float __kernel_tandf(double,int); int __kernel_rem_pio2f(float*,float*,int,int,int,const int*); +#include + #endif /* !_MATH_PRIVATE_H_ */ -- 1.7.4.1