From patchwork Tue Aug 5 14:49:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 34953 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f200.google.com (mail-ob0-f200.google.com [209.85.214.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 791D320523 for ; Tue, 5 Aug 2014 14:50:19 +0000 (UTC) Received: by mail-ob0-f200.google.com with SMTP id nu7sf4383586obb.7 for ; Tue, 05 Aug 2014 07:50:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:references:in-reply-to:cc:subject:precedence :reply-to:list-id:list-unsubscribe:list-archive:list-post:list-help :list-subscribe:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=4PVxFgTCLdPKIpt2wK614yo0weMgrXb8G0AiX5iOea0=; b=QKFngYab/0rkyWinNZwThlQF8IpH9cPtHvIYmtc4Wl6qLZTfv3jclvd3nDd0mhTllo BiH3md/l7t1Yb0T06jIvMdkE7hf76tQyHbcKvMZSl1mSxeTtUL+kYEjtpBNbaxhCoZ5h w9frU1iqrA1tZ1wTa7zvk/zygtWMs67wBtS0kzRfNRa6VQqPAt2+IbosVYWWNcoX+N5F NG6ithdZ9o6iKLagiaIPM2qrOH+D7H2TmerOOtOswnTvackC5U68BowMVBwPo8PrcR8I wlHJ6G9VaWwLWkdZiVEcVjUt158g3h9duS2hPMfgD6piaDS6hbu5+zJMxYBmqdHu4mag SzOQ== X-Gm-Message-State: ALoCoQnI9/SI0DDNXxSSIqk1KRNp7BTpwL+u7xOhkSXdxUmvKIYx2ITxXYF5G4SZf7UMlKUEzt5X X-Received: by 10.42.38.15 with SMTP id a15mr2820135ice.30.1407250219095; Tue, 05 Aug 2014 07:50:19 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.107.2 with SMTP id g2ls275873qgf.72.gmail; Tue, 05 Aug 2014 07:50:19 -0700 (PDT) X-Received: by 10.52.164.11 with SMTP id ym11mr1963718vdb.74.1407250218987; Tue, 05 Aug 2014 07:50:18 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id c7si1268178vcc.15.2014.08.05.07.50.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 05 Aug 2014 07:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id la4so1670965vcb.5 for ; Tue, 05 Aug 2014 07:50:18 -0700 (PDT) X-Received: by 10.52.144.14 with SMTP id si14mr1445746vdb.95.1407250218795; Tue, 05 Aug 2014 07:50:18 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp395110vcb; Tue, 5 Aug 2014 07:50:18 -0700 (PDT) X-Received: by 10.50.114.38 with SMTP id jd6mr7594092igb.25.1407250218024; Tue, 05 Aug 2014 07:50:18 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id e9si4686055ict.95.2014.08.05.07.50.17 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 05 Aug 2014 07:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XEg41-0006BU-PI; Tue, 05 Aug 2014 14:50:09 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XEg40-0006BK-Fb for edk2-devel@lists.sourceforge.net; Tue, 05 Aug 2014 14:50:08 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=lersek@redhat.com; helo=mx1.redhat.com; Received: from mx1.redhat.com ([209.132.183.28]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1XEg3z-0006pr-2t for edk2-devel@lists.sourceforge.net; Tue, 05 Aug 2014 14:50:08 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s75EnxIk010875 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Aug 2014 10:49:59 -0400 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s75EnvY3030472; Tue, 5 Aug 2014 10:49:58 -0400 Message-ID: <53E0EF15.7030207@redhat.com> Date: Tue, 05 Aug 2014 16:49:57 +0200 From: Laszlo Ersek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: "Carsey, Jaben" References: <1406938797-25234-1-git-send-email-lersek@redhat.com> In-Reply-To: <1406938797-25234-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Spam-Score: -2.2 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1XEg3z-0006pr-2t Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH 0/2] StdLib: fix two instances of missing braces X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lersek@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On 08/02/14 02:19, Laszlo Ersek wrote: > Laszlo Ersek (2): > StdLib/LibC/gdtoa: fix "missing braces around initializer" > StdLib/LibC/Stdio: fix "missing braces around initializer" > > StdLib/LibC/Stdio/vswscanf.c | 2 +- > StdLib/LibC/gdtoa/strtof.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Ping -- these patches are trivial. Jaben, can you please review & commit them? Alternatively, I guess the build options for StdLib could privately re-introduce -Wno-missing-braces: I'm fine either way, but right now, with current BaseTools, StdLib doesn't build with gcc. Thanks, Laszlo ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk diff --git a/StdLib/LibC/Stdio/Stdio.inf b/StdLib/LibC/Stdio/Stdio.inf index a61a558..301716f 100644 --- a/StdLib/LibC/Stdio/Stdio.inf +++ b/StdLib/LibC/Stdio/Stdio.inf @@ -144,4 +144,4 @@ # Nasty things could happen if you do. # [BuildOptions] - GCC:*_*_*_CC_FLAGS = -fno-builtin -Wno-pointer-to-int-cast -Wno-int-to-pointer-cast -Wno-format + GCC:*_*_*_CC_FLAGS = -fno-builtin -Wno-pointer-to-int-cast -Wno-int-to-pointer-cast -Wno-format -Wno-missing-braces diff --git a/StdLib/LibC/gdtoa/gdtoa.inf b/StdLib/LibC/gdtoa/gdtoa.inf index fbe3ac1..722164e 100644 --- a/StdLib/LibC/gdtoa/gdtoa.inf +++ b/StdLib/LibC/gdtoa/gdtoa.inf @@ -75,3 +75,6 @@ LibLocale LibStdLib LibString + +[BuildOptions] + GCC:*_*_*_CC_FLAGS = -Wno-missing-braces