From patchwork Tue Apr 8 18:20:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 28035 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F0BA620447 for ; Tue, 8 Apr 2014 18:22:15 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id j17sf5759932oag.10 for ; Tue, 08 Apr 2014 11:22:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:references:in-reply-to:cc:subject:precedence :list-id:list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=K2EqQ+qkOZoCBE/IrN1sBPa3KUAb3qeGDnvhjDNaSQM=; b=YcXz8vvknoUnJ1rwCYwERxa2bDHl6oXDjrAayPNYnpTblWxjlsllJx5PZt5hJAjrDl 2p1wyBhHVT786jJukTwEGNH8vJAFauj1055Vet/iqOntqju4RiDyXxo7DYN+mwOCrim3 9KLkRPOqA+nhFK+mJG47KwIFC6lhHqfrC5XySK5dPIhzUxcMGoqbRd9uOvhRwBHAhfHd mXWVBUOgbuqtk7vPBA7/5esOT9Coak9AD5s9/kpiZpULpmoXOEO7XY5ZREJ7eJbslUuV SBctRcBM2QhevOrvRLxnUpm9s6VQAA9e67BjH9ptg6+Eby4rHExMOUftpNsbJcrFQgP4 xkGQ== X-Gm-Message-State: ALoCoQkSvRYCNERNeHt50t55ySP0HbMJDGJ+a/WRBTrf2HdifJHdtSL8ouUyMH3qfeDp0GkdjUaz X-Received: by 10.42.185.1 with SMTP id cm1mr2361225icb.10.1396981335508; Tue, 08 Apr 2014 11:22:15 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.106.71 with SMTP id d65ls296736qgf.17.gmail; Tue, 08 Apr 2014 11:22:15 -0700 (PDT) X-Received: by 10.58.195.202 with SMTP id ig10mr1294104vec.33.1396981335346; Tue, 08 Apr 2014 11:22:15 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id xt2si555076vcb.33.2014.04.08.11.22.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 11:22:15 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id jx11so1122061veb.17 for ; Tue, 08 Apr 2014 11:22:15 -0700 (PDT) X-Received: by 10.58.111.163 with SMTP id ij3mr1727980veb.26.1396981335257; Tue, 08 Apr 2014 11:22:15 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp267970vcv; Tue, 8 Apr 2014 11:22:14 -0700 (PDT) X-Received: by 10.220.161.8 with SMTP id p8mr4459320vcx.4.1396981334854; Tue, 08 Apr 2014 11:22:14 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id xt10si550120veb.112.2014.04.08.11.22.14 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 08 Apr 2014 11:22:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXadO-00062y-9l; Tue, 08 Apr 2014 18:20:34 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WXadN-00062t-F1 for xen-devel@lists.xen.org; Tue, 08 Apr 2014 18:20:33 +0000 Received: from [85.158.139.211:11409] by server-16.bemta-5.messagelabs.com id CB/64-19700-0FD34435; Tue, 08 Apr 2014 18:20:32 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-16.tower-206.messagelabs.com!1396981231!6246022!1 X-Originating-IP: [74.125.83.53] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24362 invoked from network); 8 Apr 2014 18:20:32 -0000 Received: from mail-ee0-f53.google.com (HELO mail-ee0-f53.google.com) (74.125.83.53) by server-16.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 8 Apr 2014 18:20:32 -0000 Received: by mail-ee0-f53.google.com with SMTP id b57so983785eek.26 for ; Tue, 08 Apr 2014 11:20:31 -0700 (PDT) X-Received: by 10.15.93.201 with SMTP id w49mr4428226eez.69.1396981231018; Tue, 08 Apr 2014 11:20:31 -0700 (PDT) Received: from [10.80.2.139] ([185.25.64.249]) by mx.google.com with ESMTPSA id a4sm6148168eep.12.2014.04.08.11.20.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 11:20:30 -0700 (PDT) Message-ID: <53443DED.8060901@linaro.org> Date: Tue, 08 Apr 2014 19:20:29 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20131104 Icedove/17.0.10 MIME-Version: 1.0 To: Ian Jackson , Ian Campbell References: <1396618125-1623-1-git-send-email-ian.campbell@citrix.com> <21310.51440.15560.997315@mariner.uk.xensource.com> <1396971362.22845.266.camel@kazak.uk.xensource.com> <21316.10617.170497.479163@mariner.uk.xensource.com> <534431E3.7080207@linaro.org> In-Reply-To: <534431E3.7080207@linaro.org> Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org Subject: Re: [Xen-devel] [PATCH v2] tools: implement initial ramdisk support for ARM. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On 04/08/2014 06:29 PM, Julien Grall wrote: > Hi Ian & Ian, > > On 04/08/2014 05:53 PM, Ian Jackson wrote: >> Ian Campbell writes ("Re: [PATCH v2] tools: implement initial ramdisk support for ARM."): >>> On Fri, 2014-04-04 at 16:00 +0100, Ian Jackson wrote: >>>> I think this is a viable backport candidate. Can you let me know when >>>> it's in-tree and I'll add it to my list >>> >>> It's in now, commit 314c9815e2f5dc8a9fec11e0cf9b49b16ed0e96b >> >> Noted, thanks. > > I'm unable to boot a guest with this patch on Xen 4.5. Revert it works > correctly. The guest is blocked without useful log. > > My config: > > kernel="/root/zImage" > memory=128 > name="test" > vcpus=2 > autoballon="off" > root="/dev/xvda" > extra="console=hvc0" > disk=[ 'phy:/dev/loop0,xvda,w' ] > This small changes fix boot of the guest with RAM < 128Mb: I guess this is because the kernel is extracting on it. I think we should follow the same "algorithm" as Xen (see place_modules) to decide where the modules should be loaded. Regards, diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c index f051515..2228ba5 100644 --- a/tools/libxc/xc_dom_arm.c +++ b/tools/libxc/xc_dom_arm.c @@ -300,7 +300,7 @@ int arch_setup_meminit(struct xc_dom_image *dom) if ( ramend >= ram128mb + modsize && kernend < ram128mb ) modbase = ram128mb; else if ( ramend >= kernend + modsize ) - modbase = kernend; + modbase = ramend - modsize; else return -1;