From patchwork Fri May 10 16:22:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 16870 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f71.google.com (mail-qa0-f71.google.com [209.85.216.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id AF6A5238F6 for ; Fri, 10 May 2013 16:22:47 +0000 (UTC) Received: by mail-qa0-f71.google.com with SMTP id g10sf957131qah.6 for ; Fri, 10 May 2013 09:22:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=+nE2YxxNVuqoP88h69JKPTxSACRz5n2bMYG1CpSHZIQ=; b=NJ7T518eDF1XLn0UZ3LTKITGcOLENTqpJ0UyMwxHacyrE/1nPs/pvIaX5JaQ0yKjX2 39mmXMcOoeCdPmvHoLsOYcOkKD/j2e+JdRBVfSQLq5Mk7R+dd5bFdHUE5umrNomWWiiz iYP7xHFbv39AI9yHKN9REnXepHnxzm+rJmaD47uJzEN1g5bw5CeW9h2/xdVu8qMbQi18 iEmJuJNyH4n4e3dzdawTPKt3JmfFkQM96e7+BGyddrRiFw0+WTafnXFc8uiUujTwF0nL iGLU52F4efzbjxZ+xhQIsn3OtqqiUg29ygDhKttigm9kRfQ0aPpCE00aYXDNe5SdRv1d 4hcw== X-Received: by 10.236.181.234 with SMTP id l70mr8261175yhm.53.1368202941353; Fri, 10 May 2013 09:22:21 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.70.195 with SMTP id o3ls1998063qeu.14.gmail; Fri, 10 May 2013 09:22:21 -0700 (PDT) X-Received: by 10.58.220.129 with SMTP id pw1mr11707635vec.32.1368202940900; Fri, 10 May 2013 09:22:20 -0700 (PDT) Received: from mail-ve0-x232.google.com (mail-ve0-x232.google.com [2607:f8b0:400c:c01::232]) by mx.google.com with ESMTPS id iz8si1618487vdb.110.2013.05.10.09.22.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 10 May 2013 09:22:20 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::232; Received: by mail-ve0-f178.google.com with SMTP id jy13so4065763veb.9 for ; Fri, 10 May 2013 09:22:20 -0700 (PDT) X-Received: by 10.52.69.109 with SMTP id d13mr9895215vdu.75.1368202940812; Fri, 10 May 2013 09:22:20 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.217.15 with SMTP id hk15csp62089vcb; Fri, 10 May 2013 09:22:20 -0700 (PDT) X-Received: by 10.194.235.169 with SMTP id un9mr18543568wjc.1.1368202939753; Fri, 10 May 2013 09:22:19 -0700 (PDT) Received: from mail-we0-x22d.google.com (mail-we0-x22d.google.com [2a00:1450:400c:c03::22d]) by mx.google.com with ESMTPS id br4si844587wjb.158.2013.05.10.09.22.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 10 May 2013 09:22:19 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c03::22d is neither permitted nor denied by best guess record for domain of julien.grall@linaro.org) client-ip=2a00:1450:400c:c03::22d; Received: by mail-we0-f173.google.com with SMTP id q54so4060158wes.4 for ; Fri, 10 May 2013 09:22:19 -0700 (PDT) X-Received: by 10.195.12.228 with SMTP id et4mr25803942wjd.59.1368202939053; Fri, 10 May 2013 09:22:19 -0700 (PDT) Received: from [10.80.2.139] (firewall.ctxuk.citrix.com. [46.33.159.2]) by mx.google.com with ESMTPSA id cw8sm4445234wib.7.2013.05.10.09.22.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 10 May 2013 09:22:18 -0700 (PDT) Message-ID: <518D1EB8.1050400@linaro.org> Date: Fri, 10 May 2013 17:22:16 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Julien Grall CC: xen-devel@lists.xen.org, Stefano.Stabellini@eu.citrix.com, ian.campbell@citrix.com, patches@linaro.org, keir@xen.org Subject: Re: [PATCH V4 02/32] xen/mm: Align virtual address on PAGE_SIZE in iounmap References: <1368198723-24639-1-git-send-email-julien.grall@linaro.org> <1368198723-24639-3-git-send-email-julien.grall@linaro.org> In-Reply-To: <1368198723-24639-3-git-send-email-julien.grall@linaro.org> X-Gm-Message-State: ALoCoQkTF0Ri+WUMTQVRqNk05dcRRlfV+FddqtVqkgYxqhW971WoC1hC5ESI2ojxxXt6uQ1uGH8h X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , ioremap function can unlikely return an unaligned virtual address if the physical address itself is unaligned on a page size. Signed-off-by: Julien Grall Acked-by: Jan Beulich CC: keir@xen.org Changes in v5: - replace unsigned int by unsigned long Changes in v4: - replace vaddr_t by unsigned int Acked-by: Keir Fraser --- xen/include/xen/vmap.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/include/xen/vmap.h b/xen/include/xen/vmap.h index 88e5d99..daee7f5 100644 --- a/xen/include/xen/vmap.h +++ b/xen/include/xen/vmap.h @@ -15,7 +15,9 @@ void __iomem *ioremap(paddr_t, size_t); static inline void iounmap(void __iomem *va) { - vunmap((void __force *)va); + unsigned long addr = (unsigned long)(void __force *)va; + + vunmap((void *)(addr & PAGE_MASK)); } void vm_init(void);