From patchwork Tue Nov 18 16:44:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 41052 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2DEFB241C9 for ; Tue, 18 Nov 2014 16:47:11 +0000 (UTC) Received: by mail-la0-f69.google.com with SMTP id gd6sf487271lab.0 for ; Tue, 18 Nov 2014 08:47:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=9jJi3KgQysWOqA7GUKEXOk+AXzt5pyu6qzrh+xsgct0=; b=hJ5oT+WSp24KRiqGNzzhCzSM2zZkMcRntXMZNztECvgMpcd/y0U8nVci5AGTAvEGEy Z8khyT0dWoaanTspczedAXlU8AxxWICP+PTnsIzp2YffPhVEPJq8LSlGbsHiTX1nDLwc 6uaXl2VVK0A+tZc5p91Nev+Ac5g3i3DGNtdgQkxwYTL9atE/gVVHTIKOqqzkV67LY3Yt vU7CslC6CIlA7BSoLbuS2WNzY5MoUx89CX1g5rBLpBo8Ya1w8mz6B9+/3Ctzv2wCfFYY 8xK/2WJNhriivQ7Z8i9aCzfhRe+kgeyRcuWoXOulJTkDMozjch9VJrvNaeDTX5ulgidW 48Xg== X-Gm-Message-State: ALoCoQlQRdXW/pERTZbEljbxrlwfAQTe72fzAbBSpfxZwWbvKvNJsdtKd6v3CDxCqYDQAzYiQSP4 X-Received: by 10.181.13.147 with SMTP id ey19mr4161441wid.2.1416329229800; Tue, 18 Nov 2014 08:47:09 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.180.109.170 with SMTP id ht10ls1094732wib.9.canary; Tue, 18 Nov 2014 08:47:09 -0800 (PST) X-Received: by 10.194.78.82 with SMTP id z18mr20293423wjw.120.1416329229713; Tue, 18 Nov 2014 08:47:09 -0800 (PST) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com. [209.85.212.178]) by mx.google.com with ESMTPS id ec1si21964568wib.101.2014.11.18.08.47.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Nov 2014 08:47:09 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.212.178 as permitted sender) client-ip=209.85.212.178; Received: by mail-wi0-f178.google.com with SMTP id hi2so4845041wib.17 for ; Tue, 18 Nov 2014 08:47:09 -0800 (PST) X-Received: by 10.194.209.180 with SMTP id mn20mr49628497wjc.49.1416329229588; Tue, 18 Nov 2014 08:47:09 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp1360472lbc; Tue, 18 Nov 2014 08:47:08 -0800 (PST) X-Received: by 10.52.37.201 with SMTP id a9mr19248521vdk.56.1416329228095; Tue, 18 Nov 2014 08:47:08 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id v10si10594755vcq.85.2014.11.18.08.47.07 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 18 Nov 2014 08:47:08 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XqluE-0007DG-1i; Tue, 18 Nov 2014 16:45:30 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XqluD-0007Cj-7d for xen-devel@lists.xen.org; Tue, 18 Nov 2014 16:45:29 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 8F/7E-17694-7A77B645; Tue, 18 Nov 2014 16:45:27 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-3.tower-31.messagelabs.com!1416329125!12266735!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n X-StarScan-Received: X-StarScan-Version: 6.12.4; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27210 invoked from network); 18 Nov 2014 16:45:27 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-3.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 18 Nov 2014 16:45:27 -0000 X-IronPort-AV: E=Sophos;i="5.07,410,1413244800"; d="scan'208";a="194056786" Received: from ukmail1.uk.xensource.com (10.80.16.128) by smtprelay.citrix.com (10.13.107.80) with Microsoft SMTP Server id 14.3.181.6; Tue, 18 Nov 2014 11:44:50 -0500 Received: from drall.uk.xensource.com ([10.80.16.71]) by ukmail1.uk.xensource.com with smtp (Exim 4.69) (envelope-from ) id 1XqltZ-0008T3-LJ; Tue, 18 Nov 2014 16:44:50 +0000 Received: by drall.uk.xensource.com (sSMTP sendmail emulation); Tue, 18 Nov 2014 16:44:49 +0000 From: Ian Campbell To: Date: Tue, 18 Nov 2014 16:44:46 +0000 Message-ID: <1416329088-23328-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1416329045.17982.27.camel@citrix.com> References: <1416329045.17982.27.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Ian Campbell , julien.grall@linaro.org, tim@xen.org, Clark Laughlin , stefano.stabellini@eu.citrix.com, Pranavkumar Sawargaonkar Subject: [Xen-devel] [PATCH for-4.5 2/4] xen: arm: correct off by one in xgene-storm's map_one_mmio X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.212.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: The callers pass the end as the pfn immediately *after* the last page to be mapped, therefore adding one is incorrect and causes an additional page to be mapped. At the same time correct the printing of the mfn values, zero-padding them to 16 digits as for a paddr when they are frame numbers is just confusing. Signed-off-by: Ian Campbell --- xen/arch/arm/platforms/xgene-storm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c index 29c4752..38674cd 100644 --- a/xen/arch/arm/platforms/xgene-storm.c +++ b/xen/arch/arm/platforms/xgene-storm.c @@ -45,9 +45,9 @@ static int map_one_mmio(struct domain *d, const char *what, { int ret; - printk("Additional MMIO %"PRIpaddr"-%"PRIpaddr" (%s)\n", + printk("Additional MMIO %lx-%lx (%s)\n", start, end, what); - ret = map_mmio_regions(d, start, end - start + 1, start); + ret = map_mmio_regions(d, start, end - start, start); if ( ret ) printk("Failed to map %s @ %"PRIpaddr" to dom%d\n", what, start, d->domain_id);