From patchwork Fri Oct 10 08:44:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 38544 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D3D7C202DB for ; Fri, 10 Oct 2014 08:46:45 +0000 (UTC) Received: by mail-la0-f69.google.com with SMTP id q1sf1849611lam.8 for ; Fri, 10 Oct 2014 01:46:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=v4bAr7bMqwaJvVIk9Cn4G/a8cu2k9WhHzcyAiFOUz3c=; b=D5psjo2KbexKOK0lIcHF9YZ66g/XBqZRv/EL9i1qo+XgqIRsJ4kuxZ7A06sszGXPgs EsaAziCh1jF0Hye+AXLRLI23g0vuGlWf1MhruEXaWr20WwMnQW1aeVdxVcGEdNrqYLxp xzz+Em5WWlTipR7/aDzO2yGjA1dlnKzTtnt2/fGrOXq+UpYoSIiZZe/XqdScQYumoWbE cLKb4FKicaAmNAZ1p9dpkMqKUJiE22ECp+BJtX4jv1lq34tbjm4q08LO8sJvBU+xGeoo 7tvw3umcL+DuDpW9FwBZTSvSYgF2UVTdOhcoXWlaXlYjrpx1+1RUaFpZiojvSDUl5apO YGqA== X-Gm-Message-State: ALoCoQn7cnQwJrxMGxvI3eLEiRWjrr5/EXCZNIeb6VdYIdCKZO0DJd/CW1MmWY3nSqu1e7L9bijG X-Received: by 10.112.52.165 with SMTP id u5mr319373lbo.12.1412930801516; Fri, 10 Oct 2014 01:46:41 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.170.133 with SMTP id am5ls274072lac.54.gmail; Fri, 10 Oct 2014 01:46:41 -0700 (PDT) X-Received: by 10.112.140.137 with SMTP id rg9mr1673274lbb.93.1412930801303; Fri, 10 Oct 2014 01:46:41 -0700 (PDT) Received: from mail-la0-f42.google.com (mail-la0-f42.google.com [209.85.215.42]) by mx.google.com with ESMTPS id p12si8109639lal.32.2014.10.10.01.46.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 10 Oct 2014 01:46:41 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.42 as permitted sender) client-ip=209.85.215.42; Received: by mail-la0-f42.google.com with SMTP id mk6so2814456lab.29 for ; Fri, 10 Oct 2014 01:46:41 -0700 (PDT) X-Received: by 10.152.23.170 with SMTP id n10mr3130520laf.29.1412930800661; Fri, 10 Oct 2014 01:46:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp382575lbz; Fri, 10 Oct 2014 01:46:40 -0700 (PDT) X-Received: by 10.140.22.82 with SMTP id 76mr6136501qgm.16.1412930799401; Fri, 10 Oct 2014 01:46:39 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id c6si9853532qar.93.2014.10.10.01.46.38 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 10 Oct 2014 01:46:39 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XcVoa-0001hR-Fu; Fri, 10 Oct 2014 08:44:44 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XcVoZ-0001hK-AC for xen-devel@lists.xen.org; Fri, 10 Oct 2014 08:44:43 +0000 Received: from [85.158.137.68:55174] by server-3.bemta-3.messagelabs.com id 28/83-22751-A7C97345; Fri, 10 Oct 2014 08:44:42 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-15.tower-31.messagelabs.com!1412930680!12548413!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.12.2; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26690 invoked from network); 10 Oct 2014 08:44:42 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-15.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 10 Oct 2014 08:44:42 -0000 X-IronPort-AV: E=Sophos;i="5.04,690,1406592000"; d="scan'208";a="180078382" Message-ID: <1412930678.10650.20.camel@citrix.com> From: Ian Campbell To: Andrew Cooper Date: Fri, 10 Oct 2014 09:44:38 +0100 In-Reply-To: <1412930128.10650.17.camel@citrix.com> References: <1412872535-8221-1-git-send-email-anthony.perard@citrix.com> <20141009165408.GB12637@aepfle.de> <5436BEC1.9020604@citrix.com> <1412930128.10650.17.camel@citrix.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.6-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Anthony PERARD , Olaf Hering , Ian Jackson , Xen Devel Subject: Re: [Xen-devel] [PATCH] tools/hotplug/Linux: Fix build X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.42 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Fri, 2014-10-10 at 09:35 +0100, Ian Campbell wrote: > On Thu, 2014-10-09 at 17:58 +0100, Andrew Cooper wrote: > > On 09/10/14 17:54, Olaf Hering wrote: > > > On Thu, Oct 09, Anthony PERARD wrote: > > > > > >> make[6]: Entering directory '/build/xen-unstable/src/xen-unstable/tools/hotplug/Linux' > > >> [...] > > >> make -C systemd all > > >> make -C systemd install > > > I wonder why that happens anyway, isnt that the bug? Shouldnt some "all" > > > depend on "install", or whatever? > > > > > > Olaf > > > > all: should never depend on install. > > > > all: will be the default target from `make`, which is expected to build > > components, and is specifically separate from `make install DESTDIR=$foo` > > That's true, and as such Olaf's eac3f5122fd4769b2885d8ad78bcbcf5df2472c1 > is of course not correct, somehow I didn't manage to notice this. > > I intend to revert shortly... I've just pushed the following. I expect the actual problem is that the buildsystem is recusing into this directory twice simultaneously for "all" and "install" at the same time. That seems likely to be an issue with the Makefile in the parent directory. Should subdirs-install depend on subdirs-all perhaps? commit 66bb8b04f0032ddf0aa007b0850be1ec15477d60 Author: Ian Campbell Date: Fri Oct 10 09:35:34 2014 +0100 Revert "tools/hotplug: fix race during xen.conf creation" This reverts commit eac3f5122fd4769b2885d8ad78bcbcf5df2472c1. The "all" target should never depend on "install", it is supposed to only build not install. Signed-off-by: Ian Campbell > > Ian. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel Tested-by: Olaf Hering Acked-by: Ian Jackson diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile index 6950d24..9c58b33 100644 --- a/tools/hotplug/Linux/systemd/Makefile +++ b/tools/hotplug/Linux/systemd/Makefile @@ -21,11 +21,10 @@ ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES) \ $(XEN_SYSTEMD_SERVICE) .PHONY: all -all: install +all: $(ALL_XEN_SYSTEMD) .PHONY: clean clean: - rm -f $(ALL_XEN_SYSTEMD) .PHONY: install install: $(ALL_XEN_SYSTEMD)