From patchwork Tue Sep 23 13:50:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 37732 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2CB1E20C03 for ; Tue, 23 Sep 2014 13:51:51 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id b57sf2919497eek.5 for ; Tue, 23 Sep 2014 06:51:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-length:content-type :content-transfer-encoding; bh=Y0ykvws5exlURc31It1EpH0/otnzZhZtfTCpFkZJfcU=; b=OhWtFMnJxvc1OHUamq6/jqnEh4aeF6btFw3lmykCGNBTv84Jz9WK1Qtv5IZ275FGgZ SA9lTIJtvyO5SWIvfjPvrnN7x7Vj+b4BQH/n9SG4Su0aV2eJZEphanhj41FSKGs/sHVR OupmuHu7pMaa/z6RYy/IdA5W3iIYLUr3pDJaMfOwbgYlFNansT11mKXiSD6D/Pwkzigj pD2TT/XQjRqHxocVxeKuGY+fmWdjD+TGVlnQPTE5EERXoXbRkcq+RAh+QYrbWIRH9Oj1 FUpy45Aff2SE+JibqrV9tL+RdX11FIyMTuO+IZzuY4++hecoS/UvAGi6becBClQpCz1+ nuFQ== X-Gm-Message-State: ALoCoQlMye64ApkdjYyXYuTzldaVo27xYkTXPUFEty0Ugt2jddn+Ox4vzFpzbWnirI/yctaZ2mSk X-Received: by 10.152.2.97 with SMTP id 1mr475233lat.6.1411480310334; Tue, 23 Sep 2014 06:51:50 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.19.42 with SMTP id b10ls45176lae.28.gmail; Tue, 23 Sep 2014 06:51:50 -0700 (PDT) X-Received: by 10.112.198.163 with SMTP id jd3mr9973667lbc.72.1411480310030; Tue, 23 Sep 2014 06:51:50 -0700 (PDT) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com [209.85.215.51]) by mx.google.com with ESMTPS id j10si18730137laf.95.2014.09.23.06.51.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Sep 2014 06:51:50 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by mail-la0-f51.google.com with SMTP id gi9so8518317lab.24 for ; Tue, 23 Sep 2014 06:51:49 -0700 (PDT) X-Received: by 10.112.53.230 with SMTP id e6mr3186689lbp.100.1411480309955; Tue, 23 Sep 2014 06:51:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp415108lbb; Tue, 23 Sep 2014 06:51:49 -0700 (PDT) X-Received: by 10.224.10.198 with SMTP id q6mr32735384qaq.55.1411480307827; Tue, 23 Sep 2014 06:51:47 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id y8si12410416qci.49.2014.09.23.06.51.43 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 23 Sep 2014 06:51:47 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XWQUN-0005Gg-6r; Tue, 23 Sep 2014 13:50:43 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XWQUL-0005GP-SW for xen-devel@lists.xen.org; Tue, 23 Sep 2014 13:50:41 +0000 Received: from [193.109.254.147:63179] by server-8.bemta-14.messagelabs.com id 7C/AE-01875-1BA71245; Tue, 23 Sep 2014 13:50:41 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-16.tower-27.messagelabs.com!1411480238!7091678!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.12.2; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10037 invoked from network); 23 Sep 2014 13:50:40 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-16.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 23 Sep 2014 13:50:40 -0000 X-IronPort-AV: E=Sophos;i="5.04,580,1406592000"; d="scan'208";a="175293020" Message-ID: <1411480234.1781.50.camel@kazak.uk.xensource.com> From: Ian Campbell To: Meng Xu Date: Tue, 23 Sep 2014 14:50:34 +0100 In-Reply-To: <1410730649-2417-1-git-send-email-mengxu@cis.upenn.edu> References: <1410730649-2417-1-git-send-email-mengxu@cis.upenn.edu> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.2-1+b1 MIME-Version: 1.0 X-DLP: MIA2 Cc: xisisu@gmail.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, lu@cse.wustl.edu, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ptxlinh@gmail.com, xumengpanda@gmail.com, JBeulich@suse.com, chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu Subject: Re: [Xen-devel] Introduce rtds real-time scheduler for Xen X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote: > This serie of patches adds rtds real-time scheduler to Xen. I've applied v4 of this series, which was apparently unthreaded and had no introductory email (hence replying to what I think is v3's intro). For the avoidance of doubt I've applied the patches with these message-ids in this order: <1411251228-2093-1-git-send-email-mengxu@cis.upenn.edu> <1411251258-2131-1-git-send-email-mengxu@cis.upenn.edu> <1411251283-2169-1-git-send-email-mengxu@cis.upenn.edu> <1411251302-2207-1-git-send-email-mengxu@cis.upenn.edu> I think that's right but I suggest you check that the end result in the staging branch corresponds with what you thought you were sending. Note that tools/libxc/xenctrl.h moved to tools/libxc/include/xenctrl.h since your patch was posted and I fixed that up as I went. Also, it didn't build for arm32 due to: sched_rt.c: In function ‘burn_budget’: sched_rt.c:630:17: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘s_time_t’ [-Werror=format] I therefore folded this into the first patch: (this seemed easier than another round trip, I hope it is ok) Apart from trying not to forget the introductory mail and threading in the future, please use the same $subject prefix on the introductory mail as the rest of the series (e.g. '[PATCH for 4.5 v4 0/4]: Introduce rtds real-time scheduler for Xen'), so I can figure out what goes with what. Ian. diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c index 4c522bb..6c8faeb 100644 --- a/xen/common/sched_rt.c +++ b/xen/common/sched_rt.c @@ -626,7 +626,7 @@ burn_budget(const struct scheduler *ops, struct rt_vcpu *svc, s_time_t now) */ if ( delta < 0 ) { - printk("%s, ATTENTION: now is behind last_start! delta = %ld\n", + printk("%s, ATTENTION: now is behind last_start! delta=%"PRI_stime"\n", __func__, delta); svc->last_start = now; return;