From patchwork Mon Jan 13 10:47:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taras Kondratiuk X-Patchwork-Id: 23158 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f70.google.com (mail-oa0-f70.google.com [209.85.219.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8CC7C202FA for ; Mon, 13 Jan 2014 10:47:37 +0000 (UTC) Received: by mail-oa0-f70.google.com with SMTP id h16sf28443883oag.1 for ; Mon, 13 Jan 2014 02:47:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=0p3GCOXDRVQtB5/A6fpppL4jjwyq879ZDuzpI3kQzQ0=; b=eimwEkq/+f6R52vMDUTWeD+d4J0eiLnMzMi5R44RNawMJQcbFKyZDVGq7C3hlcMygf /Xth5DLUFapVd9ZbdzjVjcsxN4Bejw4HXlNAXvPmeCQ6oS4DBc6TzDDZkcFnkcZGk/mq 2mYYdMjA6xlyu6yCMV5McB6ahzRjZMMp6AH2rbSJoSJD1x+fz9WkDwrAu4EDhQ3IlDXo OX4Mzbg3mu1Bv4Ece222Qbv84Vz0EjPYxsxYEf7rMAcz25zq9+0PTX4clFVyEta9zV8Q btuW4anMSwS0OFoKj7FPLpyv1S3V8ftv6S0nrDMgViRjxlhjWr2sMFBVEeN4T1K9iM8G GwaQ== X-Gm-Message-State: ALoCoQk+kwHvdX93hEbT6RhQJpdoOfP1MrFujC8npzwFDSWkmymsGRt7qEpM8mcfCv40DXg4t7AJ X-Received: by 10.182.16.199 with SMTP id i7mr513491obd.42.1389610056662; Mon, 13 Jan 2014 02:47:36 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.129.98 with SMTP id nv2ls1115332qeb.31.gmail; Mon, 13 Jan 2014 02:47:36 -0800 (PST) X-Received: by 10.59.5.74 with SMTP id ck10mr119896ved.73.1389610056566; Mon, 13 Jan 2014 02:47:36 -0800 (PST) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx.google.com with ESMTPS id tj7si10843533vdc.72.2014.01.13.02.47.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 13 Jan 2014 02:47:36 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.54 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.54; Received: by mail-vb0-f54.google.com with SMTP id w20so654772vbb.41 for ; Mon, 13 Jan 2014 02:47:36 -0800 (PST) X-Received: by 10.58.243.37 with SMTP id wv5mr1159079vec.41.1389610056488; Mon, 13 Jan 2014 02:47:36 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.59.13.131 with SMTP id ey3csp118532ved; Mon, 13 Jan 2014 02:47:36 -0800 (PST) X-Received: by 10.15.24.142 with SMTP id j14mr27295690eeu.52.1389610055696; Mon, 13 Jan 2014 02:47:35 -0800 (PST) Received: from mail-ea0-f180.google.com (mail-ea0-f180.google.com [209.85.215.180]) by mx.google.com with ESMTPS id p9si27953406eew.97.2014.01.13.02.47.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 13 Jan 2014 02:47:35 -0800 (PST) Received-SPF: neutral (google.com: 209.85.215.180 is neither permitted nor denied by best guess record for domain of taras.kondratiuk@linaro.org) client-ip=209.85.215.180; Received: by mail-ea0-f180.google.com with SMTP id f15so3212154eak.25 for ; Mon, 13 Jan 2014 02:47:35 -0800 (PST) X-Received: by 10.14.126.1 with SMTP id a1mr26952762eei.81.1389610055272; Mon, 13 Jan 2014 02:47:35 -0800 (PST) Received: from condor-x220.synapse.com ([195.238.93.36]) by mx.google.com with ESMTPSA id z46sm476197een.1.2014.01.13.02.47.34 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 13 Jan 2014 02:47:34 -0800 (PST) From: Taras Kondratyuk To: Simon Horman Cc: kexec@lists.infradead.org, patches@linaro.org, Taras Kondratiuk Subject: [RESEND PATCH] kexec: arm: Fix endianness in crashdump header Date: Mon, 13 Jan 2014 12:47:25 +0200 Message-Id: <1389610045-5372-1-git-send-email-kondratyuk.taras@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: taras.kondratiuk@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.54 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Taras Kondratiuk Currently little-endian ELFDATA is hard-coded in crashdump header. This lead to a wrong header format if crashdump is generated on BE system. Set native endianness into ELFDATA field. Signed-off-by: Taras Kondratiuk --- Based on commit 027413d "kexec: Add m68k support" kexec/arch/arm/crashdump-arm.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/kexec/arch/arm/crashdump-arm.c b/kexec/arch/arm/crashdump-arm.c index 01973b1..0cd6935 100644 --- a/kexec/arch/arm/crashdump-arm.c +++ b/kexec/arch/arm/crashdump-arm.c @@ -31,6 +31,13 @@ #include "../../crashdump.h" #include "crashdump-arm.h" +#if __BYTE_ORDER == __LITTLE_ENDIAN +#define ELFDATANATIVE ELFDATA2LSB +#elif __BYTE_ORDER == __BIG_ENDIAN +#define ELFDATANATIVE ELFDATA2MSB +#else +#error "Unknown machine endian" +#endif /* * Used to save various memory ranges/regions needed for the captured @@ -47,7 +54,7 @@ static struct memory_range crash_reserved_mem; static struct crash_elf_info elf_info = { .class = ELFCLASS32, - .data = ELFDATA2LSB, + .data = ELFDATANATIVE, .machine = EM_ARM, .page_offset = PAGE_OFFSET, };