From patchwork Fri Oct 18 20:52:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ryan S. Arnold" X-Patchwork-Id: 21180 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3FDAD202E6 for ; Fri, 18 Oct 2013 20:53:43 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id n12sf11877278oag.8 for ; Fri, 18 Oct 2013 13:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=17lYFtRTfAegZQO6XUEf6UJ0hD7nE26nIevXPp/KQlQ=; b=bxauaySyQP5l4HJqCBg4bSbMYS+KX7321HtzpPs22nbyxfDWYb+ZowHW4K/ohNVte/ yfw3DEzfSIRehfJvFC9MRJXjajq/kBLY6CywKiSLPPJ0AeWnqn06zcwpUZ5bj8x0zkAQ nEegCxYwZpBqihQedUxX1SIwe3Q0+STe5caLSIWFjVtDKKE0331g+v57+OGlOzp5LpIZ EvgrYG9/1X37W0VDV5aq6F7MXd/xbb9Bn4Tp5f4Gi5Tf6/DgkYjbqAMyzFenXco+CkWQ E8OjIhdYTbxTgCle3/TW9zd6yEoH4IyeZe+hvnjBxI6vET4JzFuNJoFdUPtLEEvEjk1Q TTrQ== X-Received: by 10.182.126.137 with SMTP id my9mr1868555obb.13.1382129622824; Fri, 18 Oct 2013 13:53:42 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.133.201 with SMTP id pe9ls1351345qeb.23.gmail; Fri, 18 Oct 2013 13:53:42 -0700 (PDT) X-Received: by 10.220.11.7 with SMTP id r7mr3477067vcr.12.1382129622676; Fri, 18 Oct 2013 13:53:42 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id fb5si678465vcb.15.2013.10.18.13.53.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Oct 2013 13:53:42 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id hu8so615288vcb.14 for ; Fri, 18 Oct 2013 13:53:42 -0700 (PDT) X-Gm-Message-State: ALoCoQnFZt+Sy5YTg89+q7z+3mr35sGBaKslRqY+sxeWEsKMwzc7LhU5a5t1RUAaDuZ6WzAms1Ay X-Received: by 10.52.227.6 with SMTP id rw6mr2896705vdc.19.1382129622493; Fri, 18 Oct 2013 13:53:42 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp63333vcz; Fri, 18 Oct 2013 13:53:42 -0700 (PDT) X-Received: by 10.50.234.162 with SMTP id uf2mr961954igc.48.1382129621841; Fri, 18 Oct 2013 13:53:41 -0700 (PDT) Received: from mail-ie0-f173.google.com (mail-ie0-f173.google.com [209.85.223.173]) by mx.google.com with ESMTPS id ip5si1657259igb.70.2013.10.18.13.53.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Oct 2013 13:53:41 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.223.173 is neither permitted nor denied by best guess record for domain of ryan.arnold@linaro.org) client-ip=209.85.223.173; Received: by mail-ie0-f173.google.com with SMTP id u16so7323193iet.4 for ; Fri, 18 Oct 2013 13:53:41 -0700 (PDT) X-Received: by 10.50.115.100 with SMTP id jn4mr925870igb.9.1382129621455; Fri, 18 Oct 2013 13:53:41 -0700 (PDT) Received: from badwing.hsd1.mn.comcast.net. (c-71-195-40-9.hsd1.mn.comcast.net. [71.195.40.9]) by mx.google.com with ESMTPSA id cl4sm14877361igc.1.2013.10.18.13.53.40 for (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2013 13:53:40 -0700 (PDT) From: "Ryan S. Arnold" To: Rob Savoye Cc: patches@linaro.org, "Ryan S. Arnold" Subject: [PATCH][Cbuildv2/get_source 08/17] lib/common.sh: Fix for unknown/unmatched get_source request. Date: Fri, 18 Oct 2013 15:52:50 -0500 Message-Id: <1382129579-5777-9-git-send-email-ryan.arnold@linaro.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1382129579-5777-1-git-send-email-ryan.arnold@linaro.org> References: <1382129579-5777-1-git-send-email-ryan.arnold@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ryan.arnold@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: "Ryan S. Arnold" We aren't guaranteed a match after checking snapshots and source.conf. So put in an error leg at the end of the function. --- lib/common.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/common.sh b/lib/common.sh index 80f5fe9..64d0a30 100644 --- a/lib/common.sh +++ b/lib/common.sh @@ -445,6 +445,12 @@ get_source() fi fi + # We aren't guaranteed a match even after snapshots and sources.conf have + # been checked. + if test x"${url}" = x; then + return 1 + fi + echo "${url}${branch:+ ${branch}}${revision:+ ${revision}}" return 0