From patchwork Fri Oct 4 21:27:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ryan S. Arnold" X-Patchwork-Id: 20839 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E1B912395E for ; Fri, 4 Oct 2013 21:27:38 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id lf12sf7237250vcb.6 for ; Fri, 04 Oct 2013 14:27:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=cWjb4ZzyMxXpaZ+JKSXcxD3Cgiv3jL155cyj4UT9iMY=; b=BlVcJMyXqnHWhEdnD4j+Be+tHjKI19Ub+vFotOyMePofLV2bYwGyYsI1brw1RPT2IN ujqEO4CpS8Tm8lBtZkSgDlnMUBbDQOqQyG0vEh3E8N5Cufqa8O3ktOFW+cz+ZWwzual5 PbtJQ6UCtOFWfNV2WLC7ooiJ070CLFnexgS0e/CuRmW7gPvOua7/MBtlH7afSUlZw+3e oCfdSmImw3BZIoGhNB4up3+HJpFT7bCbOZZLkLbrVTkaDNJnoykFU0MTAf4v8XWy5zPe VADxBr3QrUqBkN49ursv+EKoAGPJko9ZU00CQITp9X2E+xwME1j1B8zRo0/qgafFTdJk e/5g== X-Received: by 10.236.220.39 with SMTP id n37mr13593553yhp.15.1380922058146; Fri, 04 Oct 2013 14:27:38 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.24.172 with SMTP id v12ls1495570qef.91.gmail; Fri, 04 Oct 2013 14:27:38 -0700 (PDT) X-Received: by 10.58.133.66 with SMTP id pa2mr14027703veb.18.1380922058006; Fri, 04 Oct 2013 14:27:38 -0700 (PDT) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx.google.com with ESMTPS id 10si3891177vcs.30.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Oct 2013 14:27:38 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.169; Received: by mail-ve0-f169.google.com with SMTP id db12so2767935veb.14 for ; Fri, 04 Oct 2013 14:27:37 -0700 (PDT) X-Gm-Message-State: ALoCoQnXk8QjjJp2cm4ZqRVgzqVqUTfWfxSYbJ/wY2IbtkMzb5lu37+XFyurDWUAJyRJ5YNSEBXJ X-Received: by 10.220.94.206 with SMTP id a14mr3252712vcn.19.1380922057789; Fri, 04 Oct 2013 14:27:37 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp69817vcz; Fri, 4 Oct 2013 14:27:37 -0700 (PDT) X-Received: by 10.43.104.73 with SMTP id dl9mr10113312icc.39.1380922057116; Fri, 04 Oct 2013 14:27:37 -0700 (PDT) Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com [209.85.223.174]) by mx.google.com with ESMTPS id il3si15612742icb.79.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Oct 2013 14:27:37 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.223.174 is neither permitted nor denied by best guess record for domain of ryan.arnold@linaro.org) client-ip=209.85.223.174; Received: by mail-ie0-f174.google.com with SMTP id u16so10487981iet.33 for ; Fri, 04 Oct 2013 14:27:36 -0700 (PDT) X-Received: by 10.50.130.106 with SMTP id od10mr8314717igb.1.1380922056567; Fri, 04 Oct 2013 14:27:36 -0700 (PDT) Received: from localhost.net (c-71-195-40-9.hsd1.mn.comcast.net. [71.195.40.9]) by mx.google.com with ESMTPSA id ka1sm9461353igb.7.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 04 Oct 2013 14:27:35 -0700 (PDT) From: "Ryan S. Arnold" To: rob.savoye@linaro.org Cc: patches@linaro.org, "Ryan S. Arnold" Subject: [PATCH] Only return early on error following configure Date: Fri, 4 Oct 2013 16:27:28 -0500 Message-Id: <1380922048-2464-1-git-send-email-ryan.arnold@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ryan.arnold@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: "Ryan S. Arnold" In lib/configure.sh control was returning unconditionally after configure was executed which prevents stamp-configure-* generation. --- lib/configure.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/configure.sh b/lib/configure.sh index 4857818..0e72cf6 100755 --- a/lib/configure.sh +++ b/lib/configure.sh @@ -180,7 +180,10 @@ configure_build() export CONFIG_SHELL=${bash_shell} fi dryrun "(cd ${builddir} && ${CONFIG_SHELL} ${srcdir}/configure ${default_configure_flags} ${opts})" - return $? + if test $? -gt 0; then + error "Configure of $1 failed." + return $? + fi # unset this to avoid problems later default_configure_flags=