From patchwork Mon Sep 9 11:59:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 19835 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f71.google.com (mail-qa0-f71.google.com [209.85.216.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4327A24687 for ; Mon, 9 Sep 2013 11:59:13 +0000 (UTC) Received: by mail-qa0-f71.google.com with SMTP id f11sf217077qae.10 for ; Mon, 09 Sep 2013 04:59:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=Bz2G5scqPGFC67eOnVK45Dr72zN/FT73Sb1rriUuGH8=; b=izcdNApXlZYbaaUDZ22qPPZTv187Y4rwc50V3ZEKsJteTIl8EDuscYQbWK3ZGVI8XX j08kVl7nGwvU78IJnUky8Sho9EisQ9TZqcoPxxRQ7dCIooxT19b6DmjyVKo5zyDz94ex VK+AnBxcjnio/ZSWO95IosJ0jvIUXciMsRipy/JDDqqN8AEM15RC7rxkk+i2K5NFd/OK 1ZiTx+o3BlJ1gHFG3f28Z1M1BSprBUurY1rmVtSxO+KAmrdS0CZjc9qeGCRjcW+R4lq8 yJdx6VKGUrHbcgRPX6OC0ZF14ZubNrSGgv5O/Zd0uC+4qje5RinsccPzpM0EVU+BKuKn mwmg== X-Received: by 10.236.24.195 with SMTP id x43mr6208314yhx.3.1378727953061; Mon, 09 Sep 2013 04:59:13 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.85.200 with SMTP id j8ls1642924qez.6.gmail; Mon, 09 Sep 2013 04:59:13 -0700 (PDT) X-Received: by 10.220.199.5 with SMTP id eq5mr17255338vcb.16.1378727952991; Mon, 09 Sep 2013 04:59:12 -0700 (PDT) Received: from mail-vb0-f50.google.com (mail-vb0-f50.google.com [209.85.212.50]) by mx.google.com with ESMTPS id o4si3054999vcx.133.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Sep 2013 04:59:12 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.50 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.50; Received: by mail-vb0-f50.google.com with SMTP id x14so3788008vbb.23 for ; Mon, 09 Sep 2013 04:59:12 -0700 (PDT) X-Gm-Message-State: ALoCoQlfTYhsTmP4semhsutUjK/ALELBSGXlYM1rbW/5NfFFXtTLdpzRp+iFAPshc9hwFHG/V6we X-Received: by 10.58.67.9 with SMTP id j9mr1479990vet.22.1378727952720; Mon, 09 Sep 2013 04:59:12 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp83469vcz; Mon, 9 Sep 2013 04:59:12 -0700 (PDT) X-Received: by 10.194.75.165 with SMTP id d5mr12387466wjw.18.1378727951626; Mon, 09 Sep 2013 04:59:11 -0700 (PDT) Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by mx.google.com with ESMTPS id m6si4268410wjx.52.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Sep 2013 04:59:11 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.173 is neither permitted nor denied by best guess record for domain of julien.grall@linaro.org) client-ip=209.85.212.173; Received: by mail-wi0-f173.google.com with SMTP id hq15so3253012wib.6 for ; Mon, 09 Sep 2013 04:59:11 -0700 (PDT) X-Received: by 10.180.24.198 with SMTP id w6mr8257456wif.1.1378727950958; Mon, 09 Sep 2013 04:59:10 -0700 (PDT) Received: from belegaer.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id l9sm6954603wif.10.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Sep 2013 04:59:10 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Cc: stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, patches@linaro.org, Julien Grall Subject: [PATCH] xen/dts: fix DT_ROOT_NODE_ADDR_CELLS_DEFAULT Date: Mon, 9 Sep 2013 12:59:07 +0100 Message-Id: <1378727947-3775-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.50 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The commit dbd1243 "xen/arm: Add helpers to use the device tree" introduced DT_ROOT_NODE_ADDR_CELLS_DEFAULT with is used for default value when #address-cells is not found in the device tree. This value is wrong due to a bad copy from Linux code. The ePAR (section 2.3.5) says: "If missing, a client program should assume a default value of 2 for #address-cells, and a value of 1 for #size-cells." Signed-off-by: Julien Grall Acked-by: Ian Campbell --- xen/include/xen/device_tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 402cef2..5cc1905 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -233,7 +233,7 @@ struct dt_device_node * __init dt_find_interrupt_controller(const char *compat); #define dt_compat_cmp(s1, s2, l) strnicmp((s1), (s2), l) /* Default #address and #size cells */ -#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 1 +#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 #define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 #define for_each_property_of_node(dn, pp) \