From patchwork Fri Sep 6 05:45:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: manjunath.goudar@linaro.org X-Patchwork-Id: 19797 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f71.google.com (mail-vb0-f71.google.com [209.85.212.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A34C024869 for ; Fri, 6 Sep 2013 05:45:57 +0000 (UTC) Received: by mail-vb0-f71.google.com with SMTP id g17sf3099117vbg.2 for ; Thu, 05 Sep 2013 22:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=ztZS62YH+Z5QnZA/KcmAd4zOIjzxWpdEH8Vwy31yasc=; b=I/MgSgBqB0Vc3exBVgDu8ZRbGhuVTf4dJiTGHvPveLZdThnunToKXBklJtWvHZjJJC +DTVUWtQtue0J29F7IT2rgZSi8gOHEaXgqE5gO2EKTv5dRohtqJAeEkFRSJ3gLmmWYXC FzeDE7p6a08H/9pBusxq98r3TD38bGxH/fRebxYVRPI8fjF+zxWXoQU5PwsPDqATY8Hz 0/iKCHRe9/1p6BT5empP/BuO4PaWgtnDlNXPnjhi5HAIG9qx1/k0Kl9UPr3P1/Pe4t3N mxQF6JSQ7UcGacMBDvRu7BPaYGv9e1b2OaisfhT7Mpno2kqfnLO0BLuuxA2NdkKgqZ6+ Q4VQ== X-Received: by 10.236.108.233 with SMTP id q69mr296803yhg.11.1378446356881; Thu, 05 Sep 2013 22:45:56 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.104.198 with SMTP id gg6ls856989qeb.89.gmail; Thu, 05 Sep 2013 22:45:56 -0700 (PDT) X-Received: by 10.58.136.4 with SMTP id pw4mr630340veb.10.1378446356760; Thu, 05 Sep 2013 22:45:56 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id i15si270690vep.16.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 22:45:56 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id oy12so1291448veb.12 for ; Thu, 05 Sep 2013 22:45:56 -0700 (PDT) X-Gm-Message-State: ALoCoQlxXjMcJk6do7uoA/IxFMv+OGswHR/lPVrCYdsBLm37vhlNw15UmvqKbeosmssMc9K82yl9 X-Received: by 10.220.1.203 with SMTP id 11mr589525vcg.15.1378446356351; Thu, 05 Sep 2013 22:45:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp321122vcz; Thu, 5 Sep 2013 22:45:55 -0700 (PDT) X-Received: by 10.66.155.69 with SMTP id vu5mr1364833pab.176.1378446355607; Thu, 05 Sep 2013 22:45:55 -0700 (PDT) Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by mx.google.com with ESMTPS id xx2si1613747pac.82.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 22:45:55 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.192.181 is neither permitted nor denied by best guess record for domain of manjunath.goudar@linaro.org) client-ip=209.85.192.181; Received: by mail-pd0-f181.google.com with SMTP id g10so2814001pdj.12 for ; Thu, 05 Sep 2013 22:45:55 -0700 (PDT) X-Received: by 10.68.225.164 with SMTP id rl4mr943794pbc.100.1378446355027; Thu, 05 Sep 2013 22:45:55 -0700 (PDT) Received: from manjunath-Latitude-E6420.LGE.NET ([203.247.149.152]) by mx.google.com with ESMTPSA id vz4sm2173754pab.11.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Sep 2013 22:45:54 -0700 (PDT) From: Manjunath Goudar To: linus.walleij@linaro.org Cc: dsaxena@linaro.org, manjunath.goudar@linaro.org, patches@linaro.org Subject: [PATCH] INPUT/MISC: Fix input/misc PWM related undefined reference errors. Date: Fri, 6 Sep 2013 11:15:42 +0530 Message-Id: <1378446342-5444-1-git-send-email-manjunath.goudar@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: manjunath.goudar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch adds a PWM dependency to configure the INPUT_MAX8997_HAPTIC and INPUT_PWM_BEEPER. Without this patch, build system can lead to build failure. This was observed during randconfig testing, in which INPUT_MAX8997_HAPTIC or INPUT_PWM_BEEPER was enabled w/o PWM being enabled. leading to the following error: init/built-in.o drivers/built-in.o: In function `max8997_haptic_disable': :(.text+0x1073a0): undefined reference to `pwm_disable' drivers/built-in.o: In function `max8997_haptic_remove': :(.text+0x1073fc): undefined reference to `pwm_free' drivers/built-in.o: In function `max8997_haptic_play_effect_work': :(.text+0x1074f0): undefined reference to `pwm_config' :(.text+0x1075b0): undefined reference to `pwm_enable' drivers/built-in.o: In function `max8997_haptic_probe': :(.text+0x1076f8): undefined reference to `pwm_request' :(.text+0x1077e8): undefined reference to `pwm_free' drivers/built-in.o: In function `pwm_beeper_resume': :(.text+0x1081a4): undefined reference to `pwm_config' make: *** [vmlinux] Error 1 Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Deepak Saxena Cc: Linus Walleij Cc: Dmitry Torokhov Cc: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/input/misc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index aa51baa..265240b 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -156,7 +156,7 @@ config INPUT_MAX8925_ONKEY config INPUT_MAX8997_HAPTIC tristate "MAXIM MAX8997 haptic controller support" - depends on HAVE_PWM && MFD_MAX8997 + depends on HAVE_PWM && MFD_MAX8997 && PWM select INPUT_FF_MEMLESS help This option enables device driver support for the haptic controller @@ -461,7 +461,7 @@ config INPUT_PCF8574 config INPUT_PWM_BEEPER tristate "PWM beeper support" - depends on HAVE_PWM || PWM + depends on HAVE_PWM && PWM help Say Y here to get support for PWM based beeper devices.