From patchwork Fri Aug 16 21:05:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 19272 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-gh0-f200.google.com (mail-gh0-f200.google.com [209.85.160.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C2717248E6 for ; Fri, 16 Aug 2013 21:06:45 +0000 (UTC) Received: by mail-gh0-f200.google.com with SMTP id 10sf1948628ghy.11 for ; Fri, 16 Aug 2013 14:06:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=X0+XsYKwH5/SWaeXg5zB7GL9HA98+zMVSXmSQxqWo8Q=; b=fFDWKB8kjU7npOZHn0wdsYilZiNUlPVik03AGDyCT3y3vDLtxrM7HsDh1b6V4WBZu6 DQAkd6+T3nr/wzMFGFpHhl0uVDNnQdnYwKWcj6Z3AtF+A2JXvV6QRa6BJ7j31TS32y/b bBWQmL2RsqKmIUbBOmq21cY6i2fCPqiyye9584lsF0xuLmz63K238EPr7a0IPFfodjbw fyD6Qd8iM1wsksu0ln67kG1UAuPp4t6VJg9VEpg3U4RiUeJdqmlBHFVbb6M7KkhJVWO1 FM8Kr78BwCVJMG3Zr++07R26f8FwjAV24YcskKtr8LTJPZRnlw7MQgy2YhcdUmKIitmL ekJw== X-Received: by 10.236.80.42 with SMTP id j30mr1244439yhe.29.1376687205482; Fri, 16 Aug 2013 14:06:45 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.64.201 with SMTP id q9ls1019251qes.41.gmail; Fri, 16 Aug 2013 14:06:45 -0700 (PDT) X-Received: by 10.220.166.19 with SMTP id k19mr12631vcy.42.1376687205339; Fri, 16 Aug 2013 14:06:45 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id vv9si783080vec.43.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Aug 2013 14:06:45 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id gd11so1767735vcb.19 for ; Fri, 16 Aug 2013 14:06:45 -0700 (PDT) X-Gm-Message-State: ALoCoQnSWTDUzgrLriU4qIlKcH6xwdRpK9Od1muW44Ao1fYtkLSvzImaLs323AOzT23BPJ4cejNc X-Received: by 10.220.249.67 with SMTP id mj3mr2902272vcb.23.1376687205270; Fri, 16 Aug 2013 14:06:45 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp89473vcz; Fri, 16 Aug 2013 14:06:44 -0700 (PDT) X-Received: by 10.180.198.44 with SMTP id iz12mr594013wic.32.1376687204267; Fri, 16 Aug 2013 14:06:44 -0700 (PDT) Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by mx.google.com with ESMTPS id ll10si1287240wjb.109.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Aug 2013 14:06:44 -0700 (PDT) Received-SPF: neutral (google.com: 74.125.82.47 is neither permitted nor denied by best guess record for domain of julien.grall@linaro.org) client-ip=74.125.82.47; Received: by mail-wg0-f47.google.com with SMTP id j13so1877091wgh.26 for ; Fri, 16 Aug 2013 14:06:43 -0700 (PDT) X-Received: by 10.180.37.20 with SMTP id u20mr625192wij.21.1376687203810; Fri, 16 Aug 2013 14:06:43 -0700 (PDT) Received: from belegaer.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id b13sm797327wic.9.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Aug 2013 14:06:43 -0700 (PDT) From: Julien Grall To: stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com Cc: patches@linaro.org, andre.przywara@linaro.org, xen-devel@lists.xen.org, Julien Grall Subject: [RFC 24/24] xen/arm: Check if the device is available before using it Date: Fri, 16 Aug 2013 22:05:56 +0100 Message-Id: <1376687156-6737-25-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1376687156-6737-1-git-send-email-julien.grall@linaro.org> References: <1376687156-6737-1-git-send-email-julien.grall@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , It's possible to have a device description in the DTS but the device is not wired. device_init must check if the device is available before doing anything with it. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- xen/arch/arm/device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c index dc751a9..f86b2e3 100644 --- a/xen/arch/arm/device.c +++ b/xen/arch/arm/device.c @@ -47,6 +47,9 @@ int __init device_init(struct dt_device_node *dev, enum device_type type, ASSERT(dev != NULL); + if ( !dt_device_is_available(dev) ) + return -ENODEV; + for ( desc = _sdevice; desc != _edevice; desc++ ) { if ( desc->type != type )