From patchwork Wed Aug 14 11:23:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Nevill X-Patchwork-Id: 19103 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ye0-f199.google.com (mail-ye0-f199.google.com [209.85.213.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1C57B2390D for ; Wed, 14 Aug 2013 11:23:33 +0000 (UTC) Received: by mail-ye0-f199.google.com with SMTP id l12sf6394856yen.10 for ; Wed, 14 Aug 2013 04:23:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:delivered-to:message-id:subject:from:reply-to:to :cc:date:organization:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=SnR9x9bTTkJrjARpAkWQSrmst6orrPgSujfY3kjDidc=; b=WfSVrB2UVmXR4XS0uCxFRWBBEdyg6lne+FyAwIHs3xk6E3irxB//x0wov3MPWz/HFp TpTy+eTorcdeNvq6owE7739ZQts0sg3xTKDkSYTzFp8rqEGdWUMNaa5cwF6I2RekgV2B ERPPppYhemhIc5AqnfEUTYwBLIetStfYju1BXzIQMjBCmPlY4+Oy8TcfiUKgsZFdab9B bJNH9hBDkYnUlrnhvBdEF/Ik0Nw2zxST1HEzzty7DsejAgkUzs9LaHVZPtxmKI28/4Ox 5HjsmE0CJuBH72vK+cWyqtdziZkbX15j7UbDysDOQqgSk9TKBFmpb+vR4TJkUIIwpsNP S7Jw== X-Received: by 10.59.5.72 with SMTP id ck8mr1944814ved.35.1376479412350; Wed, 14 Aug 2013 04:23:32 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.27.195 with SMTP id v3ls3091982qeg.6.gmail; Wed, 14 Aug 2013 04:23:32 -0700 (PDT) X-Received: by 10.52.117.174 with SMTP id kf14mr6771378vdb.26.1376479412246; Wed, 14 Aug 2013 04:23:32 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id rx10si10886201vdc.73.2013.08.14.04.23.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 Aug 2013 04:23:32 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id ha11so3932773vcb.7 for ; Wed, 14 Aug 2013 04:23:32 -0700 (PDT) X-Gm-Message-State: ALoCoQlV6tg83uFni/uaITp4QMjUlY8Chk3AsWWx9RfC2/ntw7CpVl/AW+gUIj0Gb+B9zEvqFeEA X-Received: by 10.58.19.162 with SMTP id g2mr9228572vee.12.1376479412159; Wed, 14 Aug 2013 04:23:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp207244vcz; Wed, 14 Aug 2013 04:23:31 -0700 (PDT) X-Received: by 10.194.201.131 with SMTP id ka3mr4220296wjc.22.1376479411212; Wed, 14 Aug 2013 04:23:31 -0700 (PDT) Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by mx.google.com with ESMTPS id jw4si13803988wjc.123.2013.08.14.04.23.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 Aug 2013 04:23:31 -0700 (PDT) Received-SPF: neutral (google.com: 74.125.82.180 is neither permitted nor denied by best guess record for domain of edward.nevill@linaro.org) client-ip=74.125.82.180; Received: by mail-we0-f180.google.com with SMTP id p61so7598485wes.39 for ; Wed, 14 Aug 2013 04:23:30 -0700 (PDT) X-Received: by 10.180.109.167 with SMTP id ht7mr5762840wib.45.1376479410404; Wed, 14 Aug 2013 04:23:30 -0700 (PDT) Received: from [192.168.1.80] ([213.122.173.130]) by mx.google.com with ESMTPSA id bt8sm2367188wib.8.2013.08.14.04.23.29 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 14 Aug 2013 04:23:29 -0700 (PDT) Message-ID: <1376479407.30964.3.camel@fleetfoot.lan> Subject: Fix SEGV in JTReg test From: Edward Nevill Reply-To: edward.nevill@linaro.org To: aarch64-port-dev@openjdk.java.net Cc: patches@linaro.org Date: Wed, 14 Aug 2013 12:23:27 +0100 Organization: Linaro X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: edward.nevill@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi, Test7103261 in JTReg fails with a SEGV due to a missing implicit null check. The patch below fixes this. OK? Ed. --- cut here --- # HG changeset patch # User Edward Nevill ed@camswl.com # Date 1376479124 -3600 # Node ID 2fee62abab5d36bf37a16b43620f7834879b89f3 # Parent ce185e10867844cdd00b4cd1b2c96c524a0706dc Fix SEGV in JTReg Test7103261 diff -r ce185e108678 -r 2fee62abab5d src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp --- a/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp Tue Aug 13 17:15:41 2013 +0100 +++ b/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp Wed Aug 14 12:18:44 2013 +0100 @@ -713,6 +713,7 @@ ShouldNotReachHere(); } + if (info) add_debug_info_for_null_check_here(info); (_masm->*insn)(zr, as_Address(to_addr, rscratch1)); } --- cut here ---