From patchwork Mon Aug 5 09:51:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Nevill X-Patchwork-Id: 18773 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qe0-f69.google.com (mail-qe0-f69.google.com [209.85.128.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 180E12486D for ; Mon, 5 Aug 2013 09:51:21 +0000 (UTC) Received: by mail-qe0-f69.google.com with SMTP id 1sf4337364qec.8 for ; Mon, 05 Aug 2013 02:51:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-beenthere:x-forwarded-to:x-forwarded-for:delivered-to:message-id :subject:from:reply-to:to:cc:date:organization:x-mailer:mime-version :x-gm-message-state:x-removed-original-auth:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=TwQ8QqOfa2vC85tPW4c8J+CsmVaLRK7JNHeFNbXFIQA=; b=B6kO0nqq2qmWVmISAPOt2Ls7E7yqgERfwbc4mUj30gvQPgL8ZChHsI1p88vLG7DBgN tPh1xxcxbcL52W2vaY1sA7vUdE6a+JbNO2JGKWtpL6zOUnlvJC0nvr5J0Cc+tm0upoJq mZeD1p9Bvzss0t9JsfHNviKsqNyQmPJHqRsg3k/gSaZSuKLtifCgrA5YsTeZZNnwVFx7 EJvr1tXh1TdDPpnguEfUAMjCLpA56IiKguB2aJBa85HcLC13pBJoe5hyWUhbyWWwiQfr 0WoiSQUhFbDadB5CtmZHzc1Rmn6b4VbDef/j21TDW9hr+OIwyqemuAtYXH7TWJ6ewvgq JOdg== X-Received: by 10.236.74.169 with SMTP id x29mr8063792yhd.34.1375696280835; Mon, 05 Aug 2013 02:51:20 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.52.40 with SMTP id q8ls2584636qeo.1.gmail; Mon, 05 Aug 2013 02:51:20 -0700 (PDT) X-Received: by 10.220.199.5 with SMTP id eq5mr4023199vcb.16.1375696280690; Mon, 05 Aug 2013 02:51:20 -0700 (PDT) Received: from mail-vb0-f42.google.com (mail-vb0-f42.google.com [209.85.212.42]) by mx.google.com with ESMTPS id mv7si2736749vcb.36.2013.08.05.02.51.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 05 Aug 2013 02:51:20 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.42 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.42; Received: by mail-vb0-f42.google.com with SMTP id e12so2593127vbg.1 for ; Mon, 05 Aug 2013 02:51:20 -0700 (PDT) X-Received: by 10.52.180.229 with SMTP id dr5mr4704136vdc.20.1375696280561; Mon, 05 Aug 2013 02:51:20 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.11.8 with SMTP id pc8csp79075vcb; Mon, 5 Aug 2013 02:51:20 -0700 (PDT) X-Received: by 10.194.173.225 with SMTP id bn1mr12667735wjc.6.1375696279577; Mon, 05 Aug 2013 02:51:19 -0700 (PDT) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx.google.com with ESMTPS id pu10si10226010wjc.105.2013.08.05.02.51.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 05 Aug 2013 02:51:19 -0700 (PDT) Received-SPF: neutral (google.com: 74.125.82.182 is neither permitted nor denied by best guess record for domain of edward.nevill@linaro.org) client-ip=74.125.82.182; Received: by mail-we0-f182.google.com with SMTP id u55so2304438wes.13 for ; Mon, 05 Aug 2013 02:51:19 -0700 (PDT) X-Received: by 10.180.37.239 with SMTP id b15mr6211810wik.2.1375696279073; Mon, 05 Aug 2013 02:51:19 -0700 (PDT) Received: from [192.168.1.77] ([146.90.53.15]) by mx.google.com with ESMTPSA id r6sm20267392wiw.0.2013.08.05.02.51.12 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 05 Aug 2013 02:51:18 -0700 (PDT) Message-ID: <1375696262.1953.9.camel@fleetfoot.lan> Subject: RFR: Fix false assertion failure (resend) From: Edward Nevill Reply-To: edward.nevill@linaro.org To: aarch64-port-dev@openjdk.java.net Cc: patches@linaro.org Date: Mon, 05 Aug 2013 10:51:02 +0100 Organization: Linaro X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 X-Gm-Message-State: ALoCoQkfsHNH4nWleK0iQXNAfbpUcvjFRr3TQSJGxsULxqjeoxGR3WMHZ0cLBAdLvzl8MYrU/0P2 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: edward.nevill@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.42 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi, The following fixes a false assertion failue which triggers a failure in mauve with fastdebug. OK? Ed. --- CUT HERE --- exporting patch: # HG changeset patch # User Edward Nevill ed@camswl.com # Date 1375458644 -3600 # Node ID 6a6b3b5dc103536b9c04666219452fff6db5ec3e # Parent 064f61f7d3a09ff01fd3f9b9fd193dc204fb7fd7 Fixed false assertion failure diff -r 064f61f7d3a0 -r 6a6b3b5dc103 src/share/vm/runtime/reflection.cpp --- a/src/share/vm/runtime/reflection.cpp Fri Aug 02 10:10:28 2013 +0100 +++ b/src/share/vm/runtime/reflection.cpp Fri Aug 02 16:50:44 2013 +0100 @@ -376,7 +376,8 @@ } klass = klass->array_klass(dim, CHECK_NULL); oop obj = ArrayKlass::cast(klass)->multi_allocate(len, dimensions, THREAD); - assert(obj->is_array(), "just checking"); + // obj may be NULL is one of the dimensions is 0 + assert(obj == NULL || obj->is_array(), "just checking"); return arrayOop(obj); } --- CUT HERE ---