From patchwork Fri May 10 02:17:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 16814 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A98E3238F7 for ; Fri, 10 May 2013 02:19:22 +0000 (UTC) Received: by mail-wg0-f72.google.com with SMTP id e11sf3500152wgh.11 for ; Thu, 09 May 2013 19:18:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=XpjtBTPIzCOWmA7YeGRlgUpzRLRMFJBXpkNZWAf1XP8=; b=RZkqp+wR+UL32qqWIonP+scPEz60IH61JS7xhaBBHU2WnC0zLxUqRpwKOusWTtx/Ik nBzk/R3qI2x7qpgueIMTMRi+v44JPsvcyEuNCtOhn2MUEI+Au9DRM9JIEkf90AIvVpT7 qNT06h2X0ZKI26SmWNNsZWpCzWCLP2wLC924nEhq+/jVjsiO5illbHOjwaSyZwgPA68W hjZ1ryBmDmfNRBEtp9IivMIc19AKvdbPC7oTvREKtdzvCLfT9PnhqheOW+jjh+xjgxGr yDwei1s/bLaFlp4ZA8v8nYE21T+VYyF/6x0MGW0AvqCuAcdA8HE2krWdTufRXB/06uXQ OxGQ== X-Received: by 10.180.21.226 with SMTP id y2mr117558wie.5.1368152337139; Thu, 09 May 2013 19:18:57 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.180.211.201 with SMTP id ne9ls26667wic.51.gmail; Thu, 09 May 2013 19:18:57 -0700 (PDT) X-Received: by 10.194.5.196 with SMTP id u4mr21430829wju.54.1368152337022; Thu, 09 May 2013 19:18:57 -0700 (PDT) Received: from mail-ve0-x22e.google.com (mail-ve0-x22e.google.com [2607:f8b0:400c:c01::22e]) by mx.google.com with ESMTPS id ht7si171770wjb.31.2013.05.09.19.18.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 09 May 2013 19:18:57 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::22e is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::22e; Received: by mail-ve0-f174.google.com with SMTP id pb11so3400961veb.19 for ; Thu, 09 May 2013 19:18:56 -0700 (PDT) X-Received: by 10.220.189.9 with SMTP id dc9mr9708005vcb.8.1368152335967; Thu, 09 May 2013 19:18:55 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.217.15 with SMTP id hk15csp36193vcb; Thu, 9 May 2013 19:18:55 -0700 (PDT) X-Received: by 10.195.13.47 with SMTP id ev15mr21429888wjd.18.1368152334868; Thu, 09 May 2013 19:18:54 -0700 (PDT) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [2a00:1450:400c:c05::235]) by mx.google.com with ESMTPS id cl2si167418wjb.77.2013.05.09.19.18.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 09 May 2013 19:18:54 -0700 (PDT) Received-SPF: neutral (google.com: 2a00:1450:400c:c05::235 is neither permitted nor denied by best guess record for domain of julien.grall@linaro.org) client-ip=2a00:1450:400c:c05::235; Received: by mail-wi0-f181.google.com with SMTP id ey16so156699wid.2 for ; Thu, 09 May 2013 19:18:54 -0700 (PDT) X-Received: by 10.180.90.164 with SMTP id bx4mr720618wib.13.1368152334365; Thu, 09 May 2013 19:18:54 -0700 (PDT) Received: from belegaer.uk.xensource.com. (firewall.ctxuk.citrix.com. [46.33.159.2]) by mx.google.com with ESMTPSA id dj7sm597075wib.6.2013.05.09.19.18.53 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 09 May 2013 19:18:53 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Cc: Stefano.Stabellini@eu.citrix.com, ian.campbell@citrix.com, patches@linaro.org, Julien Grall Subject: [PATCH V3 02/41] xen/arm: Don't allow dom0 to access to vpl011 UART0 memory range Date: Fri, 10 May 2013 03:17:48 +0100 Message-Id: <1368152307-598-3-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1368152307-598-1-git-send-email-julien.grall@linaro.org> References: <1368152307-598-1-git-send-email-julien.grall@linaro.org> X-Gm-Message-State: ALoCoQlkfpJVTJ91MtB+fx+l0K+jV1PVoLFMDjTqLQQYkPpyFGVfmWk/ydGqGujNN3rFay4xdNP/ X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::22e is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , As vpl011 UART is not initialized for dom 0, when the domain tries to access to this range, a segfault will occur in Xen. The right behaviour should be a data abort for the guest. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- xen/arch/arm/vpl011.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c index 9472d0a..13ba623 100644 --- a/xen/arch/arm/vpl011.c +++ b/xen/arch/arm/vpl011.c @@ -85,7 +85,9 @@ static void uart0_print_char(char c) static int uart0_mmio_check(struct vcpu *v, paddr_t addr) { - return addr >= UART0_START && addr < UART0_END; + struct domain *d = v->domain; + + return d->domain_id != 0 && addr >= UART0_START && addr < UART0_END; } static int uart0_mmio_read(struct vcpu *v, mmio_info_t *info)