From patchwork Wed Apr 3 06:23:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15833 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id BEDF323DEA for ; Wed, 3 Apr 2013 06:35:51 +0000 (UTC) Received: from mail-qa0-f70.google.com (mail-qa0-f70.google.com [209.85.216.70]) by fiordland.canonical.com (Postfix) with ESMTP id 5D705A18354 for ; Wed, 3 Apr 2013 06:35:51 +0000 (UTC) Received: by mail-qa0-f70.google.com with SMTP id bs12sf1991245qab.1 for ; Tue, 02 Apr 2013 23:35:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=+E/pvC0usCVZTMOR3oDLGoeKPzORngbeNT7MTlqkB6M=; b=ReNL3fvL5W9rt1tlmdHgZ4FPxyRYMciBIC03LOZwzVDpU3aDC1rgTOyzB3EL3lfXAt ikf7UVkRSfX/ViZG/tmqGViiT4pxp20Le7W6Ozw2c8vTKEe8PpIo2p2JHn3QquAzp3yz 4HLXEioFCy3f67tilifTrM0K+CXEg4E10PKfOBkzpUVri/EcDaAZa2kkic6Kdu4TUqJU wmtFVzKYkObLsNgpG7BAVFMou/EUdk7x34fX81nPyXe6Pub2SSW21JctUbFDEIPymS7P Dw/0rIuycSDlnEK88+ZmtEc7vSQESxBYhMqiQtbHVS9M4kznGOZRnUznuNQgi/UJVhFr 2Qpg== X-Received: by 10.224.157.1 with SMTP id z1mr530330qaw.8.1364970950918; Tue, 02 Apr 2013 23:35:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.24.176 with SMTP id v16ls762573qef.11.gmail; Tue, 02 Apr 2013 23:35:50 -0700 (PDT) X-Received: by 10.58.15.193 with SMTP id z1mr256789vec.40.1364970950642; Tue, 02 Apr 2013 23:35:50 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id l13si3986947vcq.83.2013.04.02.23.35.50 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Apr 2013 23:35:50 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id gf12so1208369vcb.38 for ; Tue, 02 Apr 2013 23:35:50 -0700 (PDT) X-Received: by 10.220.153.143 with SMTP id k15mr276238vcw.33.1364970950361; Tue, 02 Apr 2013 23:35:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.59.4.204 with SMTP id cg12csp157094ved; Tue, 2 Apr 2013 23:35:49 -0700 (PDT) X-Received: by 10.68.195.70 with SMTP id ic6mr715771pbc.60.1364970949439; Tue, 02 Apr 2013 23:35:49 -0700 (PDT) Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by mx.google.com with ESMTPS id sv4si5002097pbc.96.2013.04.02.23.35.49 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Apr 2013 23:35:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.46; Received: by mail-pa0-f46.google.com with SMTP id lb1so721938pab.19 for ; Tue, 02 Apr 2013 23:35:49 -0700 (PDT) X-Received: by 10.68.172.5 with SMTP id ay5mr734337pbc.53.1364970949001; Tue, 02 Apr 2013 23:35:49 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPS id hs8sm4736074pbc.27.2013.04.02.23.35.45 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Apr 2013 23:35:48 -0700 (PDT) From: Sachin Kamat To: linux-iio@vger.kernel.org Cc: jic23@cam.ac.uk, jic23@kernel.org, ch.naveen@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/2] adc: exynos_adc: Convert to devm_ioremap_resource() Date: Wed, 3 Apr 2013 11:53:58 +0530 Message-Id: <1364970239-8242-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQkIxaEi16iJtRXmuIYt9ViF7AL33NPgMlqJ9UTo0x9/pULJC9dSiU+EJq4qQSgBzLpd2tu0 X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. Signed-off-by: Sachin Kamat --- drivers/iio/adc/exynos_adc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c index 9f3a8ef..22d034a 100644 --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -270,16 +270,16 @@ static int exynos_adc_probe(struct platform_device *pdev) info = iio_priv(indio_dev); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - info->regs = devm_request_and_ioremap(&pdev->dev, mem); - if (!info->regs) { - ret = -ENOMEM; + info->regs = devm_ioremap_resource(&pdev->dev, mem); + if (IS_ERR(info->regs)) { + ret = PTR_ERR(info->regs); goto err_iio; } mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); - info->enable_reg = devm_request_and_ioremap(&pdev->dev, mem); - if (!info->enable_reg) { - ret = -ENOMEM; + info->enable_reg = devm_ioremap_resource(&pdev->dev, mem); + if (IS_ERR(info->enable_reg)) { + ret = PTR_ERR(info->enable_reg); goto err_iio; }