From patchwork Fri Dec 30 14:29:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 6007 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 3ADEC23E06 for ; Fri, 30 Dec 2011 14:19:35 +0000 (UTC) Received: from mail-ey0-f180.google.com (mail-ey0-f180.google.com [209.85.215.180]) by fiordland.canonical.com (Postfix) with ESMTP id 1F9FDA1838C for ; Fri, 30 Dec 2011 14:19:35 +0000 (UTC) Received: by eaac11 with SMTP id c11so12652430eaa.11 for ; Fri, 30 Dec 2011 06:19:35 -0800 (PST) Received: by 10.204.133.207 with SMTP id g15mr9086434bkt.17.1325254774814; Fri, 30 Dec 2011 06:19:34 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.205.82.144 with SMTP id ac16cs255667bkc; Fri, 30 Dec 2011 06:19:34 -0800 (PST) Received: by 10.50.219.234 with SMTP id pr10mr45706530igc.27.1325254772121; Fri, 30 Dec 2011 06:19:32 -0800 (PST) Received: from mail-iy0-f178.google.com (mail-iy0-f178.google.com [209.85.210.178]) by mx.google.com with ESMTPS id vr9si27658960igb.66.2011.12.30.06.19.31 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Dec 2011 06:19:32 -0800 (PST) Received-SPF: neutral (google.com: 209.85.210.178 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) client-ip=209.85.210.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.178 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) smtp.mail=shawn.guo@linaro.org Received: by iagf6 with SMTP id f6so29993989iag.37 for ; Fri, 30 Dec 2011 06:19:31 -0800 (PST) Received: by 10.50.202.105 with SMTP id kh9mr44957669igc.3.1325254770936; Fri, 30 Dec 2011 06:19:30 -0800 (PST) Received: from localhost.localdomain ([180.106.37.90]) by mx.google.com with ESMTPS id g34sm128027243ibk.10.2011.12.30.06.19.27 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Dec 2011 06:19:30 -0800 (PST) From: Shawn Guo To: Dirk Behme Cc: patches@linaro.org, Shawn Guo Subject: [PATCH] common/image.c: align usage of fdt_high with initrd_high Date: Fri, 30 Dec 2011 22:29:20 +0800 Message-Id: <1325255360-17891-1-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.4.1 The commit message of a28afca (Add uboot "fdt_high" enviroment variable) states that fdt_high behaves similarly to the existing initrd_high. But fdt_high actually has an outstanding difference from initrd_high. The former specifies the start address, while the later specifies the end address. As fdt_high and initrd_high will likely be used together, it'd be nice to have them behave same. The patch changes the behavior of fdt_high to have it aligned with initrd_high. Signed-off-by: Shawn Guo --- Hi Dirk, I sent this patch to u-boot mailing list, but it did not go through. And I got the following message back. "Your mail to 'U-Boot' with the subject [PATCH] common/image.c: align usage of fdt_high with initrd_high Is being held until the list moderator can review it for approval. The reason it is being held: Post to moderated list" I'm not interested in following it, so I send you in case you want to have it mainlined. Regards, Shawn common/image.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/common/image.c b/common/image.c index 77ca6e4..12ceacf 100644 --- a/common/image.c +++ b/common/image.c @@ -1294,10 +1294,8 @@ int boot_relocate_fdt(struct lmb *lmb, char **of_flat_tree, ulong *of_size) if (desired_addr) { of_start = (void *)(ulong) lmb_alloc_base(lmb, of_len, 0x1000, - ((ulong) - desired_addr) - + of_len); - if (desired_addr && of_start != desired_addr) { + (ulong)desired_addr); + if (of_start == 0) { puts("Failed using fdt_high value for Device Tree"); goto error; }