From patchwork Wed Aug 28 14:16:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 172390 Delivered-To: patch@linaro.org Received: by 2002:ac9:5c4b:0:0:0:0:0 with SMTP id r11csp976602ocp; Wed, 28 Aug 2019 07:16:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqyAjDNqbsRnA4A58Jstj+k/Otf64LiTPItHzY2bYDDyyG2S4CdaaZ3l3ia/fkO2jqTkfUdx X-Received: by 2002:a63:161c:: with SMTP id w28mr1392015pgl.442.1567001786246; Wed, 28 Aug 2019 07:16:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567001786; cv=none; d=google.com; s=arc-20160816; b=ECRvPKZ3Zh6oGBPUTCoz0hhfBvIDAg8VlzSKFJHynMheI7FN9QtDHOYVXyHF/7vuDU hUbR4EKgJt1Mfmq1LC+t9Uk2lDGqh+lmDIyAPfc0kWt8cb+6HxLOxUvyW2j6oyY3LuwV IhLWVbGUIOn3zTtiRHpZ2U/SLC1ZvTajCKM+Ylkg7ECvGRTPGdSzfq9Km6SvcEyc4Nyb cvGEA7huj5TckA8zWbrk//7PTKhH+CWpkwfCVIsls9D+oL+xYzwLqCuX5H6ai+j9bnnk iBzENDoc5q64vzC3ybzfOb1kd3Q3GXQLNg6/jTr2d8IZjEqs5bqBrFc0BUuPNjLbYjGN e11g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=sZtEwsY9jtmfTXLzF3aZpTgyyvXWCRIOF12uKyU3Rls=; b=WdEJ2gQc/ktudJESLkGBH1EC/ZjeI2rYm3ZSesSlVGJv6pJCUeuVuOG9xctOJYhXln 1OcC8/ms+PGj4XYXMYyrrqI05BI0kFfclXyhzcGDlmHcEKeVcmSvL/189t1Uv2Qc2QAF 7T5BTeb0UClIaB5+FDggeI3QJwWoZfop9jKhJoiQIEXrvTAtLdRl3j5xySuJsDV2CfYH RhZ/BlsgcKJ20FhwDCrYH1uO5KCi4wjYgQI5NC1C47as3gz6NodZdiD/l0iofmrygQ5b tJiM1gkA47VJZYkKaPcWb00aC4OPRUwEzqQybO569ktIEdIg/W9QCKDTaYXp8NPLO5DO 3bFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=XDUF7wL7; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id r7si2022981pli.94.2019.08.28.07.16.25; Wed, 28 Aug 2019 07:16:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=XDUF7wL7; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id CC4627F02F; Wed, 28 Aug 2019 14:16:20 +0000 (UTC) X-Original-To: openembedded-devel@lists.openembedded.org Delivered-To: openembedded-devel@lists.openembedded.org Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mail.openembedded.org (Postfix) with ESMTP id EF1AA7ECBE for ; Wed, 28 Aug 2019 14:16:18 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id bj8so56066plb.4 for ; Wed, 28 Aug 2019 07:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OCgeCQBGJDtCZ2sdONfUK3QPgvHwunrmkoILev74YJE=; b=XDUF7wL7yLSgSjvKXGgceSTW3LUZ0U8O1E5wNX2j4Jwu0MjfkqgyRhKTt1ycF3xlxL NA+G/HwDd6lGoP9PRvPwbIV3rvE/NUQymlVf0eQ5qv4Agr8k/pAn4RS54IqY3MyZBRGi 0ms/Pxo8MRkHPmrqaLmw7ZJ1HwpMKI/RyVk3jX8J9DNsv6dFpuQTq70IF025/O861jvE aX4EaFv7Vo3PxlWGfuHQqS/LlOuhNYncarAR2H87kaWddPXvvKA0fepJtTTOYM7EO61U tjF0hF6POFGDvW6VWq9WCAjI2J6nGCugUItwO2hu4+3v5xuCsdVYIm4pDinqUvuLbo87 UcxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OCgeCQBGJDtCZ2sdONfUK3QPgvHwunrmkoILev74YJE=; b=Q916COX3XxN8VEMCgA1ZLfclkn3YQrfGdMu3gBEI9Rs2TYYMAS+IIZEH0yrcDb8lbG 5hqyxnFyzoYhfx2yNMUBekxG5ZcxsvCQDo+UDhEyXs6hDxLY14eO//h3U3dCTaCLqe4V xWCGEHmxJNxKiaGrUWue2WeT18RqfBC6x6BMlFpL9aKoEQuj0HnXN9LbHNuNs61su/H3 v5W5mUvfG0fYYvG1xE50ptTuF+WOxLfdwKZVU+4bB7fu91H1R5TGRMfDJ9jhRTQ62FWK NlxvYrNtg4pYGrF5D0zowOsM83VPosXiiovXhoGWWeMcsBH4enm5SEztLvBc2y3lu9bE SLyw== X-Gm-Message-State: APjAAAU8irhse1eTxcb7Ie43ow+AidAbUr0CpaytUbKVtGEog6AVgsQR fpuLuBCNeq0Pv2tllCFCxPx8cQUrELs= X-Received: by 2002:a17:902:598b:: with SMTP id p11mr3339319pli.96.1567001779286; Wed, 28 Aug 2019 07:16:19 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net (c-73-71-176-3.hsd1.ca.comcast.net. [73.71.176.3]) by smtp.gmail.com with ESMTPSA id d189sm4197428pfd.165.2019.08.28.07.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 07:16:18 -0700 (PDT) From: Khem Raj To: openembedded-devel@lists.openembedded.org Date: Wed, 28 Aug 2019 07:16:10 -0700 Message-Id: <20190828141610.9991-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [oe] [meta-oe][PATCH V2] libgpiod: nherit python3native unconditionally X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-devel-bounces@lists.openembedded.org Errors-To: openembedded-devel-bounces@lists.openembedded.org this recipe inherits python3native class conditionally, this condition depends on a given packageconfig, however inherit ${VAR} syntax requires VAR to be evaluated before inheriting it, therefore if someone appends python3 to packageconfig via a bbappend, then the packageconfig will become effective and add --enable-bindings-python to configure but inherit wont evaluate correctly since the expression adding to packageconfig PACKAGECONFIG_append = " python3" will be coming _after_ the inherit, and the builds will fail e.g. | ../../../libgpiod-1.3/bindings/python/gpiodmodule.c:8:10: fatal error: Python.h: No such file or directory | #include This will still mean that python3native is always inherited but the effective configure option will be --disable-bindings-python and that will do the right thing See. https://github.com/openembedded/meta-openembedded/issues/140 Signed-off-by: Khem Raj --- v2: Inherit python3native unconditionally meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.23.0 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb index 756b143ef7..d559028989 100644 --- a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb +++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb @@ -12,7 +12,8 @@ PACKAGECONFIG[cxx] = "--enable-bindings-cxx,--disable-bindings-cxx" PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev" PACKAGECONFIG[python3] = "--enable-bindings-python,--disable-bindings-python,python3" -inherit ${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', d)} + +inherit python3native PACKAGES =+ "${PN}-python" FILES_${PN}-python = "${PYTHON_SITEPACKAGES_DIR}"