From patchwork Sun Dec 23 21:35:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 154445 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3269943ljp; Sun, 23 Dec 2018 13:36:15 -0800 (PST) X-Google-Smtp-Source: ALg8bN7XFsH+ztVCnPw+7C1WiIdBRlQF2/G+4mEeCeZJmfX9WyVMI2taWRVq+X4ytVtIUBJwyfhW X-Received: by 2002:a17:902:28c1:: with SMTP id f59mr10815591plb.37.1545600975171; Sun, 23 Dec 2018 13:36:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545600975; cv=none; d=google.com; s=arc-20160816; b=hOqsK1MCnOOTKxiJD4OcLLNItDMBh3yF+9oZouwmC9PMTqnKLCn0T4L8/ELI6fRpS8 d/PhqRZZ2nybW6RuE+TeFZQIVg7Si8HJ7uYB/ENuEjiNTQJ0UOf6gOw1Izh/dO2O15/4 kUokj5yzKqorw8kp1e+TozNgY8y54HxTTpE2ss6oLDxkAebIGRFmQyIrTT6hxknQWw4k tmd0R6tITcMJBEifpXDvJpNqiFbQng3tV7sN1j0ERNiY1FwNZO/Z7l3Z1vKsANKg1hy0 FTjgz30i2V7w1OhNoXHFYZtOdHmckZG22RbTeeryXi0X6Ogtqbpui5+pEv4CyQippKPW 7DGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=W6FIVvYqDmVF3034nsvBUS58yERoNgy0Y4Dp9LZoktg=; b=GAyVpVf+MfORY9GIsiJZW1C4SpPvPejrQs4IUb8DlZG09fdWoL9T8iItpm42eNUsZo f/kMG1D10N7KrZntqHHnrVqptPdpMkx0H2m1tQXfaO7XJTsbNnsg8n6yeadj42Cbut4B PVqoTwrDscw3Dw/5CAA7CQmDwysu4HGTXXEHjgsYrvQdr5JD1nxa88GO5P/Ux+SfI7sk j/IJxKHaOznucq1hPK740LqG6mEPbGiLyr2jEroKikDuITNuGe4K6UdXerVb6+AXhHxY 7kht2q87LcfGrjpIpPZdu4kY+Pg/tBIc7E/Qf4HvXl+EXozFyAko3+7IESXk63wZC7qF utqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=H6xODb+7; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id m187si27761740pfm.51.2018.12.23.13.36.14; Sun, 23 Dec 2018 13:36:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=H6xODb+7; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from 165.28.230.35.bc.googleusercontent.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id B1B686D6EA; Sun, 23 Dec 2018 21:36:10 +0000 (UTC) X-Original-To: openembedded-devel@lists.openembedded.org Delivered-To: openembedded-devel@lists.openembedded.org Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by mail.openembedded.org (Postfix) with ESMTP id F36456C50D for ; Sun, 23 Dec 2018 21:36:08 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id c73so5025467pfe.13 for ; Sun, 23 Dec 2018 13:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lDTYVCPCsaL1X1JQfgRrUZPKMdM7AnaOTQowofatnEc=; b=H6xODb+7rc4ZLDPTYl/lFXPZC4sqwNJOqbE8yoyTQmE13wfwaQpRxtuICxNrZyJt6U 11ndn1dbm7V8EpQbN4SiBaFdlkwvJQj2pejridxvmgmVdaxEiyA19TyhQo1T4FD9hO80 t+12f5TCqx6B3HhfDX2QOngujkLsSgHBfmpbhZljckWuHGisvcduOXrHStr5YhlYMQd1 0s1AnwQ1o/dJdUWRfZAbW/4Rm3yC2kAhRIi/aCfKLaMFMK//6hNAryZmm2STBSBDkdpj 6F7uYNGmBlTbj18rFbv4sbl/Qr9teimD6ej9yrhH4NW9H/HzOgTM4l76dpx2GHz33Ymf 9qTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lDTYVCPCsaL1X1JQfgRrUZPKMdM7AnaOTQowofatnEc=; b=l9BiL29YPgMZe0khwm25jgnmk+FmCPUhlAOY4+MWn8MILk7X+avQ8WR9tvYh/oTwzj XoINN6ZC4slQ6mf54J6j7XLGDRj0rmxmAjp/E6OsW55km8hKGIcbuLqxMcJCatWPSvES vQgm+CAh+AbEOrtSIr8azjejVQASUzzgaMmQ/JygzJd2t5Uj5UOWTKGlpvLu+hFN4QHA LuV0ue2Ilmm2EgY0qJjD2Lq79SX94QujDXa0oavZbCM9yw45VEQ/TCpX46sD8pjq3DVa Etjg/EyyKZhTWNow72Va7Z1CGUkmuPIjRQOWDccCYxNac/CuyK+CWrBmbdDTX9Mu5iSA tfjw== X-Gm-Message-State: AJcUukdwaRnP0BM4/s29BSjS4/LQUN4DB6kJcSp+M5hRd48kP9MVfQL0 97BXX5h4orNK2uE1W0l7glx4dUO0rLY= X-Received: by 2002:a63:8043:: with SMTP id j64mr10494880pgd.405.1545600969492; Sun, 23 Dec 2018 13:36:09 -0800 (PST) Received: from apollo.hsd1.ca.comcast.net ([2601:646:877f:9499::19ec]) by smtp.gmail.com with ESMTPSA id m9sm33340800pgd.32.2018.12.23.13.36.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Dec 2018 13:36:08 -0800 (PST) From: Khem Raj To: openembedded-devel@lists.openembedded.org Date: Sun, 23 Dec 2018 13:35:40 -0800 Message-Id: <20181223213557.7834-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [oe] [meta-oe][PATCH 01/18] modemmanager: Fix build with gcc9 X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-devel-bounces@lists.openembedded.org Errors-To: openembedded-devel-bounces@lists.openembedded.org Signed-off-by: Khem Raj --- ...-string-to-s-printf-formatted-string.patch | 31 +++++++++++++++++++ .../modemmanager/modemmanager_1.8.2.bb | 1 + 2 files changed, 32 insertions(+) create mode 100644 meta-oe/recipes-connectivity/modemmanager/modemmanager/0001-Do-not-pass-null-string-to-s-printf-formatted-string.patch -- 2.20.1 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel diff --git a/meta-oe/recipes-connectivity/modemmanager/modemmanager/0001-Do-not-pass-null-string-to-s-printf-formatted-string.patch b/meta-oe/recipes-connectivity/modemmanager/modemmanager/0001-Do-not-pass-null-string-to-s-printf-formatted-string.patch new file mode 100644 index 0000000000..5fbafbb5dc --- /dev/null +++ b/meta-oe/recipes-connectivity/modemmanager/modemmanager/0001-Do-not-pass-null-string-to-s-printf-formatted-string.patch @@ -0,0 +1,31 @@ +From b8862e6af1c6d022b8c182098e7deddb874ece19 Mon Sep 17 00:00:00 2001 +From: Khem Raj +Date: Tue, 18 Dec 2018 23:10:44 -0800 +Subject: [PATCH] Do not pass null string to %s printf formatted string + +Here the string is already decided to be NULL and passing +a null pointer to %s will not work + +Fixes +error: '%s' directive argument is null + +Upstream-Status: Submitted [https://gitlab.freedesktop.org/mobile-broadband/ModemManager/merge_requests/67] + +Signed-off-by: Khem Raj +--- + plugins/mtk/mm-broadband-modem-mtk.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/plugins/mtk/mm-broadband-modem-mtk.c b/plugins/mtk/mm-broadband-modem-mtk.c +index 475a63ac..541de4a5 100644 +--- a/plugins/mtk/mm-broadband-modem-mtk.c ++++ b/plugins/mtk/mm-broadband-modem-mtk.c +@@ -191,7 +191,7 @@ get_supported_modes_ready (MMBaseModem *self, + + response = mm_base_modem_at_command_finish (MM_BASE_MODEM (self), res, &error); + if (!response) { +- mm_dbg ("Fail to get response %s", response); ++ mm_dbg ("Fail to get response"); + g_task_return_error (task, error); + g_object_unref (task); + return; diff --git a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb index e198bd588e..f8e074a87f 100644 --- a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb +++ b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb @@ -13,6 +13,7 @@ DEPENDS = "glib-2.0 libgudev dbus-glib intltool-native" SRC_URI = "http://www.freedesktop.org/software/ModemManager/ModemManager-${PV}.tar.xz \ file://0001-Do-not-set-Wno-unused-but-set-variable.patch \ + file://0001-Do-not-pass-null-string-to-s-printf-formatted-string.patch \ " SRC_URI[md5sum] = "a49c9f73e46c7b89e5efedda250d22c0"