From patchwork Wed May 9 19:00:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 135368 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp108896lji; Wed, 9 May 2018 12:02:45 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoRQx64rtDOWr89aVPRUpUCawDkImfjNQhx9UL+I/1O0wXLSILg+Tw47NNPIsL4x4bCF0NI X-Received: by 2002:a17:902:7149:: with SMTP id u9-v6mr46119002plm.356.1525892565638; Wed, 09 May 2018 12:02:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525892565; cv=none; d=google.com; s=arc-20160816; b=uRWcaPzd8R7XEk+ffh8re3eRXzqx2ItrYXIOtfLwrcqZ6cNda6UTZEi3djgGaeqsf2 ZQUviqPs0yqBLeKJ3pnZ0Xqr40LjjOA53hno59OhQeVOgRgyOgsn6fSbO8KUfZbZ3q3f yR2FOz9hKXjwblZTHDgHIRO2ajI7+c6I8fbAWVMEnwANQzK4LyEseC7XVD8PJgLf4Kgo dYk1Zb/0tjyswu5ZCqSuGbLoCJ1XKB/DaTX+lOGShRXRLI6W1B9HkDdsH0phf8Khrgds 1bU3fRZxibvcpu/vHYD1LGisVZOYh+jSKfILYIF3oDqYg7warqyRu9FoYRp0uG61G6e7 aOPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=L4OlWOm7n/QYnD9AlqwCf8XWYW3njsenSQzKjNqR2GQ=; b=AOoWi3uaQubHcXsnYcQ+25OBE9sIrRqrLBfFWC8ttYrM86MoYRKaRWXlcv5pFgSqwn 7e7XDo34I/pLKzFPw1AHYkYbutcfAdb2Xg7NyPk7OHRushSSwDqtIWzOT2Pk55wHBli+ IKlEhx5V+gDKRAx88PRmCnT24+Sr/t6PjxLH8iRajsjaTJYJPcryJiC4JgkcZjrurnvF N3jNfL3ljZIcuxQKNrTzH7sST6ErsDswnJI6tFLK1NT1EPQuTUSlZ8/SAOEQZWpKDovC 152oj/GzXVCYtjwA0N5m2FesklSjZ31wJF55tJ9SCeB3O7c9bDu8D324ddFdVtdEW3Ny 21iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ZZ3cFk4E; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id u47-v6si22456733pgn.488.2018.05.09.12.02.45; Wed, 09 May 2018 12:02:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ZZ3cFk4E; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from layers.openembedded.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 67FA37501A; Wed, 9 May 2018 19:00:59 +0000 (UTC) X-Original-To: openembedded-devel@lists.openembedded.org Delivered-To: openembedded-devel@lists.openembedded.org Received: from mail-pl0-f68.google.com (mail-pl0-f68.google.com [209.85.160.68]) by mail.openembedded.org (Postfix) with ESMTP id 6A60574FB8 for ; Wed, 9 May 2018 19:00:35 +0000 (UTC) Received: by mail-pl0-f68.google.com with SMTP id f7-v6so4844220plr.4 for ; Wed, 09 May 2018 12:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wS3qkfCy1NP5HxlVnDrBgL72zcQJ5GkP8YHUjP0C5zw=; b=ZZ3cFk4EBDD2ttpKPFamgf5GFmKrxFT8nuyqmxbETXqXD0BXTfQG4Xrhb2mINbHKvi Id96902o68qtlW/JUbuDhddiMeeTuu08znsoZ/jzFlAcx/5gayXTyapfrxSv5TKTaHVQ /U61L2R/wnU9VbSRaANeUd4vzEL52dwyrms4kfngkEvxbA5W8Vv8c2j4JJgUdzVOOUPc 2q3uDhMIqd/nazgTpmc/gAVlo3hopZIUtNvjyZDtfQkBglwFuBVN681UONlncyI9iypv d/6KFv+uJRZyciBuAx0IeEYfVg/5uK7XeHYlnN0n4x9CQb++wAsgrcnyFSCoGV9Aqktb chuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wS3qkfCy1NP5HxlVnDrBgL72zcQJ5GkP8YHUjP0C5zw=; b=hDpoePcLJ/nqpJb/KCmeXYmW3fdf0qLZkJ1k+6bkSmOPuBEfgnQuR2YlNSR0kfAqiV Y5WXuPYdjF3590Oo8TKkYMlPUIS9C035Cv5CEntwVUW2WxZX0mVozpwbAW8Kpsi6y0GJ B4E9ljwYtBAu8JhYoobko6JwA5YMpbq5kN3iB3auUV4C20U4XYkGoWfCxhLnW7DYojK7 1BPuxoU9T6YMHp2nyMtJCjxMd83whPqScmwQJdOUnqT23nTXEogzYYGDXN9PlT0ZFB7v dHJK6zAnvszGPc5TtrP9W9uZxIGOph7nRkwitsvrgB0ULBEWMkBk/NE1hRiA7f3tNo+n tNrQ== X-Gm-Message-State: ALQs6tA1/Kjnin/Dv3/r/qahr3ePTJjbIwb/DU5Pr2P13rl4ziZm1L9r ISBmJvE2aFgq5qOr8u2l56X7qw== X-Received: by 2002:a17:902:da4:: with SMTP id 33-v6mr46351063plv.52.1525892436386; Wed, 09 May 2018 12:00:36 -0700 (PDT) Received: from localhost.localdomain ([2601:646:877f:9499::c68]) by smtp.gmail.com with ESMTPSA id 131sm27732437pfa.128.2018.05.09.12.00.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 12:00:35 -0700 (PDT) From: Khem Raj To: openembedded-devel@lists.openembedded.org Date: Wed, 9 May 2018 12:00:11 -0700 Message-Id: <20180509190011.30006-16-raj.khem@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509190011.30006-1-raj.khem@gmail.com> References: <20180509190011.30006-1-raj.khem@gmail.com> Subject: [oe] [meta-oe][PATCH 16/16] upm: Fix build with gcc8 X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-devel-bounces@lists.openembedded.org Errors-To: openembedded-devel-bounces@lists.openembedded.org Signed-off-by: Khem Raj --- .../0001-Replace-strncpy-with-memcpy.patch | 49 +++++++++++++++++++ meta-oe/recipes-extended/upm/upm_git.bb | 3 +- 2 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 meta-oe/recipes-extended/upm/upm/0001-Replace-strncpy-with-memcpy.patch -- 2.17.0 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel diff --git a/meta-oe/recipes-extended/upm/upm/0001-Replace-strncpy-with-memcpy.patch b/meta-oe/recipes-extended/upm/upm/0001-Replace-strncpy-with-memcpy.patch new file mode 100644 index 0000000000..4b17087ef8 --- /dev/null +++ b/meta-oe/recipes-extended/upm/upm/0001-Replace-strncpy-with-memcpy.patch @@ -0,0 +1,49 @@ +From d314f26e024aaf15bf4ab22ceb98501148d0eac8 Mon Sep 17 00:00:00 2001 +From: Khem Raj +Date: Mon, 7 May 2018 19:53:33 -0700 +Subject: [PATCH] Replace strncpy with memcpy + +gcc8 detects that strncpy is overwiritng the null terminating character +the source strings are already initialized to 0 so memcpy would do the same +job + +Fixes +rn2903.c:153:5: error: 'strncpy' output may be truncated copying 16 bytes from a string of length 511 [-Werror=stringop-truncation] + strncpy(dev->hardware_eui, dev->resp_data, RN2903_MAX_HEX_EUI64); + ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +Signed-off-by: Khem Raj +--- + src/ecezo/ecezo.c | 2 +- + src/rn2903/rn2903.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/src/ecezo/ecezo.c b/src/ecezo/ecezo.c +index 6a195fc1..56c6dab3 100644 +--- a/src/ecezo/ecezo.c ++++ b/src/ecezo/ecezo.c +@@ -488,7 +488,7 @@ int ecezo_send_command(const ecezo_context dev, char *cmd, char *buffer, + // our write buffer + char writeBuffer[ECEZO_MAX_BUFFER_LEN]; + +- strncpy(writeBuffer, cmd, ECEZO_MAX_BUFFER_LEN); ++ memcpy(writeBuffer, cmd, ECEZO_MAX_BUFFER_LEN-1); + writeBuffer[ECEZO_MAX_BUFFER_LEN - 1] = 0; + + int writelen = strlen(writeBuffer); +diff --git a/src/rn2903/rn2903.c b/src/rn2903/rn2903.c +index f30a33ae..01a011da 100644 +--- a/src/rn2903/rn2903.c ++++ b/src/rn2903/rn2903.c +@@ -150,7 +150,7 @@ static rn2903_context _rn2903_postinit(rn2903_context dev, + rn2903_close(dev); + return NULL; + } +- strncpy(dev->hardware_eui, dev->resp_data, RN2903_MAX_HEX_EUI64); ++ memcpy(dev->hardware_eui, dev->resp_data, RN2903_MAX_HEX_EUI64); + + return dev; + } +-- +2.17.0 + diff --git a/meta-oe/recipes-extended/upm/upm_git.bb b/meta-oe/recipes-extended/upm/upm_git.bb index d742a5e461..478aa0db1d 100644 --- a/meta-oe/recipes-extended/upm/upm_git.bb +++ b/meta-oe/recipes-extended/upm/upm_git.bb @@ -7,11 +7,12 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=66493d54e65bfc12c7983ff2e884f37f" DEPENDS = "libjpeg-turbo mraa" -SRCREV = "cc7fec9ae0228add9011bf1c2cd5e0ca2ba0d4f0" +SRCREV = "37642f3b0194f6ddd63f1e6b5d49b8cb689d5c81" PV = "1.6.0-git${SRCPV}" SRC_URI = " \ git://github.com/intel-iot-devkit/${BPN}.git;protocol=http \ + file://0001-Replace-strncpy-with-memcpy.patch \ " S = "${WORKDIR}/git"