From patchwork Mon Dec 3 20:35:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 152736 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp7265146ljp; Mon, 3 Dec 2018 12:35:38 -0800 (PST) X-Google-Smtp-Source: AFSGD/UrLjwWN1LIQ9NG0Kf6NHgp2ts2STPbrkY/kiW73GFBaZ90RlS0IYmFmgLg+Q7Ptigazsdz X-Received: by 2002:a63:c00b:: with SMTP id h11mr14754706pgg.429.1543869338813; Mon, 03 Dec 2018 12:35:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543869338; cv=none; d=google.com; s=arc-20160816; b=w640F14TB1RZdrOqcmduJkGcb3fwyzaaKUq8vk6ZGyW8CMiR5+5bFqsNjFPC4DqlsD V05UBNRBEuECOxiS9d89O+co3CGZ5aASPrPbILj+MwoRtXNRznvKbz4TY/LV8fO19n46 UWv7Fk1coVhtxPKYUdPQsaOBBl9CXjaFn/7ccv+3P3idGpxoRfJhB3mbbz5mJYfck+y3 Or6UYv0dQr7OS7YbMxT4+ppR/j868WK3RcH0KQoLZrxfVS6u/C5fYC+MsMqitROsz/iP NrobJMbmlvPcdlScWnT4B58j1HhsCzc8pd/D+ZFBw4EKn0VkLkAYQbgkg0BoxDBGsyPh gw0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=BlkVzpL55N2ZksvgpCV+JLWpp24/p6SMhLT38yq3+hs=; b=gck+ED0bCrpeZlyrPiZxWyJP8Zo6EHNd+U5Et3bR3pbEK3sbQeMe9+7pryFZ6qiPKz PWGmQ7P7t+a3A0gPsuqDy9zCVJdS3z2DHOHDnkqXuB/Wa52w0emnn+9ND8jX8w/yrzwp 0K3yjXBAKGox3FAFq15x/cIzzFvEV8hhil7YKIJLinwl/d2MLyxskL7TfdsisvfBPd1N lyqJEZlNOV8cF/zkyUbKuy2GCspibgLiCo9onHIhwQk+x4ug/TX8li+SYDzqYOHi9NNf tf8J0509stXHrzqKzVZZyIq+yaeHMTtVHAEPplXSfxlSLRuQ5hp2o4xiRl3dpBFQjX6+ ZfAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=gweT0fFt; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id d23si13008683pgj.558.2018.12.03.12.35.38; Mon, 03 Dec 2018 12:35:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=gweT0fFt; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from 165.28.230.35.bc.googleusercontent.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 399906C5DA; Mon, 3 Dec 2018 20:35:32 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mail.openembedded.org (Postfix) with ESMTP id 9EFE36C57C for ; Mon, 3 Dec 2018 20:35:21 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id n190so4858961wmd.0 for ; Mon, 03 Dec 2018 12:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=Ao+lfe25arfG1xPlnPveryvUUIsHbWgQ1ajr9Q8Egys=; b=gweT0fFt05mpdqm6GkAcQnJ7m+GanarltKduZhT737KxTQCOtDtpDRgIbZO3m2+c3M t8Ree6Ppoh31wJW0LHspTA9rWymOCn4gBm7L61bK/vOJLaUdvMgT4LrGZZOhdL204+ll LSfmCMMZSNfpP4MDVtI8dJNi5lBoLgqLJP3owszU9SqPPCgpyARfyFf1ctvRlGWmw46h VjpXIIRaX03Db++1mZEcjV3D11y3t0oG0l+pTy6G8GxDG2fXKuWR5f6iAQ/NC1K9NJFw ENyr4GTJCkEHabqZGosKflYAmLWSSAgCli9wVCd9RXj0XnOvjIPUVG3fSWdCJIY9SYpB fh3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Ao+lfe25arfG1xPlnPveryvUUIsHbWgQ1ajr9Q8Egys=; b=qcgJMsfzSxNP+SyoeV4JDim5qZTj/1lkBDnlhcoi2UmqVOxXYMHW6oH4dmgV2+9eYl FhQ1kfO28jjC7bYe5E3/zm73pu5SroZ369nlIpI5jR83GJeoaPHcyz2TnL5dRtJkIYCe uDLX2O9Uos0HvKd9XoYFf+DWvYfPwrX3mvRxdRS7x9a749xbWG0a/Cm1KU2uN3Q/zLJG hS5JTjuFwGTmhpzMxkck8sb7OXqMGv6GE7YNBQxbx19P5y9bodKEPfuL9UE4O/F7LuSM Pk5zAG9tlAPDSRtKe97qzcdP8EiL/nmhL9JtNggkDXx4jtPfpQ1vvkTDSSEQsZR0jCXH UPRQ== X-Gm-Message-State: AA+aEWZUDYpQxHJZF46tw+kFFvz1rAHbMFwEYlQYaZFcRetm8tmGMsoC M6aVcWzRxM2WnSSDaTFU494t1ttyQf8= X-Received: by 2002:a1c:2104:: with SMTP id h4-v6mr9200416wmh.130.1543869322272; Mon, 03 Dec 2018 12:35:22 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id q2sm15361570wru.56.2018.12.03.12.35.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 12:35:21 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 3 Dec 2018 20:35:16 +0000 Message-Id: <20181203203516.26461-3-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181203203516.26461-1-ross.burton@intel.com> References: <20181203203516.26461-1-ross.burton@intel.com> Subject: [OE-core] [PATCH 3/3] insane: clarify GNU_HASH warning X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org We have a fatal error if ELF objects don't have GNU_HASH segments don't don't explain what the problem is. At least give a hint to users by suggesting that LDFLAGS wasn't passed to the compiler. Signed-off-by: Ross Burton --- meta/classes/insane.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 4644221bc6b..6718feb3af5 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -383,7 +383,7 @@ def package_qa_hash_style(path, name, d, elf, messages): sane = True if has_syms and not sane: - package_qa_add_message(messages, "ldflags", "No GNU_HASH in the elf binary: '%s'" % path) + package_qa_add_message(messages, "ldflags", "No GNU_HASH in the ELF binary %s, didn't pass LDFLAGS?" % path) QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"