From patchwork Mon Dec 3 16:34:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 152707 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp7013435ljp; Mon, 3 Dec 2018 08:34:21 -0800 (PST) X-Google-Smtp-Source: AFSGD/VRWHsYeiqcfq/xiWQsFL0s/i3LgGRkZDol7asloFSDcZDM97YHPYtYjaUcIFK/hUv0ZHWb X-Received: by 2002:a63:1f1c:: with SMTP id f28mr13844467pgf.193.1543854861596; Mon, 03 Dec 2018 08:34:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543854861; cv=none; d=google.com; s=arc-20160816; b=IwcnzlBbIf0yeSTUdo0Yy4CGRU4n9HlE0KxBDwdfgT+k2eLKLHqTAr4EQ3cvnMKowb G6XyfNLSb2P9CybRIqYk6JZhbSFo1ibGMYb6ewYEm5EkRWQLq2CYKuivfcLD+/Rdku/p 1tXw+PeypuhdXDamJRiqviOTt212dSJkOdcRMWE2H1lMAMDgGt4C9LcQD/0LsXumq69E IgHRFap1QwOgSKv+bWYz8NB6hyzHZTcdC44YXF2lvaP90fVwiB0z8bY4/c3bcTrD0rbH tns7pyLp/kkOvEP+Sjo+egjQWxWMnuh/MnCV7oxUrvYx1G4FEURjhlyNM66noRs0FbrE a2BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=BlkVzpL55N2ZksvgpCV+JLWpp24/p6SMhLT38yq3+hs=; b=R3O3hESH7rACbfvr8CJzZA/48VdTwkCtW//nC4Fo+W6aFFNECwFz5ITWz9OqkzCuvq +mIeSmkDMHeVoxQ/lkBeqBGC4RNqGq4ghD1HC0S8Zz/skEgZGU6H7xOOg3F70cm/OTVT wxi+MiKFnUbyvd2CHJaU7Gbozhg8Nf+fF7YumO5gLZu9S//ETRTHPogUQHp96ZWRXxp6 C8o0xLOMrVddKFFAoIpi9Gh1KLDDsSxFb5tSfowauiOr2fsAv8vnFcJc2TTkYSijCpK1 LH4jLeelqWPbIhA7AST8r9Fs0P1e59l6GVRo4Ftl4ILaRYmBoWPBRfrcaTgRc1k5n71p DuCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=TkHEPpgu; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id h19si13175764pgb.231.2018.12.03.08.34.20; Mon, 03 Dec 2018 08:34:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=TkHEPpgu; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from 165.28.230.35.bc.googleusercontent.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id EDC9E6C657; Mon, 3 Dec 2018 16:34:16 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mail.openembedded.org (Postfix) with ESMTP id 5670C6C57A for ; Mon, 3 Dec 2018 16:34:15 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id y139so6517953wmc.5 for ; Mon, 03 Dec 2018 08:34:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=Ao+lfe25arfG1xPlnPveryvUUIsHbWgQ1ajr9Q8Egys=; b=TkHEPpguyLwVWsqJPji9rwtzfROvExBRC2oVJ3IJoKUSR8TI3m5Z2jsT4yNA/n6iIw +soC0mgDYcvGLvm5AxSE9gFCHpOpKbwY0WjQ/HLWrnfXJIUVhKyR2/ArMFkNHFDwfB2b zs1boIFEQXp53k9ujZFdd/0JUAPOtT0U6xA48o8j18T+MSnud7FDf5oAo2cyiK86HnN6 9fYpia2QpD+mM6Izmld//J1LM/o+xpAoWQJraJIr7t4ZT+KSfHwlBD4E2BIVAqEXD9ar pufrjprz8opoCPwM/bWmEXt52LtDz9KfZDfqGIRZgj8EH831+ww4mFTjiRh4O/ePGwFb b6og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Ao+lfe25arfG1xPlnPveryvUUIsHbWgQ1ajr9Q8Egys=; b=KBJwtuDUtHNklgBEnE/+fMRBJbYyRYfnNlI2EbGjARguD5/yvbiOSUZpKoNtSu7Lo4 U0CtkWMzJvbkEXjowL+1Oq7ie54kGMdZDvIFGdQZu6IKWe0DU6PF5aJOdxJBB3eJ99UC IxSCt3nxxEfkxCQOoJFVIejy7/bRyJn2TL0aSEWPPYxJNnNGiU4MicUJ9CAU/gGLnVJ3 lSd3AEVAxsSce+hc1ySlDk/YRtrOfDYPSKmMnKx9cAanPT0AHrytyJiJ2MS0hwzVhzuk Lxfxhb4PeurjDSys+D4WxWvaDT+b0GLR+q5Tt1hKCISR/73P4ns7gjpApq8g2c6ULPH4 0Ubw== X-Gm-Message-State: AA+aEWZh8THXlkZj0a3bs48g89pKO7kiKJNijO5MR1vHQJ6J5S4Q7Nbw WFFe7fSBeTCPnYtFQgpjsmI6r2Bmki0= X-Received: by 2002:a1c:df46:: with SMTP id w67mr9291271wmg.51.1543854855739; Mon, 03 Dec 2018 08:34:15 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id j20sm6288372wme.20.2018.12.03.08.34.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 08:34:14 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 3 Dec 2018 16:34:12 +0000 Message-Id: <20181203163412.25214-1-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [OE-core] [PATCH] insane: clarify GNU_HASH warning X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org We have a fatal error if ELF objects don't have GNU_HASH segments don't don't explain what the problem is. At least give a hint to users by suggesting that LDFLAGS wasn't passed to the compiler. Signed-off-by: Ross Burton --- meta/classes/insane.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 4644221bc6b..6718feb3af5 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -383,7 +383,7 @@ def package_qa_hash_style(path, name, d, elf, messages): sane = True if has_syms and not sane: - package_qa_add_message(messages, "ldflags", "No GNU_HASH in the elf binary: '%s'" % path) + package_qa_add_message(messages, "ldflags", "No GNU_HASH in the ELF binary %s, didn't pass LDFLAGS?" % path) QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"