From patchwork Fri Jun 2 16:01:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 101281 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp470297qge; Fri, 2 Jun 2017 09:02:09 -0700 (PDT) X-Received: by 10.98.7.149 with SMTP id 21mr7477185pfh.54.1496419329188; Fri, 02 Jun 2017 09:02:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496419329; cv=none; d=google.com; s=arc-20160816; b=ZBuPS0K5pr8zP/8tkkEn3R5kCK4MwueT9lgzmTM8LgIjcq8lupF9NPO+k6ptIWhrqi afVBisrW/MnKMkDW95rOyE7/AmkBXIrUJjPUPS/G0vdcqMA/HVnJQB7a3IvJSca38wFn +/Ca1aIZcoXoqWk544Lu58f/kThO+VbahRPY+eqyFiR/0c1DKiuPiwUKxbhcQjR6iWJY nbTUDpB3OM7IIf4wo517LSuCTxB+oiuH82v2wd/gOB6wRRvnXiULO958/vxEK85QmdFu eHBHYQR4ubjrJeU+KV5ZIWUZkFMoGSADxx2isqLP79wZrDp0B2hhxFoguNiCtyEUVN1N 2xSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=HLXzFdidvePUnpHAZXZxF21AbmGil44T4yxyH45RmSo=; b=DlLv3ymFp04MTzd/+ZCxFSDXdMJhBCYug/tqikQ1sz2w7zfI6sZk/ZJ3ByMHmLbqaW uH/XoePgFOIGbP1QsI62jicA0P5llSM8oymhLRfTQbb5Zch57oEyeBRAb/gIEcVC2d3q CutBKF76+J5CQAfqfJgpE61huxn7fKUPCzYOfcb5aaZmYiPNaZBb9MGXIpARftTbmpmX p+ms5QRdYDcjgnth/Hb+ykixTvosGf5/6CNlbHpSe3kX8n3aHSxLtwY2/1Nys6gMmgmi n1LX8+806oIj8ZSf8AiODEA4D7668ZMvpux85Uc6Mzx+PrPq6yNcdwvPXMeLx1uifEjG EtUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id r67si23841796pfe.5.2017.06.02.09.02.08; Fri, 02 Jun 2017 09:02:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 480F077ECB; Fri, 2 Jun 2017 16:02:03 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by mail.openembedded.org (Postfix) with ESMTP id 2F9B76076F for ; Fri, 2 Jun 2017 16:01:58 +0000 (UTC) Received: by mail-pf0-f169.google.com with SMTP id 9so51635486pfj.1 for ; Fri, 02 Jun 2017 09:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ItGxa99H5FEieNUmW1ZTSB6EQpQo3W/Y3iYLLEgNBNw=; b=gfTadt68ksesKUpkpFICpo2A4ZteVjBWSM4Yaq4dswz5oVhD+/iaKRSBd4Z0LRUp7Z ieRswGH2JGDP/taJNnUVrSzO0O6nJ12q73jerkHvcp3T1U51MSFPBS8QdvGjz/U+FvuN CvwHihdySlnfV4Ka5iqZnMEkbG15A0f/RbZx+rL+Uxv2nS81FYdbSgPHsO9GAW4XGyj6 iidPvWBT9ZeNhmmgSKXvX2UW800gVximMcbrQEG/s1n4EnelVBP5hXzFx61jE4pfRLXo llJv1VtuD8+agIpG6qPwEkfKmzLiM3XJColWZ1qnxs0KdgARjXMaUuHGrYwtBAu0EOCB io/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ItGxa99H5FEieNUmW1ZTSB6EQpQo3W/Y3iYLLEgNBNw=; b=A1xgDwKmlfSuPAxWkFijKvvXnQtDvBytdpLJubePWKvq73fRSI/OaLnZL6yBqTVrke 1LjtljZubB0vQD0xpqgjEfCq0efoBBDF/H/yk+QQ1iyxAaGu7naFbTP+6HpJEq/N8zz+ cPu2KNO/JOAVds0Sl3wKgHqN9E3slBbkd7Hjad3Ff0lxocPTvB0WaHXmY9B7jFCTMxXj WYGzQU6YcpTi2QsVbs2Vq7FssALf7e8H9wLbh0ccudvwobm6q0l0yUksE6FbuZE17pKX EQhpMhTrOs6n4AanRW3YPoWcwXWPrJo8rpnDFUTTRb1Hb8JJCidQeLlUmdpLFp0mdIlt vNNA== X-Gm-Message-State: AODbwcApnenbZ1q9CFdjvDd7MrN4XOqT94T8Rvf8YNwIdQGRemXpSQqr TBSfVoN+MdS/CzF2 X-Received: by 10.99.126.92 with SMTP id o28mr8053562pgn.63.1496419318952; Fri, 02 Jun 2017 09:01:58 -0700 (PDT) Received: from localhost.localdomain ([2601:646:8882:b8c::cf4]) by smtp.gmail.com with ESMTPSA id a69sm7511420pfg.7.2017.06.02.09.01.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Jun 2017 09:01:57 -0700 (PDT) From: Khem Raj To: openembedded-core@lists.openembedded.org Date: Fri, 2 Jun 2017 09:01:50 -0700 Message-Id: <20170602160150.6813-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.13.0 Subject: [OE-core] [PATCH V3] distutils-base.bbclass: Do not use -pie with hardening X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org Fix build when PIE is turned on. It tries to build .so file using -pie and -shared flags together because its doing compile and link in same step CFLAGS and LDFLAGS are combined and does not work, ending in errors e.g. | /mnt/a/oe/build/tmp/work/cortexa7t2hf-neon-vfpv4-bec-linux-musleabi/python-pygpgme/0.3-r0/recipe-sysroot/usr/l ib/Scrt1.o: In function `_start_c': | /usr/src/debug/musl/1.1.16+gitAUTOINC+179766aa2e-r0/git/crt/crt1.c:17: undefined reference to `main' | collect2: error: ld returned 1 exit status This error while cryptic is due to the fact that we are building a shared library but also pass -pie flag to the link step after specify LDHSARED ( which is -shared linker flags ) we can not use -pie when doing shared libs. This is true for all the python modules inheriting setup tools Disable the pie flags thusly for all modules using setuptools since this setting is done in setuptools makefiles which are then used during module compiles Signed-off-by: Khem Raj --- v1 -> v2 - Move change to distutils-base V2 -> v3 - Fix a missing end quote meta/classes/distutils-base.bbclass | 2 ++ 1 file changed, 2 insertions(+) -- 2.13.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/distutils-base.bbclass b/meta/classes/distutils-base.bbclass index 9f398d7051..d6137c4e42 100644 --- a/meta/classes/distutils-base.bbclass +++ b/meta/classes/distutils-base.bbclass @@ -2,3 +2,5 @@ DEPENDS += "${@["${PYTHON_PN}-native ${PYTHON_PN}", ""][(d.getVar('PACKAGES') = RDEPENDS_${PN} += "${@['', '${PYTHON_PN}-core']['${CLASSOVERRIDE}' == 'class-target']}" inherit distutils-common-base pythonnative + +SECURITY_CFLAGS = "${SECURITY_NO_PIE_CFLAGS}"