From patchwork Thu Apr 12 22:55:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_D=C3=ADaz?= X-Patchwork-Id: 133308 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp116045ljb; Thu, 12 Apr 2018 15:55:31 -0700 (PDT) X-Google-Smtp-Source: AIpwx49XRlj5n4umj3XiFuChHk8QxtLl9CXW0DjS2L6yzCfYZz2EhtHJvi5lgeKeJ4Q4yhYwZl8g X-Received: by 10.99.179.68 with SMTP id x4mr2145140pgt.132.1523573731435; Thu, 12 Apr 2018 15:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523573731; cv=none; d=google.com; s=arc-20160816; b=pCJl8sXFwJcYP1IEPWnJyTJ4LKbivKq1IZ7ZYm9xkFhhSV+MW+JuP2RRpwabfz8VBw mFYLtoNMyNvTjSQhu4cQrheDFr8SIF1mOL19PzwbhDioMge3JHtDuRCqAx0s+z6HN2rM F1n2ESGbRSkbNWOIm9wS0kw/NHsbGaLvsunb2Wg6airsFOyBy6y4BvhR28//5rNxfHMi 44FCxZ3K52/fTaGKyv/OlBxoGu+EggPC2VpXqMK55rhNYnlJmCfHZKSNnbnMz9ryMHax X76bU6IcXVgOeEVdHZ10uuFWwuJQMtCHaHaQswio/mmyr2RE5sDs7gamW9vPlLf7D7Xj C03Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=yoYjswmrI+gzqzjoGHP4RlA79+97Ri5uRzdEI6dudlY=; b=G4z1V0KNFAXV+2NnLOTAZ/4fElQG4Wweiz+66k0EaOtIppJc0PiCYMDEmhrcgskdsq pX/xWcaC38D/wFlC0ICtNziXGeBkqhEDzCCJ6Oeufk0Pe3iy9XQN6kRx6tA9jXPSRuHq sUZgzuB4OMQ7j1eAoj+XJYo3OR7K2udnDdB9AlieFuSCwi5s5lIlKKM4IktyuF8VXoFl DAV9ELdTbYW9B6v/tMxgEx6rrS0HWecXRqomnsf9ZfHRMF5/+gll/nnxBQ9R9mq/TVh8 nYLAJLOtHaHUAHk/R0Lf79Z6N/K8KyOVrlaaxr7ZVVIngEcMcMKrFXmBOwXTGUJsDPP8 tlGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CpEsJ81O; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id b25si651763pfc.417.2018.04.12.15.55.30; Thu, 12 Apr 2018 15:55:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CpEsJ81O; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from layers.openembedded.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 1BAA674635; Thu, 12 Apr 2018 22:55:27 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) by mail.openembedded.org (Postfix) with ESMTP id 0AA5074585 for ; Thu, 12 Apr 2018 22:55:15 +0000 (UTC) Received: by mail-oi0-f66.google.com with SMTP id 126-v6so6740872oig.0 for ; Thu, 12 Apr 2018 15:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0+837nVG9mXyTqoOnj1DTt8kDLc76wRrZweyRtVqeXE=; b=CpEsJ81OxAp/PypNST/AUI6fB+xoKzXuI5s5MZztN+Bdnp+DoGQ/54p4DW4YLmOcCc 4+rMXERa1t818QdTe+TPQ3i6koSY8MDVNZfebEg8sO+rggwofKrQjepX1QNFg2tl8Xbc uCHq/7LesWx3/zP8OEDpzJDZwnJ65/ZbBm92Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0+837nVG9mXyTqoOnj1DTt8kDLc76wRrZweyRtVqeXE=; b=duihUFCqXkcgikvEs+y3r/w/XKg0yV/cpVkT0zKF6vQqV9OqsRJAWabItAyUlA/A0C on4YMYdQ4WyJud4OzN0+FY/iwHcgwmJsiMgv+nsgzFnMbn7xq0qQZLdg1gGFDtBs14er +f0x2YFi5gNpXpeI0mvoacYlNZHBWAWtLnNVP0e8m0p5WeJ5mcweNx2rCU21n49UWGhG BGhlPhfAYWO7/2NTZt9Gank5N9IncwCiTpUIKad1kAT9mw42fJy0vfM4uuZl1VxjrrGC ViaHtatvzVMA55iIoPc/pNVkH+5EE/ap5XfdZAwS05F8vhV9aDaGMM/eiNv8f22Zoj5x LwiQ== X-Gm-Message-State: ALQs6tBGvaKsh/C3Sk6EcQOAr542mFwTZGGvPLj2FcySNmFo37fKAqfF cz0C1SeGLrudxZEDrKPo1bCQUnEaztxQPA== X-Received: by 2002:aca:bb02:: with SMTP id l2-v6mr7295140oif.124.1523573716073; Thu, 12 Apr 2018 15:55:16 -0700 (PDT) Received: from localhost.localdomain (CableLink-187-161-190-249.PCs.InterCable.net. [187.161.190.249]) by smtp.googlemail.com with ESMTPSA id k49-v6sm3259864otb.58.2018.04.12.15.55.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 12 Apr 2018 15:55:14 -0700 (PDT) From: =?utf-8?q?Daniel_D=C3=ADaz?= To: openembedded-core@lists.openembedded.org Date: Thu, 12 Apr 2018 17:55:07 -0500 Message-Id: <1523573708-6519-1-git-send-email-daniel.diaz@linaro.org> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Subject: [OE-core] [pyro][PATCH 1/2 v2] glibc: add missing TRAP_BRANCH/TRAP_HWBKPT definitions X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org From: Fathi Boudra Patch submitted upstream, pending to be merged: https://sourceware.org/bugzilla/show_bug.cgi?id=21286 (From OE-Core rev: 11ebb5054e5ec1171ade90249e3a30ac8174a35a) Signed-off-by: Fathi Boudra Signed-off-by: Daniel Díaz Signed-off-by: Ross Burton --- v2: No changes. ...o.h-enum-definition-for-TRAP_HWBKPT-is-mi.patch | 68 ++++++++++++++++++++++ meta/recipes-core/glibc/glibc_2.25.bb | 1 + 2 files changed, 69 insertions(+) create mode 100644 meta/recipes-core/glibc/glibc/0029-bits-siginfo.h-enum-definition-for-TRAP_HWBKPT-is-mi.patch diff --git a/meta/recipes-core/glibc/glibc/0029-bits-siginfo.h-enum-definition-for-TRAP_HWBKPT-is-mi.patch b/meta/recipes-core/glibc/glibc/0029-bits-siginfo.h-enum-definition-for-TRAP_HWBKPT-is-mi.patch new file mode 100644 index 0000000..bef8887 --- /dev/null +++ b/meta/recipes-core/glibc/glibc/0029-bits-siginfo.h-enum-definition-for-TRAP_HWBKPT-is-mi.patch @@ -0,0 +1,68 @@ +From 297aca56465035dce1f7b91b5cdda54379141957 Mon Sep 17 00:00:00 2001 +From: Pratyush Anand +Date: Wed, 22 Mar 2017 17:02:38 +0530 +Subject: [PATCH] bits/siginfo.h: enum definition for TRAP_HWBKPT is missing +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Compile following linux kernel test code with latest glibc: + +https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c + +and we get following error: +breakpoint_test_arm64.c: In function ‘run_test’: +breakpoint_test_arm64.c:171:25: error: ‘TRAP_HWBKPT’ undeclared (first use in this function) + if (siginfo.si_code != TRAP_HWBKPT) { + ^ +I can compile test code by modifying my local +/usr/include/bits/siginfo.h and test works great. Therefore, this patch +will be needed in upstream glibc so that issue is fixed there as well. + +Signed-off-by: Pratyush Anand + +Upstream-Status: Submitted [https://sourceware.org/bugzilla/show_bug.cgi?id=21286] +--- + bits/siginfo.h | 6 +++++- + sysdeps/unix/sysv/linux/bits/siginfo.h | 6 +++++- + 2 files changed, 10 insertions(+), 2 deletions(-) + +diff --git a/bits/siginfo.h b/bits/siginfo.h +index 4919df5..6dc714e 100644 +--- a/bits/siginfo.h ++++ b/bits/siginfo.h +@@ -140,8 +140,12 @@ enum + { + TRAP_BRKPT = 1, /* Process breakpoint. */ + # define TRAP_BRKPT TRAP_BRKPT +- TRAP_TRACE /* Process trace trap. */ ++ TRAP_TRACE, /* Process trace trap. */ + # define TRAP_TRACE TRAP_TRACE ++ TRAP_BRANCH, /* Process branch trap. */ ++# define TRAP_BRANCH TRAP_BRANCH ++ TRAP_HWBKPT /* hardware breakpoint/watchpoint */ ++# define TRAP_HWBKPT TRAP_HWBKPT + }; + # endif + +diff --git a/sysdeps/unix/sysv/linux/bits/siginfo.h b/sysdeps/unix/sysv/linux/bits/siginfo.h +index 7b0d4f6..9cdf42a 100644 +--- a/sysdeps/unix/sysv/linux/bits/siginfo.h ++++ b/sysdeps/unix/sysv/linux/bits/siginfo.h +@@ -235,8 +235,12 @@ enum + { + TRAP_BRKPT = 1, /* Process breakpoint. */ + # define TRAP_BRKPT TRAP_BRKPT +- TRAP_TRACE /* Process trace trap. */ ++ TRAP_TRACE, /* Process trace trap. */ + # define TRAP_TRACE TRAP_TRACE ++ TRAP_BRANCH, /* Process branch trap. */ ++# define TRAP_BRANCH TRAP_BRANCH ++ TRAP_HWBKPT /* hardware breakpoint/watchpoint */ ++# define TRAP_HWBKPT TRAP_HWBKPT + }; + # endif + +-- +2.7.4 + diff --git a/meta/recipes-core/glibc/glibc_2.25.bb b/meta/recipes-core/glibc/glibc_2.25.bb index 58b90b7..49fcf0c 100644 --- a/meta/recipes-core/glibc/glibc_2.25.bb +++ b/meta/recipes-core/glibc/glibc_2.25.bb @@ -43,6 +43,7 @@ SRC_URI = "${GLIBC_GIT_URI};branch=${SRCBRANCH};name=glibc \ file://0026-elf-dl-deps.c-Make-_dl_build_local_scope-breadth-fir.patch \ file://0027-locale-fix-hard-coded-reference-to-gcc-E.patch \ file://0028-Rework-fno-omit-frame-pointer-support-on-i386.patch \ + file://0029-bits-siginfo.h-enum-definition-for-TRAP_HWBKPT-is-mi.patch \ " NATIVESDKFIXES ?= ""