From patchwork Mon Jun 5 16:36:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 103094 Delivered-To: patch@linaro.org Received: by 10.182.29.35 with SMTP id g3csp858278obh; Mon, 5 Jun 2017 09:36:38 -0700 (PDT) X-Received: by 10.99.218.69 with SMTP id l5mr22496583pgj.88.1496680598067; Mon, 05 Jun 2017 09:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496680598; cv=none; d=google.com; s=arc-20160816; b=PhSBuzUUcsCFveWBC8jh+sP3CjxaRqI/nPDWXHZGKIJHXA93l/c6Fej/HxSChfPWJC QyBnIMV4UQM5CEDLcWGi/QNn6FaV7ZFZeGJ3gtWXeF8Kzn29WCoZfRj86rfzdyzd4gnh h+9NmwvohKBF5XOrJNDffJksK3EU0icij21JgNgX0CjmTed8q/tQZnkxLzizMtgsAEmO z2hI/sK9jsMosY55A+QsZZ/u9tZVb2GZfXAEWd4jmPQFbSYZEfYgMRIal6ESjabaCx41 zUZ/PaEL9v/gFW5CquIEr2Ti59W3qMw2yafZijbWFn5IXYHANlVZY+/MQV2fh+Q//Ull GGqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=Es99KClveq9FeEx6HgA31qbXr/OBOjHUorl99Bw1e1s=; b=qBv28O2FQrZH4ETO8kEcHamsLOiNuhZFCo7npIaxF3D0h3JLn9qHaNOx48TK8oOVL5 Z27hhvVa32K5jTElxegyj0akbNbEZUmQwc5ETZAQQmBzyh23/6aCzXeoin2Z+Ah4O5hU t1QM9v816M27xDVZUCRe3ll+M7mUiXvOBVA93x1ZIdgEnqn5pT8S/9X5j2wRJgSKaetO GJiY340Phc9nzCEGVgGJW2paUflYgzi8cj9NY56OSflQM74u+FEzbOjOiK+sB7gx5VX0 bmLTmv4VL5YnwzqmIcBrM6QSWjQgmJOHNzPsWiEv6FRtIm3JSAwQORHPNqLA+hVopMc2 2kGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id a3si7817457pld.102.2017.06.05.09.36.37; Mon, 05 Jun 2017 09:36:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 10FD377F7D; Mon, 5 Jun 2017 16:36:26 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by mail.openembedded.org (Postfix) with ESMTP id 38CCE7808D for ; Mon, 5 Jun 2017 16:36:22 +0000 (UTC) Received: by mail-wm0-f49.google.com with SMTP id x70so17193255wme.0 for ; Mon, 05 Jun 2017 09:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=zIMijvsRq+9arxjWuq1J8v5wSdn1LmYXpbNQWt9hwHE=; b=s4gccN8OCrUUELkrxKTtFT/KS+l67bgzOwS4F5SniUeYvt2Ur8mPM8u9zCtdtlesMr 9h8Jfy9GdgrGRF51U19io4XZ45O6u4Xj8W+Z6lDkRMRP73BDJapwQ8Q6SFIGHmkjOtXA ajluWiQAtfqHRqogQyf+VqdG0v72mzNSb9dGWpgU+4uUYFXRQ/pPR74ozZvY9gExHEaG jgahKRNNBBt2/0oCml98GkMqD/sC0yWZinvOacoKultwWmWFt5nT7COlTa8QgZLmCysz zFtS5on5gKLlyP64kGVK4j8YdPMzr9Pb3HWNozGl6TyCgSi9rcKbTVZPn1WZ1NeU682I CR/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=zIMijvsRq+9arxjWuq1J8v5wSdn1LmYXpbNQWt9hwHE=; b=MyNgrPOUDUqlF2QhS6tyyrk0G7Bwxu0LdZdAnrsIIMRfqVDZ9ASEeepPFsJM1QWLFZ tXL4M+1q7WwJchZMrN60BrKVIRBSWVzWRaUQz/n4T3Fty+TDlEfdevdxGQNtx+7Jbz2S zrGuVkrVHDk8WWw9bVlQu2KIDEQIG8Mh4JXmqP55RFJ69lmqaxGq1PwNGuWEwS5KioCz ziZTaI/eRyMEJDvZSBtTkBakH5mNOAs62aH3EmKYmE8Eti/PRVc/ju4O8gHSsD0aLdOV 3+oVBs8brQW45Z1/bOoqmOU/Wx/teG/e8RAa3CAkWALbOZiHzOJQyFlcpBv2nuDXoV9T kMew== X-Gm-Message-State: AODbwcD2+Uv6ekJ/7soosiaJU7UVclkVlBIFKta9srLl7sYVaMwxh/DH bonQzItZ5FeEow9G1qE= X-Received: by 10.28.156.142 with SMTP id f136mr8942711wme.24.1496680583215; Mon, 05 Jun 2017 09:36:23 -0700 (PDT) Received: from flashheart.burtonini.com (home.burtonini.com. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id q77sm10655554wmb.4.2017.06.05.09.36.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Jun 2017 09:36:22 -0700 (PDT) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 5 Jun 2017 17:36:21 +0100 Message-Id: <1496680581-5379-1-git-send-email-ross.burton@intel.com> X-Mailer: git-send-email 2.8.1 Subject: [OE-core] [PATCH] oeqa/selftest: lock down Meson git revision for reliability X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org The test_recipetool_create_github test fetches HEAD of the repository so upstream changes can (and do) break the test. Avoid these problems by passing the rev= argument in the URL to lock the checkout to the same version that is fetched in the github_tarball test. Also pass the commands to runCmd() as a list instead of a string, the semicolon in the URL needs more quotes if the shell is involved and passing a list bypasses the shell entirely. Signed-off-by: Ross Burton --- meta/lib/oeqa/selftest/recipetool.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.8.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/lib/oeqa/selftest/recipetool.py b/meta/lib/oeqa/selftest/recipetool.py index 7bfb02f..4344f9f 100644 --- a/meta/lib/oeqa/selftest/recipetool.py +++ b/meta/lib/oeqa/selftest/recipetool.py @@ -449,8 +449,8 @@ class RecipetoolTests(RecipetoolBase): temprecipe = os.path.join(self.tempdir, 'recipe') os.makedirs(temprecipe) recipefile = os.path.join(temprecipe, 'meson_git.bb') - srcuri = 'https://github.com/mesonbuild/meson' - result = runCmd('recipetool create -o %s %s' % (temprecipe, srcuri)) + srcuri = 'https://github.com/mesonbuild/meson;rev=0.32.0' + result = runCmd(['recipetool', 'create', '-o', temprecipe, srcuri]) self.assertTrue(os.path.isfile(recipefile)) checkvars = {} checkvars['LICENSE'] = set(['Apache-2.0'])