From patchwork Tue Oct 11 12:19:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 77475 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp321995qge; Tue, 11 Oct 2016 05:19:56 -0700 (PDT) X-Received: by 10.66.245.47 with SMTP id xl15mr6530928pac.173.1476188396870; Tue, 11 Oct 2016 05:19:56 -0700 (PDT) Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 19si668135pgc.314.2016.10.11.05.19.56; Tue, 11 Oct 2016 05:19:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 0D57171A2F; Tue, 11 Oct 2016 12:19:52 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by mail.openembedded.org (Postfix) with ESMTP id 46D9971A0E for ; Tue, 11 Oct 2016 12:19:49 +0000 (UTC) Received: by mail-lf0-f44.google.com with SMTP id b75so38275350lfg.3 for ; Tue, 11 Oct 2016 05:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=PkqfqaJZgK0v8YN9uCB2Kv1ZBGpcx40NBR8ZD+FlaL8=; b=iSdzAxQ8rXKwsg4wxMb2SMuLu8v2r0dAq8S3isdCgNZg6stDhdDrDkUG+fO8Uspg7W 9u7sFFq+IOZge/RlH8yBZ7qmzoDWN6uDcLdFtbhxgr3gwmWux+b3qwyHVW7QOkvD4dPg szNhr1H7fLPVCj8acdbkwltzfoeastmRxl3LUIEB0NM5VTQMe1dBd5P1Sb6msuKAf7+V dePYrtDweVZ234VmxlIkWpuNysC6r9ySpGQjKBrxYEoFcaZJDs6iMSgaaI+Ibc9hLwng ZwmCyEkSqPA4Hi16NzCJDUE+GHgOMxVgivTd7UZz/TC4PuJ145XGbMC1IPWrx2K4WXnA IFOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=PkqfqaJZgK0v8YN9uCB2Kv1ZBGpcx40NBR8ZD+FlaL8=; b=bvhQeh0J9ESeFEoiPPmeJyu5f0dOJ4R9gAE9NKonSWUUPi1bWDfjS0YIxU7zbic5LE dGXQna8P1J45S5iLp9rPB/xT6DvH1S8BlDh8hrUyGD9LBDl4v9L2donPo321CHEVT0Z8 KXsh+Lt+S1di7btx6vFCa8pRsXKQG3FqrYPZ4bRpx5rpX0QuBKWEWDUkKpZJsWiHQ38N KT11vcXL1AQs4qRrFZumvHkuaViUTCah0EiFixpH8ZbnKKoCoclJ2LtOLxJ5p0VJpBye fjAeAZEiMiOOUPhgJGBA22895niib+kgQwOS1xFg5qHkVSnnx+qJ5uvV3RPjWNoM0esT imeg== X-Gm-Message-State: AA6/9RkXa4YZdau2ydiXUMGa3fFT4oeVo06KDMJsr8KtnA6nIT4SxER08BD7v67HhWCsBFDb X-Received: by 10.194.28.166 with SMTP id c6mr4682006wjh.40.1476188390878; Tue, 11 Oct 2016 05:19:50 -0700 (PDT) Received: from flashheart.burtonini.com (home.burtonini.com. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id yo1sm6005196wjc.16.2016.10.11.05.19.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 11 Oct 2016 05:19:50 -0700 (PDT) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Tue, 11 Oct 2016 13:19:44 +0100 Message-Id: <1476188384-16064-2-git-send-email-ross.burton@intel.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1476188384-16064-1-git-send-email-ross.burton@intel.com> References: <1476188384-16064-1-git-send-email-ross.burton@intel.com> Subject: [OE-core] [PATCH 2/2] insane: display names instead of ELF machine numbers X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org The 'arch' QA test currently simply outputs the ELF machine field as a number which isn't helpful. Display this as a human-readable name to make it clearer to the user what the problem is. Signed-off-by: Ross Burton --- meta/classes/insane.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.8.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index b347638..17c9284 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -543,8 +543,8 @@ def package_qa_check_arch(path,name,d, elf, messages): # Check the architecture and endiannes of the binary if not ((machine == elf.machine()) or \ ((("virtual/kernel" in provides) or bb.data.inherits_class("module", d) ) and (target_os == "linux-gnux32" or target_os == "linux-gnun32"))): - package_qa_add_message(messages, "arch", "Architecture did not match (%d to %d) on %s" % \ - (machine, elf.machine(), package_qa_clean_path(path,d))) + package_qa_add_message(messages, "arch", "Architecture did not match (%s, expected %s) on %s" % \ + (oe.qa.elf_machine_to_string(elf.machine()), oe.qa.elf_machine_to_string(machine), package_qa_clean_path(path,d))) elif not ((bits == elf.abiSize()) or \ ((("virtual/kernel" in provides) or bb.data.inherits_class("module", d) ) and (target_os == "linux-gnux32" or target_os == "linux-gnun32"))): package_qa_add_message(messages, "arch", "Bit size did not match (%d to %d) %s on %s" % \