From patchwork Mon Feb 18 09:42:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 158579 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2281931jaa; Mon, 18 Feb 2019 01:44:36 -0800 (PST) X-Google-Smtp-Source: AHgI3IaxFBfrtGhfGMKjS+eeODqn6RjFbedP2+VGs4e4RkoBX8dFNTiP5uepKMuMxb8yc32PO0tn X-Received: by 2002:a81:3d45:: with SMTP id k66mr17759828ywa.279.1550483076824; Mon, 18 Feb 2019 01:44:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550483076; cv=none; d=google.com; s=arc-20160816; b=uzE9My1YQoHAowGZV/VLqih8WcZYQDw5aHUyhjCnsyt1y/INzRXJtVgRr/X1FYc++i L4Dnx/pqOQfIpXm7gHkKuJw838SXu7uONu0ff3hafVrInaxxJeLr/d1iBr40Oe9pUyjH grBuX/zK3LRiGqxcPU1AHG37mhv9/1l7yOX841J9HAhDeAhChxFnV8Kur41maR2x/4AL h0FTh361Tp4TPKwDmYfHciMoDK95k24kLW63/F5XrXwqDZA0vbJv8CnBAkx5j//oJzoY /6mqFrsxdXBjUjoQxj4LuXKi2a35y7OuctcBLxwHe4LHrUg/z/pBhgpzY/DzmxHiU6rG 2pCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:message-id:date:to:from; bh=TCtaW1bvdDJSJv3Q5l1t0wSfBQ/5/RlMNdBJF2AUAPE=; b=AGbrJaJHC4RWM7giUPgAUNFI8KdskIR9barb8X+i4LPZ7/NJFi9P3taS2KxgZdEckr Mg+A+L2YAkhQ2ren8QUEEfpH3oktMa7CP6XePSLlC2WRI6zEFhJmNp3Iv5SrQFGsLn9J wj9K/RStQhtrEjBezmjQbNqNrDtCnLCYPxXOB4F8eMC+m0DsgHRSoyLlEK4Q4gR6oA61 HQ4SyU1WimzygGh9TZ9ci9+DEpC5j2kc7ZBPiKNksoNygHi9X0w1xRyL9fC7zW2hlUiT qb7Zr/0Ucag65ZHlw1MBRyuSBCkUF7jEvsbpdOKR8+iZiAygu5wv/8i4PvxgrYmvBNAq yCMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id v5si7045301ywd.47.2019.02.18.01.44.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Feb 2019 01:44:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gvfRh-0007m2-8D; Mon, 18 Feb 2019 09:42:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gvfRg-0007lx-5M for xen-devel@lists.xenproject.org; Mon, 18 Feb 2019 09:42:40 +0000 X-Inumbo-ID: 873e80c6-3361-11e9-bafa-cb21c4088567 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 873e80c6-3361-11e9-bafa-cb21c4088567; Mon, 18 Feb 2019 09:42:38 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5129880D; Mon, 18 Feb 2019 01:42:38 -0800 (PST) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ED6FC3F589; Mon, 18 Feb 2019 01:42:36 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 18 Feb 2019 09:42:27 +0000 Message-Id: <20190218094227.27176-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH for-4.12] xen/arm: psci: Populate arm_smccc_res on PSCI_FEATURES call X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Artem_Mygaiev@epam.com, jgross@suse.com, sstabellini@kernel.org, Andrii_Anisov@epam.com, Oleksandr_Tyshchenko@epam.com, Julien Grall MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Commit 0bc6a68da5 "xen/arm: Replace call_smc with arm_smccc_smc" mistakenly forgot to populate arm_smccc_res. So a garbagge value was used as return value. Coverity-ID: 1476827 Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- xen/arch/arm/psci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c index d23cb8e76e..0c90c2305c 100644 --- a/xen/arch/arm/psci.c +++ b/xen/arch/arm/psci.c @@ -87,7 +87,7 @@ static int __init psci_features(uint32_t psci_func_id) if ( psci_ver < PSCI_VERSION(1, 0) ) return PSCI_NOT_SUPPORTED; - arm_smccc_smc(PSCI_1_0_FN32_PSCI_FEATURES, psci_func_id, NULL); + arm_smccc_smc(PSCI_1_0_FN32_PSCI_FEATURES, psci_func_id, &res); return PSCI_RET(res); }