| Message ID | 20180305160415.16760-49-andre.przywara@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | New VGIC(-v2) implementation | expand |
Hi Andre, On 05/03/18 16:04, Andre Przywara wrote: > When we dump guest state on the Xen console, we also print the state of > IRQs that are on a VCPU. > Add the code to dump the state of an IRQ handled by the new VGIC. > > Signed-off-by: Andre Przywara <andre.przywara@linaro.org> Acked-by: Julien Grall <julien.grall@arm.com> Cheers, > --- > Changelog RFC ... v1: > - use proper locking > - use one header line to announce active or pending IRQs > > xen/arch/arm/vgic/vgic.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c > index e9ef992e1e..2a2b8fd1eb 100644 > --- a/xen/arch/arm/vgic/vgic.c > +++ b/xen/arch/arm/vgic/vgic.c > @@ -765,6 +765,31 @@ void vgic_free_virq(struct domain *d, unsigned int virq) > clear_bit(virq, d->arch.vgic.allocated_irqs); > } > > +void gic_dump_vgic_info(struct vcpu *v) > +{ > + struct vgic_cpu *vgic_cpu = &v->arch.vgic; > + struct vgic_irq *irq; > + unsigned long flags; > + > + spin_lock_irqsave(&v->arch.vgic.ap_list_lock, flags); > + > + if ( !list_empty(&vgic_cpu->ap_list_head) ) > + printk(" active or pending interrupts queued:\n"); > + > + list_for_each_entry ( irq, &vgic_cpu->ap_list_head, ap_list ) > + { > + spin_lock(&irq->irq_lock); > + printk(" %s %s irq %u: %spending, %sactive, %senabled\n", > + irq->hw ? "hardware" : "virtual", > + irq->config == VGIC_CONFIG_LEVEL ? "level" : "edge", > + irq->intid, irq_is_pending(irq) ? "" : "not ", > + irq->active ? "" : "not ", irq->enabled ? "" : "not "); > + spin_unlock(&irq->irq_lock); > + } > + > + spin_unlock_irqrestore(&v->arch.vgic.ap_list_lock, flags); > +} > + > struct irq_desc *vgic_get_hw_irq_desc(struct domain *d, struct vcpu *v, > unsigned int virq) > { >
diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c index e9ef992e1e..2a2b8fd1eb 100644 --- a/xen/arch/arm/vgic/vgic.c +++ b/xen/arch/arm/vgic/vgic.c @@ -765,6 +765,31 @@ void vgic_free_virq(struct domain *d, unsigned int virq) clear_bit(virq, d->arch.vgic.allocated_irqs); } +void gic_dump_vgic_info(struct vcpu *v) +{ + struct vgic_cpu *vgic_cpu = &v->arch.vgic; + struct vgic_irq *irq; + unsigned long flags; + + spin_lock_irqsave(&v->arch.vgic.ap_list_lock, flags); + + if ( !list_empty(&vgic_cpu->ap_list_head) ) + printk(" active or pending interrupts queued:\n"); + + list_for_each_entry ( irq, &vgic_cpu->ap_list_head, ap_list ) + { + spin_lock(&irq->irq_lock); + printk(" %s %s irq %u: %spending, %sactive, %senabled\n", + irq->hw ? "hardware" : "virtual", + irq->config == VGIC_CONFIG_LEVEL ? "level" : "edge", + irq->intid, irq_is_pending(irq) ? "" : "not ", + irq->active ? "" : "not ", irq->enabled ? "" : "not "); + spin_unlock(&irq->irq_lock); + } + + spin_unlock_irqrestore(&v->arch.vgic.ap_list_lock, flags); +} + struct irq_desc *vgic_get_hw_irq_desc(struct domain *d, struct vcpu *v, unsigned int virq) {
When we dump guest state on the Xen console, we also print the state of IRQs that are on a VCPU. Add the code to dump the state of an IRQ handled by the new VGIC. Signed-off-by: Andre Przywara <andre.przywara@linaro.org> --- Changelog RFC ... v1: - use proper locking - use one header line to announce active or pending IRQs xen/arch/arm/vgic/vgic.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)