From patchwork Fri Jun 9 23:44:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 103543 Delivered-To: patches@linaro.org Received: by 10.140.91.77 with SMTP id y71csp16765qgd; Fri, 9 Jun 2017 16:44:52 -0700 (PDT) X-Received: by 10.84.209.199 with SMTP id y65mr43544241plh.205.1497051892717; Fri, 09 Jun 2017 16:44:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497051892; cv=none; d=google.com; s=arc-20160816; b=q4hAqF9yqtVUBLcVm5/oTA1t/Bc4QJQwZhXOE4LtRBQoTlZhCGq5ILHBrgnyRjgiTj 5gC6vHDg+doC5TaXJeKKMDkvFknSzBe9L8KsQUQJAo26cfy46jfFiviwAV9Z8NF8069D cLlnsLjHefcmBCkL96ZtqhfYKoRKSDveXyM5zfuHwXhywDEX9Pn5GYVPGr/u1dp5bImF dubZRcelyRO4QH8mqUEiP5ytjDn6cyMm8wmgfkvBW9VrXpSq6P0t7iLnXLwhzcid6x9x OMVs9reFEFxfjN0XVJmAx+YB3goVzNQsUUf3ftMy/RLN9uoml92LUtKG5P37efNEEN6n ywXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=vvoNaK8KUmguPzlMvzcwTJFcYdMugO2L7bGFoP4w3zs=; b=tqTKYujM2dVfCOHhHI6xpH3YfPP2/Yvg6mAhBqplA8z/SlSJf73Sn+Q0Ohf/caqS+B PX2Rf8WhIfWcFfqvXntzRIb9JAek5USx5/acKeMuGG4KJa0P66SBAgTLgfDI5tnx0TSU KwIM23jRDDikvWy4P9h1WekU0tIvqzT7cBhKDAVDFo1LnpUjuZ6baPrg8qX5wVTecDGq EDjaQQbNl/OdV5aO7Vee3OTmE2LJK4uz0HjfEKYJv2JrAzR9G4cmS8hloGS0pL9qHfKh 6Oslhp8rLC6uGPq6KY5GZupAFvQEaAPmUW80Hq9v54tnuYA76fXSJUHhgcbrHM33ABr/ jbKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id d9sor1896142plj.8.2017.06.09.16.44.52 for (Google Transport Security); Fri, 09 Jun 2017 16:44:52 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=vvoNaK8KUmguPzlMvzcwTJFcYdMugO2L7bGFoP4w3zs=; b=JFIvI7gK57dCbDisYHvy1RkuKfwZvURPX2rVIrgqtf9vctiCqUCq8Eeq+S293klXF1 hWuJchZlKBkK6Xf+vb+wBCOTGUaP8omSaRa7nOkPv0/8LLbFXSZyAoUt2RxgZ35RKgbU sRWYSitKvjQwRQquTgJCNhe7KJvkTNQWhHARI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vvoNaK8KUmguPzlMvzcwTJFcYdMugO2L7bGFoP4w3zs=; b=By+JEpIVu03vP7Mn21hOLvOSE3D75UQOcnP5MyX2A4APFOBohEfoiQ6K6fh2rf7Cxu 8Mbl/PEE+P1OvaY1RpVvD7K7uMmLF/A4x5UmaWKCY8ZZiSydUkiwhczmzx3rpcewiiHf QBU4rhDTreAh58jPaFrQiHM/sjZHfdu6xl6JiXBHRJak/xyDKVW/qLYJcVnt0JUdbH/t UvSK6TcvoV0hMrx3zFowhy/HjFFESyMFLZUS/muAMxYf5W5jZ4qGRiYNgZi74OGkjLew eOK5CDc+qjO0b2aHMcAzAMzRfSTNYRhXpfEI1ebT17KWJn+L5sMXFxUE7/IKLgC03c5W zL8Q== X-Gm-Message-State: AODbwcCYuftS+LguAmypo74yvVDruHS8OEoiz6Xg4OlhNwl6gdL7Ik3c rHvkH1tlTuM5sZ8Z7AzQqqEG X-Received: by 10.84.217.93 with SMTP id e29mr43930458plj.287.1497051892428; Fri, 09 Jun 2017 16:44:52 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:1002:83f0:4e72:b9ff:fe99:466a]) by smtp.gmail.com with ESMTPSA id s10sm5085211pfi.16.2017.06.09.16.44.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Jun 2017 16:44:51 -0700 (PDT) From: John Stultz To: Rob Herring Cc: John Stultz Subject: [PATCH] HACK: Avoid graphical glitches on db410c Date: Fri, 9 Jun 2017 16:44:48 -0700 Message-Id: <1497051888-18935-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 Narrowed this down diffing from a previous branch that didn't have the glitches that this branch currently has. With this patch, I don't see the flashing glitches and tearing that I'm seeing without it. Seems to be related to a previous patch from RobH: force single plane except for cursor Signed-off-by: John Stultz --- drmhwctwo.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drmhwctwo.cpp b/drmhwctwo.cpp index 048117f..2bd8882 100644 --- a/drmhwctwo.cpp +++ b/drmhwctwo.cpp @@ -725,11 +725,11 @@ HWC2::Error DrmHwcTwo::HwcDisplay::ValidateDisplay(uint32_t *num_types, switch (layer.sf_type()) { case HWC2::Composition::SolidColor: case HWC2::Composition::Sideband: + default: layer.set_validated_type(HWC2::Composition::Client); ++*num_types; break; case HWC2::Composition::Cursor: - default: layer.set_validated_type(layer.sf_type()); break; }