From patchwork Thu Nov 3 14:36:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 80675 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp668728qge; Thu, 3 Nov 2016 07:38:44 -0700 (PDT) X-Received: by 10.107.12.148 with SMTP id 20mr8662247iom.208.1478183924539; Thu, 03 Nov 2016 07:38:44 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id r193si25273588itc.88.2016.11.03.07.38.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Nov 2016 07:38:44 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2J8I-0000Vs-GW; Thu, 03 Nov 2016 14:36:46 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2J8H-0000Vh-CO for xen-devel@lists.xen.org; Thu, 03 Nov 2016 14:36:45 +0000 Received: from [85.158.143.35] by server-11.bemta-6.messagelabs.com id 29/9C-14466-C7B4B185; Thu, 03 Nov 2016 14:36:44 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRWlGSWpSXmKPExsVysyfVTbfGWzr C4OQ9boslHxezODB6HN39mymAMYo1My8pvyKBNePkuYvMBTs5KibfzmxgXMbexcjFISSwkVFi 2beZzBDOaUaJ3+vWMXUxcnKwCWhK3Pn8CcwWEZCWuPb5MiOIzSwQJvH26BYwW1ggXmL3vFNsI DaLgKpE84FV7CA2r4CTxL4n/SwgtoSAnMTJY5NZJzByLmBkWMWoUZxaVJZapGtoqpdUlJmeUZ KbmJmja2hgppebWlycmJ6ak5hUrJecn7uJEegvBiDYwfhtWcAhRkkOJiVR3jea0hFCfEn5KZU ZicUZ8UWlOanFhxhlODiUJHglvIBygkWp6akVaZk5wMCBSUtw8CiJ8LKBpHmLCxJzizPTIVKn GHU53ux6+YBJiCUvPy9VSpzXD6RIAKQoozQPbgQsiC8xykoJ8zICHSXEU5BalJtZgir/ilGcg 1FJmDcWZApPZl4J3KZXQEcwAR1hniQBckRJIkJKqoGRr1P1umHZMo4lPRr7DliX1k0Oya6cXK Rl1rvKe9MmpYql3VMSnsju4l7ZFzRVc1LqpV71OUckNNcrM6+5e7UpP23mmW/Z+53cdX88LRR KTj/hpc6Y1ivh2Lx+fipH/d5TM3S6hD9Fsaw/+V3GncddTFeMM7VLp+/WoeLlj474qQa6ZxRa VSqxFGckGmoxFxUnAgCtcjShXQIAAA== X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-2.tower-21.messagelabs.com!1478183803!27573425!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests=UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 38584 invoked from network); 3 Nov 2016 14:36:44 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-2.tower-21.messagelabs.com with SMTP; 3 Nov 2016 14:36:44 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDE9A28; Thu, 3 Nov 2016 07:36:42 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.218.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BE183F318; Thu, 3 Nov 2016 07:36:42 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Thu, 3 Nov 2016 14:36:35 +0000 Message-Id: <1478183795-740-1-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 Cc: Julien Grall , sstabellini@kernel.org, wei.liu2@citrix.com Subject: [Xen-devel] [PATCH for-4.8] xen/arm: early-printk: It should depends on CONFIG_DEBUG and not debug X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" The variable debug is used to enable debug for the tools. As early-printk is for the hypervisor we should use CONFIG_DEBUG. Signed-off-by: Julien Grall Acked-by: Wei Liu --- This patch is candidate for Xen 4.8. This is a follow-up of [1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2016-11/msg00082.html --- xen/arch/arm/Rules.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk index 93304be..569a0ba 100644 --- a/xen/arch/arm/Rules.mk +++ b/xen/arch/arm/Rules.mk @@ -24,7 +24,7 @@ endif EARLY_PRINTK := n -ifeq ($(debug),y) +ifeq ($(CONFIG_DEBUG),y) # See docs/misc/arm/early-printk.txt for syntax @@ -77,7 +77,7 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD) CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS) CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT) -else # !debug +else # !CONFIG_DEBUG ifneq ($(CONFIG_EARLY_PRINTK),) # Early printk is dependant on a debug build.