From patchwork Thu Jul 28 14:51:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 72972 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp894592qga; Thu, 28 Jul 2016 07:54:16 -0700 (PDT) X-Received: by 10.36.184.133 with SMTP id m127mr25710635ite.90.1469717656821; Thu, 28 Jul 2016 07:54:16 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id f21si13459565ioj.206.2016.07.28.07.54.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jul 2016 07:54:16 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSmfi-0003Vf-DI; Thu, 28 Jul 2016 14:52:26 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSmfg-0003Py-9H for xen-devel@lists.xen.org; Thu, 28 Jul 2016 14:52:24 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id E6/4A-23620-72C1A975; Thu, 28 Jul 2016 14:52:23 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRWlGSWpSXmKPExsVysyfVTVddZla 4wfOz3BZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8adi3uYCrqlKi7/m8HYwNgp3MXIxSEksIlR 4uDkSywQzmlGiVd/nrJ2MXJysAloStz5/IkJxBYRkJa49vkyI0gRs0A7o8Ta/l5mkISwgL/Ej rsN7F2MHBwsAqoS57cpgIR5BVwkNi84A1YiISAncfLYZFaQEk6g+OtuIZCwkICzxPSZSxknMH IvYGRYxahRnFpUllqka2iol1SUmZ5RkpuYmaNraGCsl5taXJyYnpqTmFSsl5yfu4kR6F8GINj BuPq30yFGSQ4mJVHesNCZ4UJ8SfkplRmJxRnxRaU5qcWHGGU4OJQkeG9JzQoXEixKTU+tSMvM AQYaTFqCg0dJhFdOGijNW1yQmFucmQ6ROsWoKCXOWwPSJwCSyCjNg2uDBfclRlkpYV5GoEOEe ApSi3IzS1DlXzGKczAqCfMyg4znycwrgZv+CmgxE9Di4tgZIItLEhFSUg2M3b8ecLArFocnvK x4PuObzY4bmb8ygrpWBXZyTThb9CDjQcOPlQr9TsUxeu4W2n8FoyZIqiepixbFyxUd95NUeHl n4aWjru+VdHW+ChaaS+/vaIvaX+5zUuLo1+VL/TZorYppeHb+/M2d/0JvhHtvq4xa/LfXX0Wp qytAXUbeVNX62ZZnGo1KLMUZiYZazEXFiQClkiMKaQIAAA== X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-3.tower-31.messagelabs.com!1469717535!52886556!6 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked Received: (qmail 55416 invoked from network); 28 Jul 2016 14:52:22 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-3.tower-31.messagelabs.com with SMTP; 28 Jul 2016 14:52:22 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFC9CC01; Thu, 28 Jul 2016 07:53:39 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.218.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C2E63F21A; Thu, 28 Jul 2016 07:52:21 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Thu, 28 Jul 2016 15:51:45 +0100 Message-Id: <1469717505-8026-23-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469717505-8026-1-git-send-email-julien.grall@arm.com> References: <1469717505-8026-1-git-send-email-julien.grall@arm.com> Cc: proskurin@sec.in.tum.de, Julien Grall , sstabellini@kernel.org, steve.capper@arm.com, wei.chen@linaro.org Subject: [Xen-devel] [RFC 22/22] xen/arm: p2m: Do not handle shattering in p2m_create_table X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" The helper p2m_create_table is only called to create a brand new table. Signed-off-by: Julien Grall --- xen/arch/arm/p2m.c | 51 ++++++--------------------------------------------- 1 file changed, 6 insertions(+), 45 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 16ed393..4aaa96f 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -264,8 +264,7 @@ static p2m_access_t p2m_mem_access_radix_get(struct p2m_domain *p2m, gfn_t gfn) #define GUEST_TABLE_SUPER_PAGE 1 #define GUEST_TABLE_NORMAL_PAGE 2 -static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry, - int level_shift); +static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry); /* * Take the currently mapped table, find the corresponding GFN entry, @@ -291,7 +290,7 @@ static int p2m_next_level(struct p2m_domain *p2m, bool read_only, if ( read_only ) return GUEST_TABLE_MAP_FAILED; - ret = p2m_create_table(p2m, entry, /* not used */ ~0); + ret = p2m_create_table(p2m, entry); if ( ret ) return GUEST_TABLE_MAP_FAILED; } @@ -557,25 +556,14 @@ static inline void p2m_remove_pte(lpae_t *p, bool clean_pte) p2m_write_pte(p, pte, clean_pte); } -/* - * Allocate a new page table page and hook it in via the given entry. - * apply_one_level relies on this returning 0 on success - * and -ve on failure. - * - * If the existing entry is present then it must be a mapping and not - * a table and it will be shattered into the next level down. - * - * level_shift is the number of bits at the level we want to create. - */ -static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry, - int level_shift) +/* Allocate a new page table page and hook it in via the given entry. */ +static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry) { struct page_info *page; lpae_t *p; lpae_t pte; - int splitting = p2m_valid(*entry); - BUG_ON(p2m_table(*entry)); + ASSERT(!p2m_valid(*entry)); page = alloc_domheap_page(NULL, 0); if ( page == NULL ) @@ -584,35 +572,8 @@ static int p2m_create_table(struct p2m_domain *p2m, lpae_t *entry, page_list_add(page, &p2m->pages); p = __map_domain_page(page); - if ( splitting ) - { - p2m_type_t t = entry->p2m.type; - mfn_t mfn = _mfn(entry->p2m.base); - int i; - /* - * We are either splitting a first level 1G page into 512 second level - * 2M pages, or a second level 2M page into 512 third level 4K pages. - */ - for ( i=0 ; i < LPAE_ENTRIES; i++ ) - { - pte = mfn_to_p2m_entry(mfn_add(mfn, i << (level_shift - LPAE_SHIFT)), - t, p2m->default_access); - - /* - * First and second level super pages set p2m.table = 0, but - * third level entries set table = 1. - */ - if ( level_shift - LPAE_SHIFT ) - pte.p2m.table = 0; - - write_pte(&p[i], pte); - } - - page->u.inuse.p2m_refcount = LPAE_ENTRIES; - } - else - clear_page(p); + clear_page(p); if ( p2m->clean_pte ) clean_dcache_va_range(p, PAGE_SIZE);