From patchwork Wed Jul 6 13:01:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 71462 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp854427qgy; Wed, 6 Jul 2016 06:04:42 -0700 (PDT) X-Received: by 10.107.195.140 with SMTP id t134mr21615328iof.175.1467810282499; Wed, 06 Jul 2016 06:04:42 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id l12si3634742iol.136.2016.07.06.06.04.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Jul 2016 06:04:42 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKmSt-0000oU-LP; Wed, 06 Jul 2016 13:02:07 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKmSs-0000nG-K3 for xen-devel@lists.xen.org; Wed, 06 Jul 2016 13:02:06 +0000 Received: from [85.158.137.68] by server-14.bemta-3.messagelabs.com id 15/2A-07949-D410D775; Wed, 06 Jul 2016 13:02:05 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRWlGSWpSXmKPExsVysyfVTdeXsTb c4NcvEYslHxezODB6HN39mymAMYo1My8pvyKBNaNl82rmghbVio0tcQ2M+yW7GLk4hAQ2MUoc ezePHcI5zSixrfUbSxcjJwebgKbEnc+fmEBsEQFpiWufLzOC2MwCDhJvPt4DqxEW8JD4cbCbH cRmEVCV+DWjE6yGV8BV4tST9WC2hICcxMljk1lBbE6g+PRrj8HqhQRcJLYvnsQ8gZF7ASPDKk b14tSistQiXQu9pKLM9IyS3MTMHF1DA2O93NTi4sT01JzEpGK95PzcTYxA7zIAwQ7GC+3Ohxg lOZiURHlZvlWHC/El5adUZiQWZ8QXleakFh9ilOHgUJLgbfhfEy4kWJSanlqRlpkDDDOYtAQH j5IIrz5Imre4IDG3ODMdInWKUVFKnFcSJCEAksgozYNrg4X2JUZZKWFeRqBDhHgKUotyM0tQ5 V8xinMwKgnz9oBM4cnMK4Gb/gpoMRPQ4p8u1SCLSxIRUlINjF4LGP41bE/MUE3wOaTTtOR1u8 MxmQMNVgIHty9nsNnaJfM2b2Pg7DqZewJXjx/o+e9V2Nn5UNmTM3xveKvJktJvjySKNqpOkGo IY+Dp/Jey4dF71jY2f9uflz38T2Yf9j9fM1l6Yt4pv5PmTwKY9x//ye/29te3P5FOB9fdrfj9 b+EDj0D9H0osxRmJhlrMRcWJAByPD39oAgAA X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1467810124!49151092!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20993 invoked from network); 6 Jul 2016 13:02:05 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-14.tower-31.messagelabs.com with SMTP; 6 Jul 2016 13:02:05 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BCAABBB; Wed, 6 Jul 2016 06:02:33 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.215.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C09CF3F21A; Wed, 6 Jul 2016 06:01:33 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Wed, 6 Jul 2016 14:01:08 +0100 Message-Id: <1467810073-27971-10-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1467810073-27971-1-git-send-email-julien.grall@arm.com> References: <1467810073-27971-1-git-send-email-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org Subject: [Xen-devel] [PATCH v6 09/14] xen/arm: p2m: Remove unused operation ALLOCATE X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" The operation ALLOCATE is unused. If we ever need it, it could be reimplemented with INSERT. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v6: - Add Stefano's acked-by Changes in v4: - Patch added --- xen/arch/arm/p2m.c | 67 ++--------------------------------------------- xen/include/asm-arm/p2m.h | 3 --- 2 files changed, 2 insertions(+), 68 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index fcc4513..f11094e 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -547,7 +547,6 @@ static int p2m_mem_access_radix_set(struct p2m_domain *p2m, unsigned long pfn, enum p2m_operation { INSERT, - ALLOCATE, REMOVE, RELINQUISH, CACHEFLUSH, @@ -667,7 +666,6 @@ static int apply_one_level(struct domain *d, { const paddr_t level_size = level_sizes[level]; const paddr_t level_mask = level_masks[level]; - const paddr_t level_shift = level_shifts[level]; struct p2m_domain *p2m = &d->arch.p2m; lpae_t pte; @@ -678,58 +676,6 @@ static int apply_one_level(struct domain *d, switch ( op ) { - case ALLOCATE: - ASSERT(level < 3 || !p2m_valid(orig_pte)); - ASSERT(*maddr == 0); - - if ( p2m_valid(orig_pte) ) - return P2M_ONE_DESCEND; - - if ( is_mapping_aligned(*addr, end_gpaddr, 0, level_size) && - /* We only create superpages when mem_access is not in use. */ - (level == 3 || (level < 3 && !p2m->mem_access_enabled)) ) - { - struct page_info *page; - - page = alloc_domheap_pages(d, level_shift - PAGE_SHIFT, 0); - if ( page ) - { - rc = p2m_mem_access_radix_set(p2m, paddr_to_pfn(*addr), a); - if ( rc < 0 ) - { - free_domheap_page(page); - return rc; - } - - pte = mfn_to_p2m_entry(page_to_mfn(page), mattr, t, a); - if ( level < 3 ) - pte.p2m.table = 0; - p2m_write_pte(entry, pte, flush_cache); - p2m->stats.mappings[level]++; - - *addr += level_size; - - return P2M_ONE_PROGRESS; - } - else if ( level == 3 ) - return -ENOMEM; - } - - /* L3 is always suitably aligned for mapping (handled, above) */ - BUG_ON(level == 3); - - /* - * If we get here then we failed to allocate a sufficiently - * large contiguous region for this level (which can't be - * L3) or mem_access is in use. Create a page table and - * continue to descend so we try smaller allocations. - */ - rc = p2m_create_table(d, entry, 0, flush_cache); - if ( rc < 0 ) - return rc; - - return P2M_ONE_DESCEND; - case INSERT: if ( is_mapping_aligned(*addr, end_gpaddr, *maddr, level_size) && /* @@ -1169,7 +1115,7 @@ static int apply_p2m_changes(struct domain *d, } } - if ( op == ALLOCATE || op == INSERT ) + if ( op == INSERT ) { p2m->max_mapped_gfn = max(p2m->max_mapped_gfn, egfn); p2m->lowest_mapped_gfn = min(p2m->lowest_mapped_gfn, sgfn); @@ -1197,7 +1143,7 @@ out: spin_unlock(&p2m->lock); - if ( rc < 0 && ( op == INSERT || op == ALLOCATE ) && + if ( rc < 0 && ( op == INSERT ) && addr != start_gpaddr ) { BUG_ON(addr == end_gpaddr); @@ -1212,15 +1158,6 @@ out: return rc; } -int p2m_populate_ram(struct domain *d, - paddr_t start, - paddr_t end) -{ - return apply_p2m_changes(d, ALLOCATE, start, end, - 0, MATTR_MEM, 0, p2m_ram_rw, - d->arch.p2m.default_access); -} - int map_regions_rw_cache(struct domain *d, unsigned long start_gfn, unsigned long nr, diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h index 8a96e68..4752161 100644 --- a/xen/include/asm-arm/p2m.h +++ b/xen/include/asm-arm/p2m.h @@ -141,9 +141,6 @@ mfn_t p2m_lookup(struct domain *d, gfn_t gfn, p2m_type_t *t); /* Clean & invalidate caches corresponding to a region of guest address space */ int p2m_cache_flush(struct domain *d, gfn_t start, unsigned long nr); -/* Setup p2m RAM mapping for domain d from start-end. */ -int p2m_populate_ram(struct domain *d, paddr_t start, paddr_t end); - int map_regions_rw_cache(struct domain *d, unsigned long start_gfn, unsigned long nr_mfns,