From patchwork Wed Jun 1 20:54:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 69067 Delivered-To: patches@linaro.org Received: by 10.140.23.41 with SMTP id 38csp4839qgo; Wed, 1 Jun 2016 13:54:16 -0700 (PDT) X-Received: by 10.98.92.71 with SMTP id q68mr12871630pfb.138.1464814456682; Wed, 01 Jun 2016 13:54:16 -0700 (PDT) Return-Path: Received: from mail-pf0-x230.google.com (mail-pf0-x230.google.com. [2607:f8b0:400e:c00::230]) by mx.google.com with ESMTPS id g195si53211315pfb.182.2016.06.01.13.54.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jun 2016 13:54:16 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::230 as permitted sender) client-ip=2607:f8b0:400e:c00::230; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of john.stultz@linaro.org designates 2607:f8b0:400e:c00::230 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-pf0-x230.google.com with SMTP id b124so21922862pfb.0 for ; Wed, 01 Jun 2016 13:54:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=8ipTPmopKDI2fpXqV9vn7DFJnxpe6xnSYxNHwm1Z5Gw=; b=OhqyrIM6FN1rr0bxTRvgGjxMzM6l87cuibJRi1ShkWHKRVUZdQUC0iWLkc3w3hbsS5 f+w4fGBCRQrFUPxtcghgu/idJTdjk52O/LvKDKeHUOQ4QTBZJgFdSX/bjtebuQF/Eq+W zC/7xUlqC/74iOJGFhOBS7SY+RBFv+bR3HzRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8ipTPmopKDI2fpXqV9vn7DFJnxpe6xnSYxNHwm1Z5Gw=; b=kepq5xMUWMDv78ZGwVwH+c0N5qlFv/JX+C8I0MAOrtgxkHUwelmFWBMv/jRr1GwcQL 7PCXkrG72K01gfLeU+lIJWUvgmO4+qeWl5fxwB0S8u43XAoBiGyOfOsEGagRxEG+/i0+ bpEWVZvRDCZixHJx/i7uGKUyrfQ21TsI4wRnMZiFJu58f24l7NQo+je5BeYwksff9S2s x2sLbt5o8dpyX/gK6jsAu5Dugxj/VTzspaGQK7J4adZlZ3jv/mCswBxdwOGtn/3vc24k jh8HhvczF5zHu9g8pULmDqnMpDDGP2Qq5oiinrr8tXhvJ9FHkbX1tQjQKHR5JXXbPfEx gpWA== X-Gm-Message-State: ALyK8tJzarNFW8NYOcu6rzjOMdckZJe45GqDUUiX8yzAJRFbhx6l6m786OUpWWTJcehVucDAi6Y= X-Received: by 10.98.130.143 with SMTP id w137mr4244102pfd.44.1464814456325; Wed, 01 Jun 2016 13:54:16 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-73-67-244-238.hsd1.or.comcast.net. [73.67.244.238]) by smtp.gmail.com with ESMTPSA id 7sm50233325pfn.30.2016.06.01.13.54.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Jun 2016 13:54:15 -0700 (PDT) From: John Stultz To: Jorge Ramirez Ortiz Cc: John Stultz Subject: [PATCH 1/4] hi655x-pmic: Fixup issue with un-acked interrupts Date: Wed, 1 Jun 2016 13:54:07 -0700 Message-Id: <1464814450-14776-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 While trying to get the powerkey to funciton, I found when pressing the key, I would get infinitely repeating interrupts. After digging around a bit, it seems we didn't set the ack_base value for the regmap irqchip logic, so nothing was acking the interrupt. This patch adds the ack_base, which seems to make things work. Signed-off-by: John Stultz --- drivers/mfd/hi655x-pmic.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 05ddc78..68ab370 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -45,6 +45,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { .num_regs = 1, .num_irqs = ARRAY_SIZE(hi655x_irqs), .status_base = HI655X_IRQ_STAT_BASE, + .ack_base = HI655X_IRQ_STAT_BASE, .mask_base = HI655X_IRQ_MASK_BASE, };