From patchwork Tue May 24 10:20:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 68472 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp546506qge; Tue, 24 May 2016 03:22:07 -0700 (PDT) X-Received: by 10.31.99.133 with SMTP id x127mr1664458vkb.146.1464085327331; Tue, 24 May 2016 03:22:07 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id i68si1456946vkh.68.2016.05.24.03.22.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 May 2016 03:22:07 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b59SN-0007uM-Tw; Tue, 24 May 2016 10:20:59 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b59SM-0007u9-Fq for xen-devel@lists.xen.org; Tue, 24 May 2016 10:20:58 +0000 Received: from [85.158.143.35] by server-2.bemta-6.messagelabs.com id 17/57-09123-90B24475; Tue, 24 May 2016 10:20:57 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRWlGSWpSXmKPExsVysyfVTZdT2yX c4Og6foslHxezODB6HN39mymAMYo1My8pvyKBNaNn9wW2gnWCFX+mbWBpYPzF18XIxSEksIlR Yu2q7ywQzmlGicff17F1MXJysAloStz5/IkJxBYRkJa49vkyI0gRs8B3JomtB9aygiSEBawlL jVsZAGxWQRUJa5tPcIIYvMKuEhsPvsVrFlCQE7i5LHJYPWcAq4Sy+dOZAexhYBqXs+cyTqBkX sBI8MqRvXi1KKy1CJdI72kosz0jJLcxMwcXUMDM73c1OLixPTUnMSkYr3k/NxNjEAPMwDBDsZ lf50OMUpyMCmJ8hpouYQL8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuBlAckJFqWmp1akZeYAQw0m LcHBoyTC6wuS5i0uSMwtzkyHSJ1iVJQS572sCZQQAElklObBtcHC+xKjrJQwLyPQIUI8BalFu ZklqPKvGMU5GJWEec+CTOHJzCuBm/4KaDET0GL/L84gi0sSEVJSDYw79N4JT2DZMLks7Ialst sSJ/d1p/8wOkQtSr9+dylDmmR51+8r1SUnyw0++N/rP2m/tN7iROmez8s1dQXismtUE679Kjc RKbowIWZGrvX1Xf0L5lyYza4gtdbx89ew77uPtCW4HP2ma5bLpeq14KSi+ULe/M6gv+/c/z88 JcsoG8LseP6O1nIlluKMREMt5qLiRAC/1uV3agIAAA== X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-6.tower-21.messagelabs.com!1464085256!15599639!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 61304 invoked from network); 24 May 2016 10:20:57 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-6.tower-21.messagelabs.com with SMTP; 24 May 2016 10:20:57 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3BF2230B; Tue, 24 May 2016 03:21:12 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.215.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A3A103F5C4; Tue, 24 May 2016 03:20:47 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Tue, 24 May 2016 11:20:40 +0100 Message-Id: <1464085241-12929-2-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464085241-12929-1-git-send-email-julien.grall@arm.com> References: <1464085241-12929-1-git-send-email-julien.grall@arm.com> Cc: sstabellini@kernel.org, Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Jan Beulich , Doug Goldstein Subject: [Xen-devel] [for-4.8 1/2] xen/arm: Convert DEBUG_DT to Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" Convert device-tree debugging to 'Kconfig' as CONFIG_DEBUG_TREE_DEBUG. The option is not enabled by default because the output is very verbose. Signed-off-by: Julien Grall --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu Cc: Doug Goldstein --- xen/Kconfig.debug | 7 +++++++ xen/arch/arm/domain_build.c | 4 +--- xen/common/device_tree.c | 4 +--- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 303bf36..59be34d 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -55,6 +55,13 @@ config VERBOSE_DEBUG Guest output from HYPERVISOR_console_io and hypervisor parsing ELF images (dom0) is logged in the Xen ring buffer. +config DEVICE_TREE_DEBUG + bool "Device tree debug messages" + depends on HAS_DEVICE_TREE + ---help--- + Device tree parsing and DOM0 device tree building messages is + logged in the Xen ring buffer + endif # DEBUG || EXPERT endmenu diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 00dc07a..fb035ff 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -42,9 +42,7 @@ static void __init parse_dom0_mem(const char *s) } custom_param("dom0_mem", parse_dom0_mem); -//#define DEBUG_DT - -#ifdef DEBUG_DT +#ifdef CONFIG_DEVICE_TREE_DEBUG # define DPRINT(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) #else # define DPRINT(fmt, args...) do {} while ( 0 ) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 06a2837..0df2e4b 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -54,9 +54,7 @@ struct dt_alias_prop { static LIST_HEAD(aliases_lookup); -// #define DEBUG_DT - -#ifdef DEBUG_DT +#ifdef CONFIG_DEVICE_TREE_DEBUG # define dt_dprintk(fmt, args...) printk(XENLOG_DEBUG fmt, ##args) static void dt_dump_addr(const char *s, const __be32 *addr, int na) {