From patchwork Sat May 21 23:42:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Suthikulpanit, Suravee" X-Patchwork-Id: 68314 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp556406qge; Sat, 21 May 2016 16:44:12 -0700 (PDT) X-Received: by 10.31.162.203 with SMTP id l194mr5875125vke.116.1463874252136; Sat, 21 May 2016 16:44:12 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id v68si15548572vke.175.2016.05.21.16.44.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 May 2016 16:44:12 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@amdcloud.onmicrosoft.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4GXw-0001p9-Fi; Sat, 21 May 2016 23:43:04 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4GXv-0001om-IV for xen-devel@lists.xen.org; Sat, 21 May 2016 23:43:03 +0000 Received: from [193.109.254.147] by server-2.bemta-14.messagelabs.com id 5C/D4-03279-682F0475; Sat, 21 May 2016 23:43:02 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1WSa0hTYRzGe8/Ozo7lkeOW+G9q1CIqYSu7WIG YEVYfutIHK4g6q5Ob7CI7q5ZQ2E2pNC27kJYuvJRZYgrLMLRNsxuKWpG4zC0i1j6sJtHsQnXO zjR7Pz0vz+/5v88Lf1IiLyGUJGuzshYTY1ARU/HVy+vXqQtGM7IW1TZjK2qC1XgGWv+47Se2B e2U6k1as22PVNfjdWK5vTJbUVsfkY9uEmfQVBKnCyXQfuU8Ei6ILkHw0NGFCxc57UTQ2lktPY OiSIKeC7XD7TJBT6dzwPftqkyAJPRxBE9DJ/gESSrobXCj/ojA4DzvvuJDgqboDXDy1ltM0ED PhGfdZeGZUfRGCOQXEYKW88znFg8m8rHw7OoHXNASGsDp80nE7Cy4HwqFawN9CsGbX6NIDCfD yy4nIXQAfmiVF4lMCAOv4zIuhtfCk+8/pKIuJqDwtEaE+mXwx/WIEA0DdPdVIFEnQ+ProESEH iDw3KuL1EiEwuYeqWh8xOFNQ1HkvZfToKG4JXL5IoXWoVKZGAGoenEsEt8MI3UDkVKLIfDbLi 1Fs8snfbx80sftCLuN5nGs5SBrUa/UaC36bJ3VyOgN6pSUpRojy3FMNmtgtJxmr9nYjPhVmMK fVlRycY0LzSAxVRzFnl2VJY/Rmvcd1jGcbrflgIHlXGg+SdLFdxr6kBI3mU2sCihrMCNLHmth s1nbfr2B361xFMho1XSqSbApLpcxcvps0XqOlpD2MfddjHRdencXk4cnKeOpowJKC6jugGli0 PieDqAkpYJCfE15dC5rMeqt//t+FE8ilYI6LUyJ1pusE+/5+SoYX8WbEK5iZf5ZynxEmzo/13 7Qli4LevKCvRtswb4xeeK3hB0L0hSHPIOpTdsHKH+Oe94mU/8rRfp7bNAQv/BH47maOc6xa45 PHbF7q+2BvJiKC8z19FncGts0b2x/x75zu7iV/kyF1rF1JFBgT/Bmdg/bcqu+psY5Yrz1Q+qk mEpfZZq7wFxmTVWrcE7HpCRLLBzzFx9XAgeiAwAA X-Env-Sender: Suravee.Suthikulpanit@amd.com X-Msg-Ref: server-9.tower-27.messagelabs.com!1463874179!43010231!1 X-Originating-IP: [65.55.169.71] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21986 invoked from network); 21 May 2016 23:43:01 -0000 Received: from mail-bl2on0071.outbound.protection.outlook.com (HELO na01-bl2-obe.outbound.protection.outlook.com) (65.55.169.71) by server-9.tower-27.messagelabs.com with AES256-SHA256 encrypted SMTP; 21 May 2016 23:43:01 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DMiFPxoufFFkbtTlqmdrcyuBM1432o/6630aVBBzzUc=; b=oOcgTVo8Lj2rAi2rMt0qxcKp2Z9lVnG996S3JiHwk3hu00C04p4r+h+jxGXU7ZCC9oJLiYpgLnC/v7svqXxa+uoWmKeEDMQv5oN6+aWhUilB2repTo6O890vvvTLSSKU9CANfnDkx8L+SJRuv319Ed3XvBulaocpvFMscuX24tE= Received: from ssuthiku-cz-dev.amd.com (165.204.77.1) by CY1PR12MB0444.namprd12.prod.outlook.com (10.163.91.22) with Microsoft SMTP Server (TLS) id 15.1.501.7; Sat, 21 May 2016 23:42:52 +0000 From: To: , , , Date: Sat, 21 May 2016 18:42:31 -0500 Message-ID: <1463874151-6950-4-git-send-email-suravee.suthikulpanit@amd.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1463874151-6950-1-git-send-email-suravee.suthikulpanit@amd.com> References: <1463874151-6950-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR11CA0042.namprd11.prod.outlook.com (10.141.240.52) To CY1PR12MB0444.namprd12.prod.outlook.com (10.163.91.22) X-MS-Office365-Filtering-Correlation-Id: 84f84639-e7e8-4255-1dcd-08d381d1a375 X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0444; 2:kikYX76zPX3RZ/w6EgiuyYzBncXhfgCZjRQVYVp19wKibEGt5+HVZW1LH91mcctEVGWxMsmAPYUpKouuH82cZwdFtMGjjdOuIXf7ii66drEQu8RTIphOyvg3A6vp2hhk0NF8qGM62oZCXu5yLt2ciKnVHcKKGg7skZyFqxT2/O2fzzG2Sd0NyN+YAYx2g8Hi; 3:D1v/fie93kJ/Lb4g1uALyqfJ9ld7OB5BHAJyPGqvgi0xG2Y5B8UcESY14dfef/sPNkCQzoDagZ6G/nMu4imhgEyRvWZ5a1KQlkcVRh+3vvm2fLewSSJx4mEFuG1PS+CE X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0444; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0444; 25:ERsqmK4Jhx6xAuC1rj88R7WRJ4g0Q1NUwBkPoRa2agkiZ7knVJb6ZkPsstN6Ll4GFjGfYL79ccpo8ZFNJ8CKgpd+h/iwMXNdhqED+mFfSV0hTFWqrOccpuMnJRLRHtVYF5SHI+mCxbzPlotcZN5Bs7RH0RXRjneZfrMyNyhquje2vuEe4TFVmI5KKdsPGtkI2xRK4A8VtS+k1UMMfTJL8Pc98DYj8Qqqf/Mwt6W3Vx+fs6Sno6x1gRAtIrKV9XqqRwenCDUqeMWUdGQztbmBh18/QvesXoyR3l8fLGC8UxGC0ABqa51nphNrMNEACEDs7KhwtsQ7kuqIrLm+LqbJBc5w0Sbx2e12a30PPHDJwaxkI+Ms3cilzG69+97b44c3CIiF3t5BH+yYZiFBuCevHm8TUGDEg6eCbedXkgkdGo8mzsJniva7Y05HyDx0vmwjY7EC5MEHOrAcf45AckRSmWiB6DeTL6Bjll5hNmybkpnAlJtrLNcUzKoY+mgikRaOK/VbxFpmlDOLZtOZJ4kn9dCmc3B93daz3mQtdeIC3FnGcE+tsIueZnpEXbUs+ptXXMCQQ+7qJTAO2iFIyk0KW1jBd64K1hrbZu8oQfBIBbKeDU4ZzgBngSH1CSOA449Vjx9fdI07IvZuYSTZEiGlt+Gckf/nrKbSWys94eGQAgvaZHVuEkbMuYIchPjgSLXczICBa8btj/1Rs8kXska3Sw== X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0444; 20:pGi72ovv7j3TPpyzUt0WaXeI2hvlBS9igrw8Cl3Jv9T/lL0GsOit5pPav6NxrwIP96ZKSaMH0Mff4jxm8o/GCc9Zk5feMPuOyuMeM/PId4N2tymAp2tp/XM1Lhe/e3f0XdDolw84ujh0O1SJWL/ax0b6HTONndZKdwnAze5qSe4jkrerJYOn3rEotkzR3VUyAu1IQ8njUq6bjjhxWi3VeFmdhfap1SBshdZQGePshBI3grzkKz7DSjQkAAmTVvMhbIFE3uns09E0aJMN02hZ/Km91KcmWvw7gI/1vXl333KXBbL+Kz4EYdUyeIQiiiI4PlpDcEBkuS7KXnCxZegd42gJ/DfDQE5ppHWv6fIt0KJj6/w1PcerXQ/wlmSyc05nUjV6dIE8EstPzuVyvqf2rDGSwCOwWQ48PtWeaLX6gpv9pKRBo3OtIotMaQbz286Qg5qBbQR3TAlbnhVS6dIkGHOgzg0LNF24WHFGILdNvAikeaFn/9Q2xe/DgkYYIZXl; 4:OQlAwopnH0R9BIG8WEETcjCs/cIjizCYMWEi7v1r8RWaFUcUBsVP8XR4+hx0aZKfDGkUcenrnjIDBikFcZP6CYU201JHvn5o7WA6yb/z6dh5huoVjVgYXlS4gQ0m1pomvmrUGq35Y4lEsjDZgj7fi4vYuYt27FvJnas1rmy+Vi0LDBooskFTo23dzLcbQwNzncr4EEdvAF1MNP6gcup5xaShawUiX5ueCZ1YupPcgRHRpk0bfTbsEPfajE6SQ8byZdjJgVQhq4zA41AEl2Bcvsw6YlvZ3FZro/XWLkxfyHX8z7o9Fh9zU9UnxJC71rhesgKI2Zn0zKEJpC7h2nPcdzsILYPPz8NvppxxUUOItXZC8ZzstL9KVjIVS/xnZMa8oHI8QnsdddUJh5Q4FaOWvA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:CY1PR12MB0444; BCL:0; PCL:0; RULEID:; SRVR:CY1PR12MB0444; X-Forefront-PRVS: 09497C15EB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6009001)(53416004)(47776003)(50226002)(92566002)(86362001)(76176999)(81166006)(2906002)(586003)(50986999)(8676002)(33646002)(5004730100002)(48376002)(4326007)(2950100001)(3846002)(19580405001)(189998001)(5003940100001)(19580395003)(50466002)(5008740100001)(2876002)(229853001)(2201001)(86152002)(8666003)(77096005)(5001770100001)(36756003)(42186005)(66066001)(6116002)(7059030)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0444; H:ssuthiku-cz-dev.amd.com; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR12MB0444; 23:Xd7t+QbuYAu3Qk9w57stlaCX/68EXtWgpQ80w8ZUU?= =?us-ascii?Q?h7GHV0SqgbEZ7+eOzWehm9yLy7Vb25Avob0YbOyBVoPJk79eQIV4fgJh9/FZ?= =?us-ascii?Q?OCp4iUVM0PGmxk2/bcLLYb2lvMIvG6eFrIUm7k5jWbEF/C4eIYZemIiKYdyv?= =?us-ascii?Q?uOUTg44sVulJbIJHJPOxzpGnO4a5wfMbIfGsHoRXBZpnIYgo48cULvGNvWSu?= =?us-ascii?Q?TZNTzdUBQ+KV9SA+Hl/s7W+jFCvLemFZbaFfXpyyd5jyZONYKwW6Gfu3k4YD?= =?us-ascii?Q?SenWzBR1zgC2G3Ejfcwwb2Omq1Rdm7L2MNtcKSNVj47GP/Tfvn8zOzxG/VfM?= =?us-ascii?Q?cOOm2a+oblYln37VGx9niZq5xAn6fmsnRv+VwGqaViI92wTIqtj3dszts7aQ?= =?us-ascii?Q?BKePEocUxfKWpgxAIciJL5zJ6sRmAkGnR6RTS+l/kVd2ANkFNI58O8DaC6uP?= =?us-ascii?Q?yIaHv6P5vVzv47chl7fpLmvuLsmEdfCr6z0kkwIUNeMtm9+PDp/dePJclZSj?= =?us-ascii?Q?KcJggpYCt2+uf6lEuLkQ+kSEI20fBMW0WaHhDLYWxoEu51aVwFgw/yk6GSky?= =?us-ascii?Q?Ca8ApmXhJSeqNgq0vlGzwtr7Lsd/UTJfPJzdgmxnJObMPX3GIpAGAVm1+gV6?= =?us-ascii?Q?0jY8E0ILb3edeJhHQ3hcq1o4rtlJMATQCoL1Rx5gI2gn/Ir4ZKzXC6EDBdQs?= =?us-ascii?Q?n6FuZFyOmcN7HyhOYInehmBO5NwtB+K+5w9yIOftdSXlBRTTOQyYgPx6Kc0f?= =?us-ascii?Q?p2zw2Owoko/aGTUgA6/HK2Yf8an4F7FI1x/piaTLP0Wu09OgWeIVcxaiV8fV?= =?us-ascii?Q?g702A6Q5nxZuxKUxEDwoV2/qz27Z2IL5/8zChVXVY+EF6ZV+ZI3sVfusr4FA?= =?us-ascii?Q?ZppCYIPX8R1NnsIQn1YRYloeKrBWdLuOLVta0rymMpXBXfAXc54SuZ2ZF9Rm?= =?us-ascii?Q?ZkWb3QcWZxkYD1vdZ5eGfLwJ0Wz+qUnj+baSN4VK4elKz6WKfYsvcp3F5CWg?= =?us-ascii?Q?4rupq6zDfsIUb/LJwDygIsl8NmXVgMiuuVNdIFzRbj1HGDgbn1FEha0IZp+r?= =?us-ascii?Q?NRMVO8CpuVBsoQKIjhaQHXJc1AszDrGPfU7va3vbFWv/jXCrQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0444; 5:A0p5trKMjBIIYk89bUOwIDFYEoWl0yBmzgPjEYpvL+d2u4T+DlUxLlEEbLQjkYI/OkFPBw6MrPqORjKBwkoxB/SBcn0rmRWVfVB3jvn/HpUUKQfg6cEr2GTr8Bf6AKADEk8+T72e0RcqZ69S+Nv2ww==; 24:VdCDvCENlfcFmzW7UdBFxAVkrOJ4Axd4tti+NQxZegyUQodqkcMe3mJOuHRDhoCvkXQu1prHnCHjSKXGu2qgrAD5yXdG2G81+5ckHzXcm0c=; 7:jiSbOWuVhUZkxiykJZ6DJBr3z7yt7AxM2lMk0FAK1S7l36fAG31lqmz0V3goJxhcPYVxJgQypDsPXvi0C3mAQ9poYLZC3Ix3scY7EyfN1hVkB/X7oJbC+4v+KNx52EiH3uIo04rPemfWv6v0s7P6bP3xacUL3yYTM9W+Vf4HUAg=; 20:ulaj9A89tbCH1Z4JejHBsB9/wlFElzucxTRKDDb82mHFBgcgVQprHIcEB8dW+AVSPeQRnKqNsmSPhnE1XB1i9TQJ4L9X/zTP71494x7ddtCxHKL4o/iePjY+hU+nFnt7ixCyzEdYJ7MhhM84F8lKOQ77ry9AJnDvEPXUuL8I/VWCOlO4M7N7FizHwErdP5B3lVZbZgrk1GkCio4fdPFtA7ReEGBx2puZdPiVw9PvmkhHCWnUlqkIUpZb7V6iojeb X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2016 23:42:52.0972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0444 Cc: keir@xen.org, Suravee Suthikulapanit Subject: [Xen-devel] [PATCH v3 3/3] AMD IOMMU: Check io_handler before registering mmio handler X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" From: Suravee Suthikulpanit guest_iommu_init tries to register mmio handler before HVM domain is initialized. This cause registration to silently failing. This patch adds a sanitiy check and puts out error message. Signed-off-by: Suravee Suthikulapanit --- xen/drivers/passthrough/amd/iommu_guest.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c index f96fbf4..49f00de 100644 --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -890,6 +890,12 @@ int guest_iommu_init(struct domain* d) !has_viommu(d) ) return 0; + if ( d->arch.hvm_domain.io_handler == NULL ) + { + AMD_IOMMU_DEBUG("Error: uninitalized hvm io handler\n"); + return 1; + } + iommu = xzalloc(struct guest_iommu); if ( !iommu ) {