From patchwork Sat May 21 23:42:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Suthikulpanit, Suravee" X-Patchwork-Id: 68313 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp556404qge; Sat, 21 May 2016 16:44:09 -0700 (PDT) X-Received: by 10.159.40.37 with SMTP id c34mr5173318uac.89.1463874249035; Sat, 21 May 2016 16:44:09 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id n64si15544202vkg.110.2016.05.21.16.44.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 May 2016 16:44:09 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@amdcloud.onmicrosoft.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4GXo-0001lK-09; Sat, 21 May 2016 23:42:56 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4GXm-0001kz-Iv for xen-devel@lists.xen.org; Sat, 21 May 2016 23:42:54 +0000 Received: from [85.158.139.211] by server-6.bemta-5.messagelabs.com id 0A/0B-09573-D72F0475; Sat, 21 May 2016 23:42:53 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA1VSbUhTYRT2vbu7XsXJdX7spLNklJigaaKGVM6 CUkjtC4VK6lq3bbEP3Z2yoGIaIZhlJIaKpWQtspQyaYkiaZpoGeYHEmIZRdkUS3/42aJ7d6fZ ++s553mec54XDimSXiYCScZsYox6WqsgPPGk+IcpERfnlJlRi33kjnuzdbgSJXe3rmAH0TGxR p9tMJ8Sq783N6OcQcJsc5QRFjQsLkaeJE4ViWBsvs5ZIKoUQdvzLpwvpFQHgpLeRqIYeZAEtQ Xuj7e789iPOgeT85XuvEhEFSCYrRjAeMKX2gtF5UNOjHOGmiczIh5LqAMwPmxzYqA2Qu/rMjG PPahUmLGUOBdIOc3PZxOYoPeB3sqvOI9FFEDH5KTLGwK2hQWCXwzUFQSjv+eQYA6Hoa4OjiA5 IhUcA8mC5gEBtx1vXeZ90LO0LBZwizu8awwSsBYqrV9c/XBoHJkVCeYWBBNPrS6zHIqa+sUCc QeHhQqrqxj2hL75ZVwofonh01QBEiwANW8KREKmdJhyxAvt7TDzp9a1TgnfXk5jN1BI1bpvV6 37di3C6lEYyxjzGWNEdGxktlGjUpt0tEYbER0VG6ljWJZWMVo6m408bdA1Ie4U3Lj3AllsKZ1 oA4kp/CXM1cRMqXe24cx5Nc2qTxrztAzbieQkqQCJaVaZKfUxMirGfFaj5e5plQbSS+EnsfO0 hM2hdaxGJVB9KIasXRxrwMjO8o8NmBTXG/RMoExyiZdSvFSdp18btHqbgyg40FeCuGhSrxzGq NOY/uftSEYiha+ki5/ipdGb1vbZuSgYF+VzkDOKif5HBVoQaY9J87uukGVstvZnpf8oP+SW5i 2/uXg7b6Y3H1eGKeQj4txo3+b8GnlC9fs9/jt3Vyd3mRwW2/HQ3G39haMlrbK7SycSWuLkW91 D3R4t5ZpfaS/YLUkhhHW/7Aj9wc8joG3akFh6OPZxXH3GtaO32j2yClU9Ad1SWepKQPCuTQqc VdPR4SIjS/8FlAexu5YDAAA= X-Env-Sender: Suravee.Suthikulpanit@amd.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1463874171!40621098!1 X-Originating-IP: [65.55.169.73] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8881 invoked from network); 21 May 2016 23:42:52 -0000 Received: from mail-bl2on0073.outbound.protection.outlook.com (HELO na01-bl2-obe.outbound.protection.outlook.com) (65.55.169.73) by server-6.tower-206.messagelabs.com with AES256-SHA256 encrypted SMTP; 21 May 2016 23:42:52 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HBZ94YKOUjZsRyLhtx4FVzYghEAYarIvZmOdaDYIlgc=; b=tfJdF6i0nL7ITMf3quqd9UPj5nYGS8noa6tpI2Y2xXaeOUI7Pu6lqKL6mHF/F3FGtbw9HLC2NkSxlfrTBw789Oc8ORej34iGs5vYepSnzaKaM4xsmjme3BB6toDOxkjsLgJb4gI/hC5V/7L4c6C6voGKcAxRCCoIc83c138IN+M= Received: from ssuthiku-cz-dev.amd.com (165.204.77.1) by CY1PR12MB0444.namprd12.prod.outlook.com (10.163.91.22) with Microsoft SMTP Server (TLS) id 15.1.501.7; Sat, 21 May 2016 23:42:44 +0000 From: To: , , , Date: Sat, 21 May 2016 18:42:29 -0500 Message-ID: <1463874151-6950-2-git-send-email-suravee.suthikulpanit@amd.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1463874151-6950-1-git-send-email-suravee.suthikulpanit@amd.com> References: <1463874151-6950-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR11CA0042.namprd11.prod.outlook.com (10.141.240.52) To CY1PR12MB0444.namprd12.prod.outlook.com (10.163.91.22) X-MS-Office365-Filtering-Correlation-Id: 663ba3cc-4cec-4946-1c98-08d381d19f12 X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0444; 2:bblynyAkhfUi8XMIsgAB9TOkoLWeC4yqgqR4edkDvhN3SbqHeglR9zfuK8e10f1hx1Quims4PLTGp6E/9tQc415j9e0xwNGvCnCxTfFKVotX1MJ8ZUDt5jdeGpAtyldAHnWDhkszTpNoJ1G58E+V5L0cKXgBt7TvBTo91NlfnGOT9xKI7qrVbPnsRVsFK+lq; 3:NtZRfPI0Sq/IueCkwdqec3V4WwCRrjA0XFGWFFFNiJKgTEfIPSI/Wo1n+nXTcjl+0Z7C+dSMLT6zqmElJjuRTuurwioELNt0K+fT6VS0d6cqb0UrReTULPZyc7lqmuqH; 25:pJMHmhJZdv3C/jjCkwHlh92A4a91GGnt7s2hgKNdFQ0CgjpHSwzTZ8N/IFoi+phH5ohjCfSB4O0Q1JMaRswRGSFxm8oQ2WHN1ux8XP+6zYjnb2lHEFFXXq+mZkwkAOkyNj19MUU1fK1hbKPZYNLa7PmlO13f626yrFb8BU/XK71XJteo+9lOEqF+W8OC+1YIaP2W3HpYDXrC5nekJTZNozMT90csm7e/RipglxIC1wqLxocH+XKbxGYSPWjtDIp+8/TAS720f9tWETdHTcRlYgJrr/NWRqYSWR7zoAKlwH16/00pfkGX18PoFBYb9QGc8TMexgvNudRHPZhd9gZ37O7zgqEpVPGlhuLMIL4415iCtB+2DZJhdDSennp+hfYGomdHT8K/IuxMUXwYPVOGT4lGVkA05vM+nDC34X98PUo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0444; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0444; 20:litSDekZsvCJPm41+F+7zE7vdWywWqa/C6qKcDmQnvyLyfvfKM4fAxntc3OVsyDajeFQBMfWpk4mWI0NSEcVqczzCJHdHAZMbd5v+hXGtFjetP6hW/jsAfmcnV+dmH3L+E4QLyOq2ao4UL9XJ1jwHTnwJ60qjOJblfcc2TmAfG7dEXIqvQ47p9MDVuy6L9bJBWKMhbQTkRb67R7kjh4zymNoyd6ZhuHQhDR8nm0S/z4Q9aMcNO2X0jMhf5rYXclTGpHAnzlitvGWxZTizp9i1B1GeK94lvpXJjfxgBk3/F3/tNQutiovhvd4eL1C7bC5PQ0IaXOa8/8nYckt+lxbDenTtPHskYsHrXDzVpByovjgEy7V7DuT2NX31a+PYVXdUEOvDASzeVZq3ecE/hkd49E/ZBP80Vkz50JsNv3dVLOJYlarn5UAp2981eGAwtD74XImWGi0uFWT05WNexAvOmxlbJH8fQX8rCskEnNA2RnHkzvg/0j9wEiH/SZ8O7Ij; 4:zC7wCRZPkWbpAk3ZjRfiJohJcc57TrIi/IEgTLLOoS7rz/IlPUCK42GQvPpQpd2V/FBzWNDinvzeYNzcowTlcX2v5vEoP3CVrVKH2roafgmUuwn4Y9djx2qm10iyEm0XANNk4aU+iSp71BcVIWIo6Kr/LpOrpFKd/I7DQftQo6aaLOjLcWHJb9vXiRhJrcNiIHkdkNcujjuRDG17Wjrhm8i4oMfljIKWRVu6yLw4k2U50d6kMBhBU7/cL2EWNyLEtP4EQ5mQ2f7VACZwCL8rYszitQj8VwNFHUSb5KvU1kka5Z8z43HamhWVh79Y+byEC50RjWLkYZmciBnVojRYSQhpzrIGK8fwvsTHaFTlEoCBeETB+/Br9dq7+gWv6UlV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:CY1PR12MB0444; BCL:0; PCL:0; RULEID:; SRVR:CY1PR12MB0444; X-Forefront-PRVS: 09497C15EB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(53416004)(47776003)(50226002)(92566002)(86362001)(76176999)(81166006)(2906002)(586003)(50986999)(8676002)(33646002)(5004730100002)(48376002)(4326007)(2950100001)(3846002)(19580405001)(189998001)(5003940100001)(19580395003)(50466002)(5008740100001)(2876002)(229853001)(2201001)(86152002)(8666003)(77096005)(5001770100001)(36756003)(42186005)(66066001)(6116002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0444; H:ssuthiku-cz-dev.amd.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR12MB0444; 23:YPai4eXrUrwTmRRZ1hUT0R4lkzMMnInWvKO5fIKqR?= =?us-ascii?Q?7rsLG9S0EttAxwjxYj7NDh3jMgn+SkWT6//pE6FVLOFDB5cB7BqP5C7o+Z5E?= =?us-ascii?Q?4WP/6MeifvVtBjIgKp7rSCX/OxPKJBZX8tTfNBhKqZ+pEXuhMPhoQKbzpWZK?= =?us-ascii?Q?nxO4S04+ZzuhtHv4Bk6+G0mKxq0bxKqpwxJeomha4HdR50NTr9ICJ+d3S50O?= =?us-ascii?Q?VesLqET7y5Niv64UOPOCKvJpmL9n+1Hmkbd9iOUD27FBr5FTLO+GGvqJp8eY?= =?us-ascii?Q?m8e3ivsB8S8hiuHYRvzE9ws8/D4p12eJCkp6ZEcLGPbRRV0DPuzZpLaY4npd?= =?us-ascii?Q?F4dCWc3EcnlQzJFTGagAA5p84z/WxZviKG/DaiiR59LX9j/xIAZ9kQtb0X3Y?= =?us-ascii?Q?RKPN04lhDtp/33jh1rq0cvumly2bDy3oV9ofJEqxxDRjOx2Uh8tD3xldxkPV?= =?us-ascii?Q?W+Q0s9LwY5tm6TTab8d2xCrL5k7gxHCu/dpQhv6AIleybBxuMpsEAF22C1xk?= =?us-ascii?Q?FVRkh7fdnQEmQOM2SkPglpqQs6b6WGeWfXbGbnHurnNnSQPW3InI7qWBPAxJ?= =?us-ascii?Q?p9C8XxkwirYpTXl96P3mSMTW2eLU3tyq1GcbaZGuYG7KEowRy9L8JRfLEREx?= =?us-ascii?Q?tmdo/6aavBYS9cDuGNSb2fl/58hezGpNK7PJGqQ+AwpvoK+mLP7LRgIukN2n?= =?us-ascii?Q?hSCWoJw6rsXak8YWQsA6Xssuf4MarlV7u1KVm4bld4vrZby9ncIkwMNcFopm?= =?us-ascii?Q?fg+uLUOS6dXQjgSdapTHE4JRDFE9DLmlrYXL2UlA/7oscantj3GpXsAdnQoP?= =?us-ascii?Q?2RvH1390TA4PtVQv3yLQDIj/j3Oed5JyzWvMsuLX4epqWOK+Ckh2vVsJYzLE?= =?us-ascii?Q?HaCwW8BMyVvLCEwWAkos0Lin49KY9xOmVV6DaCbpT0gXqIB2Itn9AZdTBE4S?= =?us-ascii?Q?8FzoEaivKDkyTK929VKTsOIAhkMCOQJElxVEokpipnhdHyx7lKsAmpyw767d?= =?us-ascii?Q?8w=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0444; 5:sqbUODuPkNb1huEKMkt3pmZqZX/M57O9cxHqbxAoCb8ces8ADD0fL8xR4r7IEnSwgHovFN6FMEzmU/PFj40PCrPf/fdw5z2CR999e/sjhKRyykwVq6szQyObyNeuWeeSlEJYJgP1+smMIbKZoECv3w==; 24:+6gnycvhxX42yu17NjUKyxqOaopJmFpytFaRk4MW0M9JGo9J7+pxGXthELz9IPSB3FszRsWvECulNbimBhCg1HfuYuOEj51EO4GC2gXkx3A=; 7:FqhWhTFnVUPqvrdkMfT1StYZoU+AFYnVuiePoFAScwpa3MowvKuScRZiWwmpru/svOMz9CRP/wG4dsA8MO4m/GiLZdJh8hUCvQ8qAMb4+wCx1uRlo0FoTQEHppc9Aa4vBO0uiwnkeM2FPT+sEICuHMrsBE0RrCmWDxnliu3pWRg=; 20:zTN0JAxHAoMfZDCMvZq14Lwq+908hMxb3Dl00OFvaPH6ccUJ/xHVXSeWCEPRZ9FuisHibjbrDl8hpQ1VmFLrDX1ss4ud1JsWHOK5fVTQ2nE9qz4c+i0qLtUOTreae6WBXTUdZ/m+JgSP5UyJiM48t7hkEMRAm68BubnNo5U7JUEqi7wM9MAdqNy+kJhzkjkEYqlxhpiumA0NU625xJ1JD6R85yZKtmirf1ZaQOpH8yeR6oQMzpn+YLs2ELO/CVkO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2016 23:42:44.7375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0444 Cc: keir@xen.org, Suravee Suthikulpanit Subject: [Xen-devel] [PATCH v3 1/3] x86/hvm: Add check when register io handler X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" From: Suravee Suthikulpanit At the time of registering HVM I/O handler, the HVM domain might not have been initialized, which means the hvm_domain.io_handler would be NULL. In the hvm_next_io_handler(), this should be asserted. Signed-off-by: Suravee Suthikulpanit --- xen/arch/x86/hvm/intercept.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c index fc757d0..2f8d57f 100644 --- a/xen/arch/x86/hvm/intercept.c +++ b/xen/arch/x86/hvm/intercept.c @@ -258,6 +258,8 @@ struct hvm_io_handler *hvm_next_io_handler(struct domain *d) { unsigned int i = d->arch.hvm_domain.io_handler_count++; + ASSERT( d->arch.hvm_domain.io_handler ); + if ( i == NR_IO_HANDLERS ) { domain_crash(d);