From patchwork Thu Apr 7 10:59:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 65289 Delivered-To: patch@linaro.org Received: by 10.112.43.237 with SMTP id z13csp3309lbl; Thu, 7 Apr 2016 04:01:31 -0700 (PDT) X-Received: by 10.31.32.83 with SMTP id g80mr857521vkg.126.1460026887968; Thu, 07 Apr 2016 04:01:27 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id 70si1589970uae.89.2016.04.07.04.01.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Apr 2016 04:01:27 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ao7fX-0003uR-0o; Thu, 07 Apr 2016 11:00:11 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ao7fV-0003eM-M6 for xen-devel@lists.xen.org; Thu, 07 Apr 2016 11:00:09 +0000 Received: from [193.109.254.147] by server-4.bemta-14.messagelabs.com id 7C/59-03301-4BD36075; Thu, 07 Apr 2016 11:00:04 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRWlGSWpSXmKPExsVysyfVTXeLLVu 4weV7shZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8by+6/ZCxZzVPw4cpGpgfE1WxcjF4eQwCZG icN3prJAOKcZJX79PsbexcjJwSagKXHn8ycmEFtEQFri2ufLjCA2s0CUxPpN3awgtrBAvMSq3 /+Amjk4WARUJWZMEQMJ8wq4SBz4vA+sVUJATuLkscmsICWcAq4Sn+4FgISFgEpeNc5kmcDIvY CRYRWjRnFqUVlqka6hgV5SUWZ6RkluYmaOrqGhiV5uanFxYnpqTmJSsV5yfu4mRqB3GYBgB+O 5Zc6HGCU5mJREec9KsYUL8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuCdZAOUEyxKTU+tSMvMAYYZ TFqCg0dJhPcfSJq3uCAxtzgzHSJ1ilFRSpx3P0hCACSRUZoH1wYL7UuMslLCvIxAhwjxFKQW5 WaWoMq/YhTnYFQS5j0NMoUnM68EbvoroMVMQIsv8IMtLklESEk1MHac3/i77e2li1kRKxdw7H oT0n+Uz0Vf64DoxIuzlji8Fwt90npMzWCVmJXS0iUnnGIX3/WycuTkvO0W6d7OtUbZK3zhq0/ Sf7lDf83W505JSJ09f8m0tpWWqa+zG2MaimcXsXK5/eSwcl6gP+9KyMa4dfaNLM+K95+bWjQ5 4J7shc5SteRFdUosxRmJhlrMRcWJAKTEP49oAgAA X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-16.tower-27.messagelabs.com!1460026803!36129751!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31685 invoked from network); 7 Apr 2016 11:00:03 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-16.tower-27.messagelabs.com with SMTP; 7 Apr 2016 11:00:03 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A93C73EF; Thu, 7 Apr 2016 03:58:51 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.215.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E0C53F25E; Thu, 7 Apr 2016 04:00:01 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Thu, 7 Apr 2016 11:59:52 +0100 Message-Id: <1460026796-10899-2-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1460026796-10899-1-git-send-email-julien.grall@arm.com> References: <1460026796-10899-1-git-send-email-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org, shannon.zhao@linaro.org Subject: [Xen-devel] [for-4.7 1/5] drivers/pl011: ACPI: The interrupt should always be high level triggered X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" The SPCR does not specify if the interrupt is edge or level triggered. So the configuration needs to be hardcoded in the code. Based on the PL011 TRM (see 2.2.8 in ARM DDI 0183G), the interrupt generated will be active high. This wording implies the interrupt should be high level triggered. Note that a rising edge triggered interrupt would be described as "high going edge". Signed-off-by: Julien Grall --- xen/drivers/char/pl011.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index fa22edf..88d8488 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -327,7 +327,7 @@ static int __init pl011_acpi_uart_init(const void *data) } /* trigger/polarity information is not available in spcr */ - irq_set_type(spcr->interrupt, IRQ_TYPE_EDGE_BOTH); + irq_set_type(spcr->interrupt, IRQ_TYPE_LEVEL_MASK); res = pl011_uart_init(spcr->interrupt, spcr->serial_port.address, PAGE_SIZE);