| Message ID | 9b93cc79d7cc07ee77808150ca76c9d243c8ca60.1603944740.git.pavana.sharma@digi.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for mv88e6393x family of Marvell | expand |
On Thu, 29 Oct 2020 15:42:00 +1000 Pavana Sharma <pavana.sharma@digi.com> wrote: > Add new mode supported by MV88E6393 family. > This commit message isn't ideal. It infers that the Amethyst is first such device to implement this mode, which is not true. The 5gbase-r mode is supported by various other hardware, for example Marvell's 88X3310 PHY. Just say: Add 5gbase-r PHY interface mode. > PHY_INTERFACE_MODE_2500BASEX, > PHY_INTERFACE_MODE_RXAUI, > PHY_INTERFACE_MODE_XAUI, > + PHY_INTERFACE_MODE_5GBASER, > /* 10GBASE-R, XFI, SFI - single lane 10G Serdes */ > PHY_INTERFACE_MODE_10GBASER, > PHY_INTERFACE_MODE_USXGMII, The position is IMO out of order. RXAUI and XAUI are both 10G modes, so 5gbase-r should be between 2500base-x and rxaui. > @@ -187,6 +188,8 @@ static inline const char *phy_modes(phy_interface_t interface) > return "rxaui"; > case PHY_INTERFACE_MODE_XAUI: > return "xaui"; > + case PHY_INTERFACE_MODE_5GBASER: > + return "5gbase-r"; > case PHY_INTERFACE_MODE_10GBASER: > return "10gbase-r"; > case PHY_INTERFACE_MODE_USXGMII: Here as well.
On Thu, Oct 29, 2020 at 03:42:00PM +1000, Pavana Sharma wrote:
> Add new mode supported by MV88E6393 family.
Hi Pavana
I asked you to add kerneldoc for this new value, but you have not
added it. Please compile your code with W=1, and you should see the
warning.
Andrew
diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea..9de7c57cfd38 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -107,6 +107,7 @@ typedef enum { PHY_INTERFACE_MODE_2500BASEX, PHY_INTERFACE_MODE_RXAUI, PHY_INTERFACE_MODE_XAUI, + PHY_INTERFACE_MODE_5GBASER, /* 10GBASE-R, XFI, SFI - single lane 10G Serdes */ PHY_INTERFACE_MODE_10GBASER, PHY_INTERFACE_MODE_USXGMII, @@ -187,6 +188,8 @@ static inline const char *phy_modes(phy_interface_t interface) return "rxaui"; case PHY_INTERFACE_MODE_XAUI: return "xaui"; + case PHY_INTERFACE_MODE_5GBASER: + return "5gbase-r"; case PHY_INTERFACE_MODE_10GBASER: return "10gbase-r"; case PHY_INTERFACE_MODE_USXGMII:
Add new mode supported by MV88E6393 family. Signed-off-by: Pavana Sharma <pavana.sharma@digi.com> --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+)