| Message ID | 79d341b6be03e9ffbe489d7110348357971a5fc8.1602590106.git.mchehab+huawei@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | None | expand |
On 10/13/2020 5:14 AM, Mauro Carvalho Chehab wrote: > Changeset 410d06879c01 ("ice: add the DDP Track ID to devlink info") > added description for a new devlink field, but forgot to add > one of its columns, causing it to break: > > .../Documentation/networking/devlink/ice.rst:15: WARNING: Error parsing content block for the "list-table" directive: uniform two-level bullet list expected, but row 11 does not contain the same number of items as row 1 (3 vs 4). > > .. list-table:: devlink info versions implemented > :widths: 5 5 5 90 > ... > * - ``fw.app.bundle_id`` > - 0xc0000001 > - Unique identifier for the DDP package loaded in the device. Also > referred to as the DDP Track ID. Can be used to uniquely identify > the specific DDP package. > > Add the type field to the ``fw.app.bundle_id`` row. > > Fixes: 410d06879c01 ("ice: add the DDP Track ID to devlink info") > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Yep, looks correct. Thanks for the fix! Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > --- > Documentation/networking/devlink/ice.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/networking/devlink/ice.rst b/Documentation/networking/devlink/ice.rst > index b165181d5d4d..a432dc419fa4 100644 > --- a/Documentation/networking/devlink/ice.rst > +++ b/Documentation/networking/devlink/ice.rst > @@ -70,6 +70,7 @@ The ``ice`` driver reports the following versions > that both the name (as reported by ``fw.app.name``) and version are > required to uniquely identify the package. > * - ``fw.app.bundle_id`` > + - running > - 0xc0000001 > - Unique identifier for the DDP package loaded in the device. Also > referred to as the DDP Track ID. Can be used to uniquely identify >
diff --git a/Documentation/networking/devlink/ice.rst b/Documentation/networking/devlink/ice.rst index b165181d5d4d..a432dc419fa4 100644 --- a/Documentation/networking/devlink/ice.rst +++ b/Documentation/networking/devlink/ice.rst @@ -70,6 +70,7 @@ The ``ice`` driver reports the following versions that both the name (as reported by ``fw.app.name``) and version are required to uniquely identify the package. * - ``fw.app.bundle_id`` + - running - 0xc0000001 - Unique identifier for the DDP package loaded in the device. Also referred to as the DDP Track ID. Can be used to uniquely identify
Changeset 410d06879c01 ("ice: add the DDP Track ID to devlink info") added description for a new devlink field, but forgot to add one of its columns, causing it to break: .../Documentation/networking/devlink/ice.rst:15: WARNING: Error parsing content block for the "list-table" directive: uniform two-level bullet list expected, but row 11 does not contain the same number of items as row 1 (3 vs 4). .. list-table:: devlink info versions implemented :widths: 5 5 5 90 ... * - ``fw.app.bundle_id`` - 0xc0000001 - Unique identifier for the DDP package loaded in the device. Also referred to as the DDP Track ID. Can be used to uniquely identify the specific DDP package. Add the type field to the ``fw.app.bundle_id`` row. Fixes: 410d06879c01 ("ice: add the DDP Track ID to devlink info") Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- Documentation/networking/devlink/ice.rst | 1 + 1 file changed, 1 insertion(+)