From patchwork Thu Apr 30 01:34:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rylan Dmello X-Patchwork-Id: 220262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE18C83006 for ; Thu, 30 Apr 2020 01:34:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C52820787 for ; Thu, 30 Apr 2020 01:34:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=rylan.coffee header.i=@rylan.coffee header.b="CKLv1oQ6"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SNFr3fxp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726577AbgD3Be2 (ORCPT ); Wed, 29 Apr 2020 21:34:28 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34177 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgD3Be2 (ORCPT ); Wed, 29 Apr 2020 21:34:28 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E64F55C0098; Wed, 29 Apr 2020 21:34:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 29 Apr 2020 21:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rylan.coffee; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=gdaFA2XkrvEtYXytp2mxXVDgZSI YUFcivrn9R/xM5YM=; b=CKLv1oQ6TUexrFBL4TlN9aP6IUlawlmTojkSNNzT/08 0ao9TU1diTYrFNtJv9EHzY0Yvyw1GZEhwHg+gCy67USLeVmjHfHNbkhYUDKaYPlx b4CinJbh/v7yo1C3Z9zNdjT/dcLBBFeIj0AjDy/sL5SOfXEjBGHUqwmTOpgQJ66z 51YgAHg29Vh5UWkBuo1tF4sE46ENbXRr3JfXZioLxl28W6M8hWYFUx1J2WCOdNDT v6vkRxCOLy3FoRdNBUQAwAsA3n7uKpxBUqCJazuUnyfChPxDThl9AxEF5H03BueC wETHTUqtdnAnbl1DCk6n7obiNtxRTHP2bp1xOGCW2PA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=gdaFA2 XkrvEtYXytp2mxXVDgZSIYUFcivrn9R/xM5YM=; b=SNFr3fxpj8w+zqWE+xpJ0Z G/sNTus4+EJ6w8fTgSiaK4JO26tj7GILPmEl0ZJz9Kz6irZPTpO1pbymz8OB/mks RE2Jk89nxfElFXqQtCuh4zssfpP+8kO/v7p20+ryb5a5pSrci68wTr+rOnprK84u GBekVXMWTFqbb1orG5KIuw71jyVyT0LclOUkyGTpYLE6Q46Gr8INT/ywlVtGuPIy BbPoe+8XYEhXRwNf4W3ui/IaYUoCRMPf1gJVbfcmE+lm0c9IXGVNtvbIGxl8KG3a Xs93gtTb7Jd/LdaXqijaKK5AbEoiC1C09cS0+4Av0yypz/M4+NvsCJN7+GX1NptQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieeggdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtjeenucfhrhhomheptfihlhgrnhcu ffhmvghllhhouceomhgrihhlsehrhihlrghnrdgtohhffhgvvgeqnecuggftrfgrthhtvg hrnhepjeffvefffeevgfdtteegudffieduveeuhfettddvueehveethfffgeetfeeghfeu necukfhppedutdekrdegledrudehkedrkeegnecuvehluhhsthgvrhfuihiivgepfeenuc frrghrrghmpehmrghilhhfrhhomhepmhgrihhlsehrhihlrghnrdgtohhffhgvvg X-ME-Proxy: Received: from athena (pool-108-49-158-84.bstnma.fios.verizon.net [108.49.158.84]) by mail.messagingengine.com (Postfix) with ESMTPA id 82AFC3280066; Wed, 29 Apr 2020 21:34:26 -0400 (EDT) Date: Wed, 29 Apr 2020 21:34:25 -0400 From: Rylan Dmello To: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Greg Kroah-Hartman , netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Joe Perches Subject: [PATCH v2 5/7] staging: qlge: Remove multi-line dereference from ql_request_irq Message-ID: <517d71f0cbc55e6880c19a9ff16c2c8ab8913251.1588209862.git.mail@rylan.coffee> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix checkpatch.pl warning: WARNING: Avoid multiple line dereference - prefer 'qdev->flags' Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index bb6c198a0130..9aa62d146d97 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -3415,9 +3415,9 @@ static int ql_request_irq(struct ql_adapter *qdev) &qdev->rx_ring[0]); status = request_irq(pdev->irq, qlge_isr, - test_bit(QL_MSI_ENABLED, - &qdev-> - flags) ? 0 : IRQF_SHARED, + test_bit(QL_MSI_ENABLED, &qdev->flags) + ? 0 + : IRQF_SHARED, intr_context->name, &qdev->rx_ring[0]); if (status) goto err_irq;