From patchwork Tue Oct 30 09:00:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 12575 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 763BD23DE2 for ; Tue, 30 Oct 2012 09:00:26 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 16554A181F8 for ; Tue, 30 Oct 2012 09:00:25 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so30073iej.11 for ; Tue, 30 Oct 2012 02:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:message-id :date:from:user-agent:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=Q+X6jHOdWoP13DTSL9TlkZtZZm/6MEvbdXGfsD1vftE=; b=NaHv7QsP6d0VkYnl9PU7i3n8QEhhiIPBgzHw3d7F4G/b+K1EYQcJewvV1N62Y+slP6 HnAHABqDu6c4w7qKI+aRZYb/N1vg0aOstcBkEtHFqWGv29OioY6QLBTgCW1ByU1HXSRs BAeGSTvI1ISE3EnZ6RimrRbNzVBWx/Y322Rhu/Knk82KjLb4UBZSfQmIv1rPcs77NUnu BxGnnk09E3bAnHEEetLTdiuFU48+WoeDVU/eCijk6ImJJRl+NSUsNPc+EcQTTPv1jL9j nKSMF0tkir7Dd1bUj1Pzvy4WM3/Q4uhPdM3sWg2fl4JUDqJ4l564OJsKkJcEwddIJcWE cIag== Received: by 10.50.152.137 with SMTP id uy9mr757015igb.62.1351587625818; Tue, 30 Oct 2012 02:00:25 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp366581igt; Tue, 30 Oct 2012 02:00:25 -0700 (PDT) Received: by 10.204.9.3 with SMTP id j3mr10293912bkj.15.1351587623669; Tue, 30 Oct 2012 02:00:23 -0700 (PDT) Received: from mail-bk0-f50.google.com (mail-bk0-f50.google.com [209.85.214.50]) by mx.google.com with ESMTPS id ig14si205663bkc.16.2012.10.30.02.00.23 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 30 Oct 2012 02:00:23 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.214.50 is neither permitted nor denied by best guess record for domain of daniel.lezcano@linaro.org) client-ip=209.85.214.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.214.50 is neither permitted nor denied by best guess record for domain of daniel.lezcano@linaro.org) smtp.mail=daniel.lezcano@linaro.org Received: by mail-bk0-f50.google.com with SMTP id q16so19224bkw.37 for ; Tue, 30 Oct 2012 02:00:23 -0700 (PDT) Received: by 10.205.122.1 with SMTP id ge1mr9752728bkc.110.1351587622854; Tue, 30 Oct 2012 02:00:22 -0700 (PDT) Received: from [10.155.11.166] ([91.224.175.20]) by mx.google.com with ESMTPS id x13sm157254bkv.16.2012.10.30.02.00.21 (version=SSLv3 cipher=OTHER); Tue, 30 Oct 2012 02:00:22 -0700 (PDT) Message-ID: <508F9724.50804@linaro.org> Date: Tue, 30 Oct 2012 10:00:20 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Viresh Kumar CC: Ben Hutchings , netdev@vger.kernel.org, linaro-dev@lists.linaro.org, davem@davemloft.net, linux-kernel@vger.kernel.org, patches@linaro.org Subject: Re: [PATCH] net: dsa/slave: Fix compilation warnings References: <5afab1ebe83e4361f1fd75bbea0c559af195bf02.1351529738.git.viresh.kumar@linaro.org> <1351540778.2721.7.camel@bwh-desktop.uk.solarflarecom.com> <508F8779.8070300@linaro.org> In-Reply-To: X-Gm-Message-State: ALoCoQkV9WRgtmlxgRrw6GsZidO3LfOIXxxnZojtClLupaNibyYVZgzbPXYh3EVWr4BGQpRoXx3o On 10/30/2012 08:55 AM, Viresh Kumar wrote: > On 30 October 2012 13:23, Daniel Lezcano wrote: >>> From: Viresh Kumar > >>> config NET_DSA_TAG_DSA >>> - bool >>> + bool "Original DSA packet tagging format" >>> + select NET_DSt >> >> typo NET_DSA > > Unbelievable mistake :( > > Will fix it after some reviews now :) Yeah, has to be ! ;) It is very curious if we disable all the configs option, a slave creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA enabled and none of the NET_DSA_TAG* enabled will raise a BUG in the probe function, right ? Maybe we should force at least one config when none are set ? the Distributed Switch Architecture. @@ -12,15 +13,15 @@ if NET_DSA # tagging formats config NET_DSA_TAG_DSA - bool + bool "tag dsa" default n config NET_DSA_TAG_EDSA - bool + bool "tag edsa" default n config NET_DSA_TAG_TRAILER - bool + bool "tag trailer" default n endif diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index 274791c..86326e3 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -1,8 +1,9 @@ -config NET_DSA +menuconfig NET_DSA tristate "Distributed Switch Architecture support" default n depends on EXPERIMENTAL && NETDEVICES && !S390 select PHYLIB + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA && !NET_DSA_TAG_TRAILER) ---help--- This allows you to use hardware switch chips that use