From patchwork Mon Sep 13 14:31:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 509787 Delivered-To: patch@linaro.org Received: by 2002:a17:906:f46:0:0:0:0 with SMTP id h6csp4092745ejj; Mon, 13 Sep 2021 08:29:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCPFYHlXXpu+Br/BtjN76p/Yje023NUql5yrCctmkqkBdOOggnFejzTSZqD9SJBEHIWHa6 X-Received: by 2002:a17:906:1557:: with SMTP id c23mr11944691ejd.371.1631546954250; Mon, 13 Sep 2021 08:29:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631546954; cv=none; d=google.com; s=arc-20160816; b=r58FEuzLtXJW4uXJa/080kAH1UWwbKXaB+mCzswkAeK/8a2t624KV137hnNDJe0PJw pQIB+hWvHcgr3S5yXUhlp0TWrcDP8aWoXegP990S2quAKZzws3XsZH62ChPZNHgnrWOX Tnf8DSL1ouCL4u6ODJvqqARXO1/7U41cjw2kLyv/qNld9w7FbN97qbEpHyIYRapQnjjs sBTxj8xrSejix2t31Ft2w4xt5bkwXw+kX24IgahjQRJL8WOMHPz4/mDJIwILH8IpaQql DRcyJK8UoFKPOgV/0i6d6CHK1e+W6NdTUfSFEeFeSmOaW6yEmeGSbx9y3DisJh9YCp+O pXNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=PoUTaRHlUiL74+HRLvOdLIuWeO3v+r2S12sV144Rdls=; b=NbnLKX8pLd8KRNIoGBH7YKRlyPN/kybvamyk9RXNgMZAQnjtAvoCe+HUpisPg/il7j YvKxTMoNql6E6sdqVZT7GOA5GXD3u/3k0qVoXnndAZnfbytp/XgGuPaq7ZbXYpCMoUeW TpISspfFzPq6we7VXPBSP+v5icFkM0lh1Ef1/1E5rUbjmY6tbSJz6P6hfoacSUibVP3D 0wINo4jbiKIYD7uEzebdhXQ0bbiNMWg0lPcitI2QUf0bnwb1cehlaEL3+p7lgnEHE9f+ vNFTgw1CIISxdy7rXV7IezkzlFgEunD5ZcsfVXVHfEAPubg/1PReSDLPfOQCaXeeWU5n lSyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JQITu67v; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu1si7795550ejb.482.2021.09.13.08.29.14; Mon, 13 Sep 2021 08:29:14 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JQITu67v; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232952AbhIMPa1 (ORCPT + 8 others); Mon, 13 Sep 2021 11:30:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344470AbhIMPaL (ORCPT ); Mon, 13 Sep 2021 11:30:11 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B28E4C112418 for ; Mon, 13 Sep 2021 07:34:02 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id y6so17744536lje.2 for ; Mon, 13 Sep 2021 07:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PoUTaRHlUiL74+HRLvOdLIuWeO3v+r2S12sV144Rdls=; b=JQITu67vzA1T6rpPa1teGVgEYyAt0f7qfgAeuETp1GBOBXjy48IAe3AOo5EA7l2c5Q okad5WokkFuCkXLiY6vaalV4ClWErJn6zagKt9riWMz+6/peAs0qB1Cbt/foYoJ3lVqQ XXj671zrIUEgb6O0IlpzOhLqyHfi3L4RgEJkpmwqw8+sqcfd1tF+GFPXW+1tSpptOLQ4 BAAaSsnEWxy09NTQW7G5zJGMzhbw28NAvfrMdkmJiMYumVSLQBAt8WRbFEfTPsoRGcsl bg2ChLYWhO+oKEU6oUCk0usVY6Tjjyn7kri+NnT2SmSjyyej9KBunLgInytaHYMQVi8L Qvgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PoUTaRHlUiL74+HRLvOdLIuWeO3v+r2S12sV144Rdls=; b=OX7BxlSMHr01FdedvC+/ruYqmjTVkW/0n082G9xS4HhGQKSiHW/JlThvC5+QBCgEPi SfEXjxtDpjk22iCQeuRX7sn4TaUBZzHpVs1JQ6k7Mw6/lvMS48CFVCunAwDvqT5Z1dDH MwJMlkUHUTETpeb1Ve8fKZrF50qHsUjeE6qmeGmFoYYZNbbcZBPgROQ49fNQRF7VhcGM XUIOq1Ltl5TXJomIvh2KaJY+JuGDauOTAPlCLQv3ykz5T/quvvkVuRGEYrzWoRuJG88y htFY7TxMTt9gYDEzqUXAogilFjNPJe0lKd/mriQ4kWHAU22kvT1wpTNpN8YQ1SM4bjKv n+Ew== X-Gm-Message-State: AOAM532N9Ca1CVhiS3pY9JIR1orBONHjecd88Nc1OAkqXCcC2GSba6j4 Rj544++cqz3gWP7PSnKJ1tkAZA== X-Received: by 2002:a05:651c:225:: with SMTP id z5mr11100936ljn.409.1631543641025; Mon, 13 Sep 2021 07:34:01 -0700 (PDT) Received: from localhost.localdomain (c-fdcc225c.014-348-6c756e10.bbcust.telenor.se. [92.34.204.253]) by smtp.gmail.com with ESMTPSA id e18sm992497ljo.105.2021.09.13.07.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 07:33:59 -0700 (PDT) From: Linus Walleij To: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Linus Walleij Subject: [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames Date: Mon, 13 Sep 2021 16:31:56 +0200 Message-Id: <20210913143156.1264570-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This drops the code setting bit 9 on egress frames on the Realtek "type A" (RTL8366RB) frames. This bit was set on ingress frames for unknown reason, and was set on egress frames as the format of ingress and egress frames was believed to be the same. As that assumption turned out to be false, and since this bit seems to have zero effect on the behaviour of the switch let's drop this bit entirely. Signed-off-by: Linus Walleij --- net/dsa/tag_rtl4_a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1 Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c index f920487ae145..6d928ee3ef7a 100644 --- a/net/dsa/tag_rtl4_a.c +++ b/net/dsa/tag_rtl4_a.c @@ -54,7 +54,7 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb, p = (__be16 *)tag; *p = htons(RTL4_A_ETHERTYPE); - out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT) | (2 << 8); + out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT); /* The lower bits indicate the port number */ out |= BIT(dp->index);