From patchwork Mon Sep 13 08:30:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 510318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F54C433F5 for ; Mon, 13 Sep 2021 08:34:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E26660F46 for ; Mon, 13 Sep 2021 08:34:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238688AbhIMIfW (ORCPT ); Mon, 13 Sep 2021 04:35:22 -0400 Received: from mail-mw2nam12on2049.outbound.protection.outlook.com ([40.107.244.49]:21169 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238246AbhIMIe2 (ORCPT ); Mon, 13 Sep 2021 04:34:28 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y++ZtZz1tmTEuP89iaKnhzw60PksckQEiX3l82gKBBCCaoZxjiJkdX7yob7yZbGo4RjhW2T+AP0r+pAqVqz/D+5yjNKaJDh5aUvcXM5V0HrWZ4aXcVybvD6hR9gAQbWy0phLfXvK85jr5EDfQdJKBxUrBiJTwyPrp8GPZDuOeI1cMvryINzMAl8R+TexQfIDebWHt+T1xJFm+b6gaIb6zXB9lz5L5y8+5jBmcUuaDW6TvP3BJZqZnPCxD6VACHhmq2oufMozTCxffhDBSRggvHOT58QKnjK21iAREdt7/j9/eR1T3eUVMMkf5zEcSMUHa1HpfkmP2Puk+lv3Ew33aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xsUUtMkFWtWrY3otxSBJQqe+VKNKELAgz0g8V67SD4c=; b=Hr6HIZd8khItYUS6J3+BVkCYH0Rq1pk3DDFaa8iuOgJLl7xsVLAMfLBdt+MfZZKyKNsM96/PtD7RrrvTLpAkEj/y/4ai/pZDsAaGmb4SjyyFK1ZMCjOkYLrM1bLK6V08+/EWR1uaTIIL4EUq7UEQFcD+yXAzUSAC1hSTrQAunN/wrJVp2X9JVadlJaEUNcl6yLKnlYMc6v45IdPkx8j1q+YheQlhLsFXR9By2ycYDqGsYOF+F4W2spkLPbvzcC4O9Xdrdvg6Wz9dLxzs7If3qgiHCoXj+ElfJWiPLziqnL50RNUa59MNC7F2RoDr5M3LP2iepu1tSk5qQHX083+UoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xsUUtMkFWtWrY3otxSBJQqe+VKNKELAgz0g8V67SD4c=; b=YTU7ACEEaOxENH1ZrP5h4014qAv+i9W1ZVFkjiMOfCWrM6quLzlpkFSOorZYTQz7oITj6VZ5zvqUgw4XmL9jZPrWG8OyWDgIFpY6vtVSXquN18jjaAfA7/aPsjKj0iMpN7/fiSAU3tDKQfYGImFMVRvmFZth2HuQmWoyfLSvV1U= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SN6PR11MB2717.namprd11.prod.outlook.com (2603:10b6:805:60::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Mon, 13 Sep 2021 08:32:31 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 08:32:31 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 30/33] staging: wfx: explain the purpose of wfx_send_pds() Date: Mon, 13 Sep 2021 10:30:42 +0200 Message-Id: <20210913083045.1881321-31-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> References: <20210913083045.1881321-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PAZP264CA0067.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 08:31:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ff3c8dc0-d48e-404e-8687-08d97690f39b X-MS-TrafficTypeDiagnostic: SN6PR11MB2717: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ICKRnZWe2yYB9KatO+4kemlvljt7lTQHY/wwA0FcstKXXeY4RxK8BZJk33zoRcbfVaKEssKlhuJqjh1tAS7NtaI2hEESMvaa3CfIL5ER2BUhA7FXBGhJHthlmH5Y/v+sD491zvtMwtpXcIIwyAy20NI+cUa5f2mR2M/E8TsMQ6B1n4TFsdvelQbIFmiwQnSb0NDIiOzLHKqTYejwfx+LyTWJFIDV44BnOZ70/yo9dlHWcJ06rfzpSo5F49pPbGH1t4vgZf06crY8wEvSrT+WdWNrazrqL0us9/WDSqi70ly05jW0P1jh+qOaZMaOFYz4YHcdDcf/KB7EUAu24YWR7/rT1w0o7kiaf3cROD2gYcCKF6TlDGmaKf2thtkJy5JBgmi2ZMMQMuX7ZXwfPPdIyS/pbNlJXj/rYIiv+aOGrtkX/o7suUOUDOPeUjCnkturxgE39ndpMt4yKRNejHadUH4Kxb0wRzIqOVqsVYzmM2lBlJ9JIlHaDHMdlWesNaYbKUQv66OsKFPBB3j0tZKaue5Ju77ilJOPCOOAMeqnBzJB4BMFIlQ/xeWZIjfiRU20rtmjdsU2y0iHlMpp0gNiHp3uUtl0TgS5Y/kxHXGXYgpSIlJjd1VbJrGHw16q1DZSIWY3KXYc+afhbsSoSXYidCwLnKUqof4+7lKALXF4vjhare79C2/c4d6pgub8lQ3JTJxsxVZ3XZAnVg6+81daMA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(2906002)(107886003)(26005)(66946007)(38100700002)(52116002)(7696005)(1076003)(956004)(36756003)(316002)(8676002)(38350700002)(186003)(8936002)(83380400001)(54906003)(66556008)(66476007)(508600001)(6486002)(5660300002)(6666004)(86362001)(2616005)(66574015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?CRnSVEy64345SoAnH+5mMyWm4?= =?utf-8?q?dG5qUwx0D+Yj27H9AjuWKsYP8+1mSvVsYaISyNUJBZ+5Zw/XIATARv8j?= =?utf-8?q?uAaOJOvPisNM6WNA72bodgHC/a+BQ5uBeqcVh7vcnIGqXaubIdrKrqrR?= =?utf-8?q?LUCbG5696gwfR1+FR0T+g0Tla+O1x3RXz+wykbY46MfCUUf4Zwm1fJMR?= =?utf-8?q?+ppNfQ3BWepIYBeFQW2CPKAmkpqx793poq8LPmUEojbYw8r+2WhuYrG8?= =?utf-8?q?BLgcD6IcSS4nMdTUkSyBNnxn6qx76ONv9IYEGEqteyUUAfRk9zPfXQw6?= =?utf-8?q?IeXnYDlNQRGojq/HpkcPhaVhZqlk9mA7IL1TGkAU45oJItkwC6K6l/60?= =?utf-8?q?9v/yZzmU9JsokYxRx8yEdzrrK5nM5SRu82AetVS0QTIrOT6WEYaByMQ7?= =?utf-8?q?pG3Smskpjmw/PKApfIEoyMWzBsz2U3PAs139700Hpci6+58NjV2DXra4?= =?utf-8?q?JdEgXfbTohr1Bc3z4Wuvw+8Ge9/q/nqTqmOzP23RXC2fnULLvA7w5LMA?= =?utf-8?q?TXc6hpOVR/pLOJslMKwP73V8tIpwWqEf5xkYIQGkzwT0cM9ErJbVlrxP?= =?utf-8?q?lbzlHPIVwvz3cSRLa5KLMeIsDwOdP9B2fuuJUoU88eB8Xx7cS9t5aQA1?= =?utf-8?q?YNF+fRQ+Ez2PUL5xIQ3yG2AMDspK21k+so/7J/C27XIwiLPahMaKhBCY?= =?utf-8?q?PSyaWQdCCVeCwoCtZzEBYlmgGP/qOSVb1AXndKn1l0TmsO6tBtslatCe?= =?utf-8?q?CdwwWYJq1JZNBwEPPp1kP8MDPfBFY6rfnhds5muitsHXQft2nc/Shhb+?= =?utf-8?q?I/NRkyBN7S+f0CX+OUN3s2bVaZhNMhIJge/WKNB7+7+sJDBZ2sORjIPt?= =?utf-8?q?EMMFnYSl0ZyhJEGVWOPi+5Sws3i5cWJV4YCBk7tcoVAhUNEIRj3gVjja?= =?utf-8?q?hTcVpHii9AQufnbpTU8n+ysgmLkGJqR+eOaT1TUt9q4i+4RMYMlj7Iob?= =?utf-8?q?49aAb5UghNfbtg7qDup/laAj+CztEF7Jhg3UJtNkmfD0UaFEJoPhWRa8?= =?utf-8?q?6eyfTw8ZKuODZozqf4E1X+3Iy3Qg4JDZVNmOSj5GRu75ihkmvLt4FhBq?= =?utf-8?q?BfgDr36JDAJ3yXcEToHfr1yJzapHT5vCV/QAo7JQrFVG2KpAPASl4btR?= =?utf-8?q?BSgL0RPf+hO9qs03xntuFMw1my0zp8gxd607A3hbyyLlS6sw6JeZ8kOx?= =?utf-8?q?Do7K9jDEOGyPh+Zo1I6JTmMVPvM2be6swVzCKuBYpX57xOfpBWjtJqUm?= =?utf-8?q?K3qSI7/KvLJSmISBeEtLKZhnhsafCuDctEBf7l0QyccmP8hUvXJt0FES?= =?utf-8?q?MFPd9YGKoa8Rs1ewnyEhcmR+6tFURcL?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff3c8dc0-d48e-404e-8687-08d97690f39b X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 08:31:58.5469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qfzC51OfaHymXdsvluO1DWZhmGHHa2BfvJSS/XOrW9s/m8PqXUOy2uvycywe4hcmriSKg6K9RJxLVuDURU99TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2717 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller On first look, the goal of wfx_send_pds() is not obvious. A small explanation is welcomed. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/main.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index 83292544b10a..4386e9957ee6 100644 --- a/drivers/staging/wfx/main.c +++ b/drivers/staging/wfx/main.c @@ -163,7 +163,20 @@ bool wfx_api_older_than(struct wfx_dev *wdev, int major, int minor) return false; } -/* NOTE: wfx_send_pds() destroy buf */ +/* The device needs data about the antenna configuration. This information in + * provided by PDS (Platform Data Set, this is the wording used in WF200 + * documentation) files. For hardware integrators, the full process to create + * PDS files is described here: + * https:github.com/SiliconLabs/wfx-firmware/blob/master/PDS/README.md + * + * So this function aims to send PDS to the device. However, the PDS file is + * often bigger than Rx buffers of the chip, so it has to be sent in multiple + * parts. + * + * In add, the PDS data cannot be split anywhere. The PDS files contains tree + * structures. Braces are used to enter/leave a level of the tree (in a JSON + * fashion). PDS files can only been split between root nodes. + */ int wfx_send_pds(struct wfx_dev *wdev, u8 *buf, size_t len) { int ret;