diff mbox series

[v1,1/3] net: mdio-mux: Delete unnecessary devm_kfree

Message ID 20210804214333.927985-2-saravanak@google.com
State Superseded
Headers show
Series Clean up and fix error handling in mdio_mux_init() | expand

Commit Message

Saravana Kannan Aug. 4, 2021, 9:43 p.m. UTC
The whole point of devm_* APIs is that you don't have to undo them if you
are returning an error that's going to get propagated out of a probe()
function. So delete unnecessary devm_kfree() call in the error return path.

Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/net/mdio/mdio-mux.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Lunn Aug. 7, 2021, 2:23 p.m. UTC | #1
On Wed, Aug 04, 2021 at 02:43:30PM -0700, Saravana Kannan wrote:
> The whole point of devm_* APIs is that you don't have to undo them if you

> are returning an error that's going to get propagated out of a probe()

> function. So delete unnecessary devm_kfree() call in the error return path.

> 

> Signed-off-by: Saravana Kannan <saravanak@google.com>


Reviewed-by: Andrew Lunn <andrew@lunn.ch>


    Andrew
diff mbox series

Patch

diff --git a/drivers/net/mdio/mdio-mux.c b/drivers/net/mdio/mdio-mux.c
index 110e4ee85785..5b37284f54d6 100644
--- a/drivers/net/mdio/mdio-mux.c
+++ b/drivers/net/mdio/mdio-mux.c
@@ -181,7 +181,6 @@  int mdio_mux_init(struct device *dev,
 	}
 
 	dev_err(dev, "Error: No acceptable child buses found\n");
-	devm_kfree(dev, pb);
 err_pb_kz:
 	put_device(&parent_bus->dev);
 err_parent_bus: