From patchwork Mon Jul 26 14:11:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Kleine-Budde X-Patchwork-Id: 485821 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp3866754jao; Mon, 26 Jul 2021 07:13:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4Ev5mDjK9+bB6bBwyviyLdkUVvcfXigNmASNtelGmauC922J043Woz/OqK5XjVQFhTIiF X-Received: by 2002:a5e:8816:: with SMTP id l22mr15214884ioj.100.1627308825916; Mon, 26 Jul 2021 07:13:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627308825; cv=none; d=google.com; s=arc-20160816; b=GRRmXM1u+Gk/UNfg4akIYJzbxF1QuUpMR2SGfcnq3jhVIAd69CY/oeKo87WZnxXmlb +F2bOzMOAmLA1sGPwIiPKqu2KR1UG5sSnUCuM5spR9Cna2wkAMtwR7urFtFwkRlHGNf3 JIk/u8H1CGGmRoJBsi5fkTCD8EAgtYKsa3qxxPWOKgUFATFXExS8Xv/oXfbzIYR0VbXE b1OG2BI/HZTtM9bXKjXp9km0noWEi2BTGJ2q9ANFPRKA9Ha97xcDjkVhjIrN13Gu/Egq cLqHYJZMleAtBBtBUpt/2iKF9XAwVHR9SZ0FipFm8UcM430v8Dyc0tlzBHJP1LNbAVud nDlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QRk5ClUauwWyCU+qkmtwMid8N/feGsVQgDBOzlPw/bY=; b=eYaPEEE16DH0w5zZrwTKDleYGoW/VD7r7LQE9wcIbV+7nzx+gE9E3PyFDTdVbDQ3HI 2iCvchlIxJNei2Lebc4bc1o9DfqzE/InMqOp/s5w/iJdNAg8H1qEpTHju+seJ9nVxbDL daID4P2ySJuQP5satbkUNy182vNM9MbbzYEhYjh2rQL1twVY1UzLeMKeHseyeB91Gmsa lyyUvk8Z/+cqkZyQepKlnm2t3NR9kF5iwLQ1eEKL4TIAOMJ+6uQBv8mr/J2kJrTfVXvc UjouBJnTqD0zzM4l79Fo7TWrK0qkPh0gO3rMowTuIj9lJVKSqSozpuO9294e3qI9FlCR cwHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si26190jak.77.2021.07.26.07.13.45; Mon, 26 Jul 2021 07:13:45 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233194AbhGZNdP (ORCPT + 8 others); Mon, 26 Jul 2021 09:33:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234657AbhGZNcr (ORCPT ); Mon, 26 Jul 2021 09:32:47 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0108C0617A4 for ; Mon, 26 Jul 2021 07:12:26 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m81LF-0001ja-Bb for netdev@vger.kernel.org; Mon, 26 Jul 2021 16:12:25 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id 3783565824D for ; Mon, 26 Jul 2021 14:12:10 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id EE2136581B8; Mon, 26 Jul 2021 14:11:54 +0000 (UTC) Received: from blackshift.org (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id 90596ae0; Mon, 26 Jul 2021 14:11:46 +0000 (UTC) From: Marc Kleine-Budde To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, kernel@pengutronix.de, Zhen Lei , Marc Kleine-Budde Subject: [PATCH net-next 22/46] can: at91_can: use DEVICE_ATTR_RW() helper macro Date: Mon, 26 Jul 2021 16:11:20 +0200 Message-Id: <20210726141144.862529-23-mkl@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726141144.862529-1-mkl@pengutronix.de> References: <20210726141144.862529-1-mkl@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zhen Lei Use DEVICE_ATTR_RW() helper macro instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Link: https://lore.kernel.org/r/20210603100233.11877-1-thunder.leizhen@huawei.com Signed-off-by: Zhen Lei Signed-off-by: Marc Kleine-Budde --- drivers/net/can/at91_can.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.30.2 diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c index 04d0bb3ffe89..ca736b26e218 100644 --- a/drivers/net/can/at91_can.c +++ b/drivers/net/can/at91_can.c @@ -1176,8 +1176,8 @@ static const struct net_device_ops at91_netdev_ops = { .ndo_change_mtu = can_change_mtu, }; -static ssize_t at91_sysfs_show_mb0_id(struct device *dev, - struct device_attribute *attr, char *buf) +static ssize_t mb0_id_show(struct device *dev, + struct device_attribute *attr, char *buf) { struct at91_priv *priv = netdev_priv(to_net_dev(dev)); @@ -1187,8 +1187,8 @@ static ssize_t at91_sysfs_show_mb0_id(struct device *dev, return snprintf(buf, PAGE_SIZE, "0x%03x\n", priv->mb0_id); } -static ssize_t at91_sysfs_set_mb0_id(struct device *dev, - struct device_attribute *attr, const char *buf, size_t count) +static ssize_t mb0_id_store(struct device *dev, + struct device_attribute *attr, const char *buf, size_t count) { struct net_device *ndev = to_net_dev(dev); struct at91_priv *priv = netdev_priv(ndev); @@ -1222,7 +1222,7 @@ static ssize_t at91_sysfs_set_mb0_id(struct device *dev, return ret; } -static DEVICE_ATTR(mb0_id, 0644, at91_sysfs_show_mb0_id, at91_sysfs_set_mb0_id); +static DEVICE_ATTR_RW(mb0_id); static struct attribute *at91_sysfs_attrs[] = { &dev_attr_mb0_id.attr,