From patchwork Mon Jul 26 14:11:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Kleine-Budde X-Patchwork-Id: 485820 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp3866520jao; Mon, 26 Jul 2021 07:13:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI8VQ9gNZJJcNnFgyN8te++B6W3SpJwMSQj3FF6pFUVLeaTht2KnhOFV6TtFzeQ+/oZ2PU X-Received: by 2002:a05:6638:3292:: with SMTP id f18mr17183300jav.120.1627308809695; Mon, 26 Jul 2021 07:13:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627308809; cv=none; d=google.com; s=arc-20160816; b=W/KUVYr7AHhfs8qEM33fhzrufdHUDIK0brgwHHHqDoDaxtE6KYxt6UjoFNUYCgunW3 GVEAkd9bf8s0Xs4ehxhSRVaRV5G2BUjED5ZJ5iMBKHdOwYTxB4lRLWf1qug+/KcPDYSu yzq1dFBeyVEC3oGDbHRFNpL/M3jr2U1eb+gp1ohsjNlMU2nekTxEwrMhrktTSdpSb9Yn IkBe8fNci5mFfzf8g8MyFSCrh6AMTZUivd7hseSrDWFAcn9d0KdCVYUQS5lmyWAhobr3 womUYU0W3REABZwa/4W6OuZ0BbkAlc4/7kgD0588PtP6NJlN3LEQ2aDIN+/DQ3jkEYsF kcGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=gQW0VFs1ZvD4OUGWoNgFAEoaob6RmIhkNdKCEgi4gJw=; b=n2nS9h9SJgLiDHbUB2WuH7Iw8e74ANpd43ZXPp4wAZ2wQ2KU0U/5GszOQ9Wn4SqeVV Wp+iVG0Y43olPkADmNm6PxqAJSRk9d2QVwRA+hcjlRo90TG0b1enAWVs4AH8HWyjeJbw K5jyZ5jBRCIzFKtGwFfY5we4t8PBNvOtzcc2oXitvSo1MUQ18OrW11DeVxAwprdW9n0Y ZWaqaFWA9VUb8EpmjYVislAitUQPEhPdtRQfx1TkGwEtmiMKs0ahO8O/X++l4Hz3ODXG sOHwTmtFuUZ2NpHBONRya5+nLjW0q+wbDvnVV4PruPVwAbRTwd/61UmW+nlS3FFkJJho qrjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si26190jak.77.2021.07.26.07.13.29; Mon, 26 Jul 2021 07:13:29 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233724AbhGZNc7 (ORCPT + 8 others); Mon, 26 Jul 2021 09:32:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234781AbhGZNcX (ORCPT ); Mon, 26 Jul 2021 09:32:23 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC626C0613D5 for ; Mon, 26 Jul 2021 07:12:23 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m81LC-0001dU-7X for netdev@vger.kernel.org; Mon, 26 Jul 2021 16:12:22 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id C19E165822F for ; Mon, 26 Jul 2021 14:12:07 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id 055446581AE; Mon, 26 Jul 2021 14:11:53 +0000 (UTC) Received: from blackshift.org (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id bf57c323; Mon, 26 Jul 2021 14:11:46 +0000 (UTC) From: Marc Kleine-Budde To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org, kernel@pengutronix.de, Zhen Lei , Marc Kleine-Budde Subject: [PATCH net-next 20/46] can: esd_usb2: use DEVICE_ATTR_RO() helper macro Date: Mon, 26 Jul 2021 16:11:18 +0200 Message-Id: <20210726141144.862529-21-mkl@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210726141144.862529-1-mkl@pengutronix.de> References: <20210726141144.862529-1-mkl@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zhen Lei Use DEVICE_ATTR_RO() helper macro instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Link: https://lore.kernel.org/r/20210603110902.11930-1-thunder.leizhen@huawei.com Signed-off-by: Zhen Lei Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/esd_usb2.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.30.2 diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c index 65b58f8fc328..60f3e0ca080a 100644 --- a/drivers/net/can/usb/esd_usb2.c +++ b/drivers/net/can/usb/esd_usb2.c @@ -474,7 +474,7 @@ static void esd_usb2_write_bulk_callback(struct urb *urb) netif_trans_update(netdev); } -static ssize_t show_firmware(struct device *d, +static ssize_t firmware_show(struct device *d, struct device_attribute *attr, char *buf) { struct usb_interface *intf = to_usb_interface(d); @@ -485,9 +485,9 @@ static ssize_t show_firmware(struct device *d, (dev->version >> 8) & 0xf, dev->version & 0xff); } -static DEVICE_ATTR(firmware, 0444, show_firmware, NULL); +static DEVICE_ATTR_RO(firmware); -static ssize_t show_hardware(struct device *d, +static ssize_t hardware_show(struct device *d, struct device_attribute *attr, char *buf) { struct usb_interface *intf = to_usb_interface(d); @@ -498,9 +498,9 @@ static ssize_t show_hardware(struct device *d, (dev->version >> 24) & 0xf, (dev->version >> 16) & 0xff); } -static DEVICE_ATTR(hardware, 0444, show_hardware, NULL); +static DEVICE_ATTR_RO(hardware); -static ssize_t show_nets(struct device *d, +static ssize_t nets_show(struct device *d, struct device_attribute *attr, char *buf) { struct usb_interface *intf = to_usb_interface(d); @@ -508,7 +508,7 @@ static ssize_t show_nets(struct device *d, return sprintf(buf, "%d", dev->net_count); } -static DEVICE_ATTR(nets, 0444, show_nets, NULL); +static DEVICE_ATTR_RO(nets); static int esd_usb2_send_msg(struct esd_usb2 *dev, struct esd_usb2_msg *msg) {